If the InputMethod's node is not in the scene, the default text location point
is returned.
-
Commit messages:
- 8281953: NullPointer in InputMethod components in JFXPanel
Changes: https://git.openjdk.java.net/jfx/pull/735/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&p
On Thu, 17 Feb 2022 12:57:27 GMT, eduardsdv wrote:
> If the InputMethod's node is not in the scene, the default text location
> point is returned.
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java
line 340:
> 338: if (window == null) {
>
On Sat, 19 Feb 2022 17:40:54 GMT, delvh wrote:
>> If the InputMethod's node is not in the scene, the default text location
>> point is returned.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java
> line 340:
>
>> 338: if (window == nul
On Mon, 21 Feb 2022 07:27:46 GMT, eduardsdv wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java
>> line 340:
>>
>>> 338: if (window == null) {
>>> 339: return new Point2D(0, 0);
>>> 340: }
>>
>>
On Thu, 17 Feb 2022 12:57:27 GMT, eduardsdv wrote:
> If the InputMethod's node is not in the scene, the default text location
> point is returned.
The fix looks good.
I thought about returning `null` if either the scene or the window is null. As
we need to fix this corner case, whether return
> If the InputMethod's node is not in the scene, the default text location
> point is returned.
eduardsdv has updated the pull request incrementally with one additional commit
since the last revision:
8281953: Format TextInputControlSkinTest
-
Changes:
- all: https://git.open
On Mon, 21 Feb 2022 11:30:17 GMT, Ajit Ghaisas wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>>8281953: Format TextInputControlSkinTest
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TextInp
On Mon, 21 Feb 2022 12:35:34 GMT, eduardsdv wrote:
>> If the InputMethod's node is not in the scene, the default text location
>> point is returned.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>8281953: Format TextInputCo
