Re: JavaFX fails to build with multiple different issues

2018-12-04 Thread Michael Ennen
Thanks for opening the PR! That's the beauty of the public Github repository. The changeset looks good. In order to get it accepted you will need to sign the OCA (Oracle Contributor Agreement) but Kevin or another Oracle dev should help you through that process by commenting on the PR. You took th

Re: JavaFX fails to build with multiple different issues

2018-12-03 Thread Ty Young
On 12/3/18 6:52 PM, Michael Ennen wrote: The first one is definitely a bug and I would consider opening a PR to remove the final modifier on https://github.com/javafxports/openjdk-jfx. Done. This is the first time I've ever done a PR re

Re: JavaFX fails to build with multiple different issues

2018-12-03 Thread Michael Ennen
The first one is definitely a bug and I would consider opening a PR to remove the final modifier on https://github.com/javafxports/openjdk-jfx. The second one is a gradle error - what gradle command-line invocation are you using? On Mon, Dec 3, 2018 at 4:58 PM Ty Young wrote: > So here is an od