[9] Review request: JDK-8165794: javapackager throws "No application jars found" when "-srcfiles" is omitted in CLI

Chris, Please review the changes about "No application jars found" exception. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165794 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165794/webrev.00/ --Victor

[9] Review request: JDK-8170609: Show Error When Mac AppStore Certificate Expired

Victor, Please review the changes to show an error when the MacApp Store certificate has expired. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170609 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170609/webrev.00/ Chris

[9] Review request: JDK-8088064: Enhance Launcher to Support Long File Names

Chris, Please review the changes about enhancing support of long file names. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088064 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8088064/webrev.00/ --Victor

JDK-8169649 Review request

Hello, everyone. Please have a look at my review request for new small test: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8169649 Webrev: http://cr.openjdk.java.net/~arusakov/8169649/webrev.00/ Thanks in advance.

[9] Review request for 8151170: WINDOW_MODAL dialog does not popup when restoring iconified owner window, which causes application freeze

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8151170 webrev: http://cr.openjdk.java.net/~ssadetsky/8151170/webrev.00/ Win32 API ::GetWindowRect() call returns fake -32000,-32000 location for iconified window. Solution: skip WM_MOV

[webkit] [9] Review request for 8170450: Crash while loading wordpress.com in HiDPI / Retina display

Hello Kevin, Guru, Murali, Please review the fix for JDK-8170450 <https://bugs.openjdk.java.net/browse/JDK-8170450>. Analysis: While applying a filter, WebCore get's ImageData from ImageDataJava using getPremultipliedImageData method. Our current implementation doesn&#

[9] Code Review Request For 8170421: Ensemble8 black flash at startup on b145+

Jim or Kevin, Please review this simple fix posted in the JIRA: https://bugs.openjdk.java.net/browse/JDK-8170421 Thanks, - Chien

[9] Review request: JDK-8170295 fx:jvmarg is not set

Victor, Please review this change to fix setting of jvmarg options: JIRA: https://bugs.openjdk.java.net/browse/JDK-8170295 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170295/webrev.00/ Chris

[9] Review request: JDK-8170122 Packager Tests

Victor, Please review these Java Packager examples: JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.01/ Chris

[9] Review request: JDK-8166281: -Bidentifier="" not working for modules in MAC

Chris, Please review the changes about fixing the -Bidentifier for backward compatibility: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166281 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8166281/webrev.00/ --Victor

[9] Review request: JDK-8168089, Secondary Launchers (*.exe files) are not generated

Chris, Please review the changes about secondary launchers: JIRA: https://bugs.openjdk.java.net/browse/JDK-8168089 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8168089/webrev.00/ --Victor

[9] Review request for 8164792: Memory leak in JavaFX WebView

  Hi Kevin, Arun, Guru, Please review the below leak fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164792 Webrev: http://cr.openjdk.java.net/~mbilla/8164792/webrev.00/   Thanks, Murali

Review request for JDK-8170140: rendering anomaly with MarlinFX renderer

Jim & Kevin, Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170140.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8170140 Ths bug fix seems very simple in MaskMarlinAlphaConsumer: +// ensure last block flag = 0 to process final b

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

wt.jar is on the classpath and may be potentially loaded in future with another GTK version (which will cause the process crash). The rest scenarios are covered by the 8156491 fix which I just posted for review. --Semyon Tom On 22.11.16 14:51, Semyon Sadetsky wrote: Hello Kevin & David, Pl

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

an instance of FXCanvas SWT must have been loaded already (You need to pass a parent Composite) so the native gtk-libs are there already loaded. Tom On 22.11.16 14:51, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

below really correct? >> >> in JFX embeded into SWT scenarios JFX loads GTK primarily ... >> >> If you create an instance of FXCanvas SWT must have been loaded already >> (You need to pass a parent Composite) so the native gtk-libs are there >> already lo

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

mposite) so the native gtk-libs are there >> already loaded. > That's right concern. Actually the fix covers the scenario when swt.jar > is on the classpath and may be potentially loaded in future with another > GTK version (which will cause the process crash). The rest scenario

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

6 14:51, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

d. That's right concern. Actually the fix covers the scenario when swt.jar is on the classpath and may be potentially loaded in future with another GTK version (which will cause the process crash). The rest scenarios are covered by the 8156491 fix which I just posted for review. --Semyon To

[9] Review request for 8156491: Autodetect GTK version for JFX

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8156491 webrev: http://cr.openjdk.java.net/~ssadetsky/8156491/webrev.00/ The fix implements the autodetect feature which protects JFX Glass toolkit from the crash caused by loading dynamic

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

SWT scenarios JFX loads GTK primarily ... If you create an instance of FXCanvas SWT must have been loaded already (You need to pass a parent Composite) so the native gtk-libs are there already loaded. Tom On 22.11.16 14:51, Semyon Sadetsky wrote: > Hello Kevin & David, > > Please re

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

16 г. 15:51 ч., Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot b

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

Hi, I think this line is incorrect: if (ver < 2 && ver > 3) { It should be || instead of && On 22.11.2016 г. 15:51 ч., Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev:

[9] Review request: 8170122: Packager Tests

Kevin, Adding Java Packager examples/tests. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.00/ Chris

[9] Review request for 8150175: Need replacement in FXDnD for DropTargetContext::addNotify, removeNotify

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8150175/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8150175 -- Thanks, Alexander.

[9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be detected using the check for

Re: initial webrev for review

On 11/21/16, 2:37 PM, David Hill wrote: updated: http://cr.openjdk.java.net/~ddhill/8163496.1 This fixed the popup issue I was seeing. Kevin, Chien, Semyon, Here is the initial webrev for reworking libglass addressing GTK issues. I am calling it inital because I have not finished the large am

initial webrev for review

Kevin, Chien, Semyon, Here is the initial webrev for reworking libglass addressing GTK issues. I am calling it inital because I have not finished the large amount of testing it needs, plus I may need to rework a small number of entry points (6) to make them dynamic. I am asking my reviewers

[Review request] 8169642: IndexOutOfBoundsException when sorting TreeTableView with multi-selection enabled

Vadim, Please review the following issue: https://bugs.openjdk.java.net/browse/JDK-8169642 http://cr.openjdk.java.net/~jgiles/8169642/ Thanks! -- -- Jonathan

[9] Review request: JDK-8168501 javapackager system wide installation is failed when bundled through ANT in windows operating system

Chris, Please review the changes about system wide installation (bundled through ANT). JIRA: https://bugs.openjdk.java.net/browse/JDK-8168501 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8168501/webrev.00/ <http://cr.openjdk.java.net/%7Evdrozdov/JDK-8168501/webrev.00/> --Victor

[9] Review request: 8169396: Include sources for javafx.* modules in src.zip

corrected the subject line Kevin Rushforth wrote: Please review the following change to include the sources for javafx.* modules into the JDK 9 src.zip. https://bugs.openjdk.java.net/browse/JDK-8169396 http://cr.openjdk.java.net/~kcr/8169396/webrev.00/ -- Kevin

[9] Review request:

Please review the following change to include the sources for javafx.* modules into the JDK 9 src.zip. https://bugs.openjdk.java.net/browse/JDK-8169396 http://cr.openjdk.java.net/~kcr/8169396/webrev.00/ -- Kevin

[9] Code Review Request For 8166932: Fix @Deprecated annotations for deprecated JavaFX methods

Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166932 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166932/webrev.00/ Thanks, - Chien

review: javac @compile.args does not pick up changes in local build

Kevin: https://bugs.openjdk.java.net/browse/JDK-8169747 http://cr.openjdk.java.net/~ddhill/8169747 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

[9] Review request: JDK-8167508 ant-javafx.jar and jdk.packager runtime version check

Kevin, Please review this change to have ant-javafx.jar check the version of Java that is running it and match the version it was intended to run with by comparing against a version string that is stored in the jar file. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167508 Webrev: http

[9] Review request: 8169683: Incremental build of WebKit native library is broken

Dave, Please review: https://bugs.openjdk.java.net/browse/JDK-8169683 The patch is in JBS. It is a simple one-line change to restore the behavior for native WebKit builds prior to the recent build changes to build with a Jigsaw-aware javac. -- Kevin

Re: [9] Review request: JDK-8162693 javapackager returns null if com.oracle.tools.packager.windows.WinAppBundler called twice

Correct links: JIRA: https://bugs.openjdk.java.net/browse/JDK-8162693 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162693/webrev.00/ <http://cr.openjdk.java.net/%7Evdrozdov/JDK-8162693/webrev.00/> --Victor Chris, Please review the changes about WinAppBundler. JIRA:

[9] Review request: JDK-8162693 javapackager returns null if com.oracle.tools.packager.windows.WinAppBundler called twice

Chris, Please review the changes about WinAppBundler. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162693 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162693/webrev.00/ --Victor

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

reasonable background color for it. - Chien On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.o

Re: [9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/01/ Thanks, Alexander. On 8/4/16 3:40 AM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00 for the issue https://bugs.openjdk.java.net/browse/JDK

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

. - Chien On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-80881

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Hi Jim and Kevin, Please review the proposed fix: JIRA:https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev:http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

[9] Review request: JDK-8165522 Remove #ifndef USE_JLI_LAUNCH from native launcher

Chris, Please review the changes about removing native packager JNI code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165522 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165522/webrev.00/ --Victor

[9] Review request: JDK-8162923 Error: Unknown Argument thrown by javpackager when argument values are passed with multiple words with in quotation

Chris, Please review the changes about argument quotation for javapackager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162923 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162923/webrev.00/ --Victor

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~c

Review request for JDK-8169270: Leverage new Java2D Marlin rasterizer for JavaFX

Jim & Kevin, Sorry to announce this code review in late, I thought JBS would have sent such email from the comment. Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8169270.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8169270 Reviewers: flar,

review: fix old jar list in build.gradle

Kevin, would you review: https://bugs.openjdk.java.net/browse/JDK-8169552 diff is inside the bug. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

et Am 10.11.2016 um 02:35 schrieb Chien Yang : Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

background is always white? Tom Von meinem iPhone gesendet > Am 10.11.2016 um 02:35 schrieb Chien Yang : > > Hi Jim and Kevin, > > Please review the proposed fix: > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 > Webrev: http://cr.openjdk.java.net/~ckyang/

[9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

review: correct concatenation of dependencies/*/*.extra files

Kevin, if you would review JBS: https://bugs.openjdk.java.net/browse/JDK-8169511 diff inline. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

[9] Review request: 8169500: Cannot build JavaFX with OpenJDK due to dependency on jdk.jfr

Dave, Please review: https://bugs.openjdk.java.net/browse/JDK-8169500 Diff is in the JBS issue. -- Kevin

[webkit] [9] Review request for 8167675: Animated gifs are not working

Hello Kevin, Guru, Murali, Please review the below patch. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167675 <https://bugs.openjdk.java.net/browse/JDK-8167675> Webrev: http://cr.openjdk.java.net/~arajkumar/8167675/webrev <http://cr.openjdk.java.net/~arajkumar/8167675/webrev&g

Re: [9] Review request: DK-8169417: JavaFX to include jake-compatible versions of module-info.java with import bundles

+1 I did a quick test on Mac and it worked for me. Chris > On Nov 8, 2016, at 4:11 PM, Kevin Rushforth > wrote: > > Hi, > > Please review the following fix to include jake-compatible versions of > module-info.java with our input bundles: > > https://bugs.

Re: [9] Review request: DK-8169417: JavaFX to include jake-compatible versions of module-info.java with import bundles

Looks good to me. Mandy > On Nov 8, 2016, at 4:11 PM, Kevin Rushforth > wrote: > > Hi, > > Please review the following fix to include jake-compatible versions of > module-info.java with our input bundles: > > https://bugs.openjdk.java.net/browse/JDK-8169417 &

[9] Review request: DK-8169417: JavaFX to include jake-compatible versions of module-info.java with import bundles

Hi, Please review the following fix to include jake-compatible versions of module-info.java with our input bundles: https://bugs.openjdk.java.net/browse/JDK-8169417 http://cr.openjdk.java.net/~kcr/8169417/webrev.00/ These new files end up in a new "modules_src_jake" subdirectory o

Re: Review request for 8169294:

On 11/7/2016 1:14 PM, Laurent Bourgès wrote: The only difference in Path2D.java I noted is that the Java2D version has an EXPAND_MIN which is 10, but you re-use INIT_SIZE, which is 20, here for the same purpose. You're right; I think I didn't want to add an extra constant but if you prefer be

Re: Review request for 8169294:

I'll review the test tomorrow (I'm a little backed up on my code reviews given the impending change to build with jigsaw JDK). -- Kevin Laurent Bourgès wrote: Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham <mailto:james.gra...@oracle.com>>: I'd like to see Kevin re

Re: Review request for 8169294:

Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham : > I'd like to see Kevin review the test as I'm not the best expert on our > JUnit framework. > I just added @Test annotations and kept the jtreg tags in header (for information). I could add asserts but JUnit does intercept any t

Re: Review request for 8169294:

I'd like to see Kevin review the test as I'm not the best expert on our JUnit framework. It looks like it is mostly just going to emit some printouts about performance (using echo() and log()) and verify that we don't get any ArrayBounds related exceptions (or worse, OO

Re: [webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites

Hello Kevin, Phil, I have incorporated review comments, Please take a look. http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/ <http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/> Thanks, Arun > On 04-Oct-2016, at 12:15 AM, Arunprasad Rajkumar > wrote: > >

[9] Review request for 8169309: Migrate SwingNode to the new float API of JLightweightFrame

Hello Kevin & Jim, Please review the fix for jfx9: webrev: http://cr.openjdk.java.net/~ssadetsky/8169309/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8153522 --Semyon

Review request for 8169294:

Hi, Please review this Path2D fix improving its storage growth algorithm as done in java2d: JBS: https://bugs.openjdk.java.net/browse/JDK-8169294 Webrev: http://cr.openjdk.java.net/~lbourges/fx/path2D/ PS: I converted the former jtreg test to JUnit test for OpenJFX. I hope it is correct, as I

[9] Review request for 8169204: Need to document JSObject Call and setSlot APIs to use weak references

Hi Kevin, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8169204 Webrev: http://cr.openjdk.java.net/~mbilla/8169204/webrev.00/   Thanks, Murali

[9] Review request for 8167175: JFX MediaPlayer Leaks Native Memory in Windows

Hi David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167175 Fixed several memory leaks. Thanks, Alexander

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

On 11/2/16, 1:01 PM, Phil Race wrote: Updated with your suggestion, moved the obvious hot spots to the top. David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sort

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sorting by path name. In particular files like build.gradle and so on .. people then get a sense of what it is

Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

JBS: https://bugs.openjdk.java.net/browse/JDK-8161704 Webrev: http://cr.openjdk.java.net/~ddhill/8161704/ Kevin, Chien, Vadim, There is a lot of change in this webrev, but there are a lot of common patterns (or sets of changes) ./apps - the majority of the change is altering the NB project fi

[9] Code Review Request For 8168616: -Xcheck:jni indicates there are missing exception checks in Font

Hi Phil, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8168616 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8168616/webrev.00/ Thanks, - Chien

[9] Review request for 8157686: JavaFX WebView fails to track URL changes for PJAX websites

Hi Arun, Kevin & Murali, Please review the fix for JBS: https://bugs.openjdk.java.net/browse/JDK-8157686 <https://bugs.openjdk.java.net/browse/JDK-8157686> Webrev: http://cr.openjdk.java.net/~ghb/8157686/webrev.00/ <http://cr.openjdk.java.net/~ghb/8157686/webrev.00/> RC and

[9] Review Request 8089915 : Input of type file doesn't honor "accept" attribute.

Hi Kevin, Arun, Please review the patch: JBS: https://bugs.openjdk.java.net/browse/JDK-8089915 Webrev : http://cr.openjdk.java.net/~asrivastava/8089915/webrev.00/ Regards, Ankit

[8u] Code Review Request For 8168821: Cleanup whitespace after fix for JDK-8156078

Hi Kevin, Please review this one line cleanup fix (diff in the JIRA): JIRA: https://bugs.openjdk.java.net/browse/JDK-8168821 Thanks, - Chien

[9] Review request for 8166856: OS X: dual screen rendering issue

JBS: https://bugs.openjdk.java.net/browse/JDK-8166856 webrev: http://cr.openjdk.java.net/~flar/JDK-8166856/webrev.00/ Some analysis in the last 2 comments of the JBS, but the main fix is to not send bounds changes down to native when no change has happened from FX code. The main culprit here w

[9] Review request for 8164933: Charts are layed out on each pulse

Hi Chien, Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8164933 http://cr.openjdk.java.net/~vadim/8164933/webrev.00/ Thanks, Vadim

[9] Code Review Request For 8166470: -Xcheck:jni indicates there are missing exception checks in Glass

Hi Kevin, Please the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166470 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166470/webrev.00/ Thanks, - Chien

[8u] Review request: Backport various Ensemble8 bug fixes to 8u

Vadim, Chien, and Daniil, Please review the following to backport several bug fixes in Ensemble8 from FX 9 to FX 8u: https://bugs.openjdk.java.net/browse/JDK-8168611 This is an umbrella task that needs a little explanation. We need to replace the old Ensemble2 demo on OTN with Ensemble8

[9] Review request: 8166382 [hidpi] Ubuntu 16.04: invalid coordinates when using glass robot

JBS: https://bugs.openjdk.java.net/browse/JDK-8166382 webrev: http://cr.openjdk.java.net/~flar/JDK-8166382/webrev.00/ Pretty self-explanatory fix... ...jim

[9] Review request: 8168258: Remove bad Javadoc links in skin constructors

Kevin, Could you please review the following webrev. This is a docs-only change. https://bugs.openjdk.java.net/browse/JDK-8168258 http://cr.openjdk.java.net/~jgiles/8168258 Thanks. -- -- Jonathan

[9] Review request for 8166847: NumberAxis: sticked numbers sometimes

Hi Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8166847 http://cr.openjdk.java.net/~vadim/8166847/webrev.00/ Thanks, Vadim

[9] Review request: JDK-8167973 Absolute path for module-path is not working when trying to execute javapackager from other drive in CLI

Kevin, Please review this change to fix the path separate for Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167973 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8167973/webrev.00/ Chris

review: remove unused imports

Kevin, Two JBS, same issue. https://bugs.openjdk.java.net/browse/JDK-8167520 https://bugs.openjdk.java.net/browse/JDK-8167522 one line diffs in the description Both of these cause compile/runtime issues with a modular build, and are currently unused anyway. -- David Hill Java Embedded Develo

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

I was waiting for the revised JDK 9 schedule before addressing this (it's still being finalized). In any case, I will check with the JDK 9 release team as to whether such an RFE could be accepted. -- Kevin Alexander Nyssen wrote: Hi Kevin, has there been any decision related to JDK-8166242

[9] Review request: JDK-8166305 Remove applet code

Kevin, David and Alexander, Please review the removal of applet code generate from the java packager for supporting JDK7 JavaFX. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166305 <https://bugs.openjdk.java.net/browse/JDK-8166305> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8

[9] Review request: JDK-8148720 fx packager: in the generated jnlp file, property element should be under resources element not j2se element

Kevin, This is a bug was introduced when the JNLP bundler was refactored to it’s own bundler. This just moves the JVM property outside the j2se section. JIRA: https://bugs.openjdk.java.net/browse/JDK-8148720 Webrev: http://cr.openjdk.java.net/~

[9] Review request: JDK-8166996 "javapackager --add-modules ..." throws Exception: jdk.tools.jlink.plugin.PluginException: java.lang.module.ResolutionException: Module ... not found

Kevin, The add modules and limit modules type needs to be a string rather than a set at this point in the Java Packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166996 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166996/webrev.00/

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

Hi Kevin, has there been any decision related to JDK-8166242 (Removal of com.sun.javafx.embed.AbstractEvents) yet? I was a bit busy the last weeks anyway, but I would still like to investigate JDK-8159227 (FXCanvas should properly forward consumption state of key events from SWT to embedded sce

[9] Review request: JDK-8167496 Packager Cleanup

Kevin, Just some cleanup. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167496 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8167496/webrev.00/ Chris

[9] Review request: 8165624: TreeTableView: incorrect scrolling range

Vadim, Could you please review the webrev for the mentioned issue: https://bugs.openjdk.java.net/browse/JDK-8165624 http://cr.openjdk.java.net/~jgiles/8165624/ Thanks! -- -- Jonathan

[9] Review request: JDK-8166661 Remove "-outfile" as compulsary when bundling modules in javapackager

Kevin, Please review the following change to remove the required argument -outfile. JIRA: https://bugs.openjdk.java.net/browse/JDK-811 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-811/webrev.00/ <http://cr.openjdk.java.net/~cbensen/JDK-811/webrev.00/> Chris

[9] Review request: JDK-8166958: javafx dll binaries are in the wrong directory in the jmod files

Dave and Chris, Please review the following build change for Windows to fix the location of the .dll files in the jmods: https://bugs.openjdk.java.net/browse/JDK-8166958 http://cr.openjdk.java.net/~kcr/8166958/webrev.00/ In parallel with your review I still need to sanity test it on Mac and

Re: [9] Review Request: 8165414 javapackager throws NullPointerException in Windows Operating System for CLI

Kevin, did you see this one too? Chris > On Oct 5, 2016, at 8:11 AM, Chris Bensen wrote: > > Kevin, > > This resolves the NullPointerExceptions when packaging on Windows. > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8165414 > > Webrev

[9] Review request for 8166677: HTMLEditor freezes after restoring previously maximized window

Hi Kevin, David Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166677 Webrev: http://cr.openjdk.java.net/~mbilla/8166677/webrev.02/   Thanks, Murali

[9] Review Request: 8166881 .cfg Configuration file contains hard coded values of path

Kevin, Fix so the config file entry of the jar file is not a hard coded path. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166881 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166881/webrev.00/

[9] Review Request: 8165414 javapackager throws NullPointerException in Windows Operating System for CLI

Kevin, This resolves the NullPointerExceptions when packaging on Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165414 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165414/webrev.00/

[9] Review request for 8166662: Gradle test takes more time when skipping sdk

Hi Dave, Kevin, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-812 http://cr.openjdk.java.net/~vadim/812/webrev.00/ Thanks, Vadim

[9] Review Request 8166775 : Audio slider works incorrectly for short files

Hi Kevin, Arun, Please review the fix for : JBS: https://bugs.openjdk.java.net/browse/JDK-8166775 Webrev: http://cr.openjdk.java.net/~asrivastava/8166775/webrev.00/ Tested on Win64 and Linux 64. Used webkit patch: https://trac.webkit.org/changeset/195809 Regards, Ankit

[9] Review request: 8167138: Menu does not respond on the repeating mouse clicks

Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167138 http://cr.openjdk.java.net/~jgiles/8167138/ Thanks! -- -- Jonathan

[9] Review request: 8167137: Keyboard navigation through collapsed menus in menubar should not show sibling menus

Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167137 http://cr.openjdk.java.net/~jgiles/8167137/ Thanks! -- -- Jonathan

[9] Review request: 8167134: Keyboard navigation between menus in menubar leads to incorrect selection

Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167134 http://cr.openjdk.java.net/~jgiles/8167134/ Thanks! -- -- Jonathan

<    4   5   6   7   8   9   10   11   12   13   >