Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Kevin Rushforth]

Note that there is now a 04 version.

It looks good to me, although someone more familiar with AWT should also 
check the AWT changes.


We will need a test program for this (as a follow-on issue if not now).

-- Kevin


Alexander Zvegintsev wrote:

Please review the updated version

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/
Now we are postponing actual window closing, it happens only after we 
ensure that native window pointer is valid on Swing side.


Thanks,
Alexander.

On 23/09/2017 08:01, Sergey Bylokhov wrote:

Hi, Alexander.
How can we be sure that the parent frame will not be disposed while 
we use a pointer?


long ownerWindowPtr = peer.getOverridenWindowHandle();
< Dispose the peer
if (ownerWindowPtr != 0) {
//Place window above JavaFX stage
CWrapper.NSWindow.addChildWindow(
ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
< Boom
}


On 9/21/17 22:56, Alexander Zvegintsev wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
 as JDK 
counterpart of this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should 
be included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the bug 
below is confidential.



I agree with what Kevin pointed out off-line that as in the dialog 
case, the FX side
of the code can use reflection and simply be a harmless 
non-functional no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

Re: Building OpenJFX 9 with OpenJDK 9+181

[Mario Ivankovits]

Hi!

I had the same problems when I tried to build JavaFX for the Raspberry PI this 
weekend.

I „fixed" that by adding the —add-exports to the build.gradle file.
The Google Drive Link will guide you to a hacky patch to the build.gradle file 
(+ some other changes). I was able to build JavaFX then. Beware: This patch 
also disables the systemTests.

https://copy-con.blogspot.co.at/2017/10/java-9-with-javafx-for-raspberry-pi.html#links

Best regards,
Mario


Am 10.10.2017 um 16:15 schrieb Kevin Rushforth 
>:

This sounds like a bootstrap problem. I suspect that we are missing the needed 
--add-exports in build.gradle to build using a JDK that does not already have 
javafx.* modules.

I filed the following bug to track this:

https://bugs.openjdk.java.net/browse/JDK-8189111

As a workaround, you can use the Oracle JDK 9 build as the boot JDK.

-- Kevin


Emmanuel Bourg wrote:
Hi,

I've some trouble building OpenJFX 9 with OpenJDK 9+181 and Gradle 3.2.1
on Debian. I get the following compilation errors:


/home/ebourg/openjfx9/modules/javafx.base/src/main/java/com/sun/javafx/binding/SelectBinding.java:47:
error: package sun.util.logging is not visible
 import sun.util.logging.PlatformLogger.Level;
^
   (package sun.util.logging is declared in module java.base, which
does not export it to module javafx.base)

/home/ebourg/openjfx9/modules/javafx.base/src/main/java/com/sun/javafx/property/PropertyReference.java:36:
error: package sun.reflect.misc is not visible
 import sun.reflect.misc.ReflectUtil;
   ^
   (package sun.reflect.misc is declared in module java.base, which
does not export it to module javafx.base)


I tried exporting the _JAVA_OPTIONS variable defined in
README-java-options and adding --add-opens parameters to build.gradle
but it didn't work.

What am I missing?

Emmanuel Bourg

Re: Building OpenJFX 9 with OpenJDK 9+181

[Kevin Rushforth]

This sounds like a bootstrap problem. I suspect that we are missing the 
needed --add-exports in build.gradle to build using a JDK that does not 
already have javafx.* modules.


I filed the following bug to track this:

https://bugs.openjdk.java.net/browse/JDK-8189111

As a workaround, you can use the Oracle JDK 9 build as the boot JDK.

-- Kevin


Emmanuel Bourg wrote:

Hi,

I've some trouble building OpenJFX 9 with OpenJDK 9+181 and Gradle 3.2.1
on Debian. I get the following compilation errors:


/home/ebourg/openjfx9/modules/javafx.base/src/main/java/com/sun/javafx/binding/SelectBinding.java:47:
error: package sun.util.logging is not visible
  import sun.util.logging.PlatformLogger.Level;
 ^
(package sun.util.logging is declared in module java.base, which
does not export it to module javafx.base)

/home/ebourg/openjfx9/modules/javafx.base/src/main/java/com/sun/javafx/property/PropertyReference.java:36:
error: package sun.reflect.misc is not visible
  import sun.reflect.misc.ReflectUtil;
^
(package sun.reflect.misc is declared in module java.base, which
does not export it to module javafx.base)


I tried exporting the _JAVA_OPTIONS variable defined in
README-java-options and adding --add-opens parameters to build.gradle
but it didn't work.

What am I missing?

Emmanuel Bourg
  

Building OpenJFX 9 with OpenJDK 9+181

[Emmanuel Bourg]

Hi,

I've some trouble building OpenJFX 9 with OpenJDK 9+181 and Gradle 3.2.1
on Debian. I get the following compilation errors:


/home/ebourg/openjfx9/modules/javafx.base/src/main/java/com/sun/javafx/binding/SelectBinding.java:47:
error: package sun.util.logging is not visible
  import sun.util.logging.PlatformLogger.Level;
 ^
(package sun.util.logging is declared in module java.base, which
does not export it to module javafx.base)

/home/ebourg/openjfx9/modules/javafx.base/src/main/java/com/sun/javafx/property/PropertyReference.java:36:
error: package sun.reflect.misc is not visible
  import sun.reflect.misc.ReflectUtil;
^
(package sun.reflect.misc is declared in module java.base, which
does not export it to module javafx.base)


I tried exporting the _JAVA_OPTIONS variable defined in
README-java-options and adding --add-opens parameters to build.gradle
but it didn't work.

What am I missing?

Emmanuel Bourg

SOLVED: Error building on Mac: compileDecoraNativeShadersMac fails

[Lennart Börjeson]

> 13 sep. 2017 kl. 11:33 skrev Lennart Börjeson :
> 
> I'm trying to build OpenJFX on my Mac in order to integrate with openjdk 10 
> (the shenandoah project; I know the vanilla jdk 9 has javafx built-in).
> 
> I believe I've followed the build instructions, but building still fails with:
> 
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> A problem was found with the configuration of task 
> ':graphics:compileDecoraNativeShadersMac'.
> > Directory 
> > '/Users/lennartb/RaT/openJDK/javafx-9/modules/javafx.graphics/build/gensrc/headers/javafx.graphics'
> >  specified for property 'headers' does not exist.
> 
> 
> I've tried building both OpenJFX 9 and 10, with the same results.
> 
> 
> I have MacOS 10.12, gradle 3.1, jdk 9 b181, and Xcode installed. I've 
> installed Qt 5.9, but I can't see that picked up by 'gradle projects'?
> 
> 
> Please advise.
> 
> /Lennart
> 
> 

Turned out I needed to specify:

gradle --no-daemon --max-workers 1


Best regards,

/Lennart