> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be
> larger than the running platform's maximum supported texture size, was
> addressed in openjfx14. The fix, based around
> the idea of capturing as many tiles of the maximum
On Tue, 19 May 2020 14:27:40 GMT, Ajit Ghaisas wrote:
>> Correct :)
>
> @kevinrushforth brought to my notice that there is a PR
> (https://github.com/openjdk/jfx/pull/210) opened for the same
> issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of
> this PR as it did not
On Fri, 12 Jun 2020 10:01:52 GMT, Martin Schelldorfer
wrote:
>> @kevinrushforth brought to my notice that there is a PR
>> (https://github.com/openjdk/jfx/pull/210) opened for the same
>> issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of
>> this PR as it did not have
On Fri, 12 Jun 2020 05:56:41 GMT, Pankaj Bansal wrote:
>> Here is the result on Ubuntu 20.04 with the latest changes:
>>
>> 
>>
>> Some tests seems intermittent.
>
> I have run the test
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8244824
>
> Fix : As simple as it gets !!!
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/220
On Thu, 11 Jun 2020 23:28:41 GMT, Phil Race wrote:
>> I should add that this is without any attempt to filter out `0` chars. Both
>> `UnicodeTextTest` and `UnicodeTextTest2`
>> run correctly with no crashes and no assertions when I comment out the
>> (ineffective) loop checking for 0 and set `
On Thu, 11 Jun 2020 18:08:18 GMT, Phil Race wrote:
>> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348
>
> Instead of a space you could use a ZWNJ U+FEFF. Because that is also the
> endian-ness
> mark, Unicode actually prefers you now to use U+2060 but you need to make
> sure the
> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
process reviewer comments: start == str
check on 0 char not needed anymore
-
Changes:
- all: https://git.
On Thu, 11 Jun 2020 13:26:33 GMT, Johan Vos wrote:
>> Interestingly enough, I don't see a crash due to the 0 character, but I am
>> seeing some new assertion warnings expecting
>> `length >= 0` even in cases where there isn't a 0 character.
>
> I saw that assertion as well, but that can come fro
On Fri, 12 Jun 2020 11:55:47 GMT, Pankaj Bansal wrote:
>> I have run the test on OL82 on updated code. Following are the results. I
>> will rerun this on Ubuntu 18.04 and get back
>> with the results > src="https://user-images.githubusercontent.com/6153953/84469824-918dfa80-ac9f-11ea-9494-362087
On Thu, 11 Jun 2020 22:59:04 GMT, Phil Race wrote:
>> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/PangoGlyphLayout.java
> line 140:
>
>> 139: runUtf8.put(run, str);
>> 140: if (che
On Fri, 12 Jun 2020 10:29:08 GMT, Ajit Ghaisas wrote:
>> @aghaisas can you proceed with this one or is there anything required from
>> my side?
>
> I need confirmation from you about which option you prefer (See my last
> comment above). @kevinrushforth also has asked
> the same question in his
On Fri, 12 Jun 2020 14:16:06 GMT, Johan Vos wrote:
>> If `str` is null, you would end up retrying it anyway, since `Map::get` will
>> return `null` the next time (if there is a
>> next time). Also, I think the dispose method might then crash trying to free
>> a null pointer. So I think Phil is
> ### Summary
> * Simplify and update the Gtk glass backend, making Linux a first-class
> OpenJFX platform.
>
> ### Goals
> * Make Linux a first-class OpenJFX platform (see Motivation);
> * Simplify the code and reduce it's size;
> * Update to gtk3 (it was originally a port from gtk2);
> * Remove
> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
use LinkedHashMap instead of HashMap
Only store the pointer to the utf8 string if its creation was successful
--
On Fri, 12 Jun 2020 13:07:53 GMT, Kevin Rushforth wrote:
>> I'm not sure what should happen if str is null. Do we want to be able to
>> retry later? In that case, we shouldn't store
>> it in the map. But if it is fatal, and seems to indicate a problem with
>> rtext (e.g. too big?), so in that c
On Fri, 12 Jun 2020 14:25:25 GMT, Kevin Rushforth wrote:
>> I don't think it will be `null` but it will be `0` in which case it is
>> stored in the `Map`
>> The only reason the str == null is then that we never tried to convert the
>> Java chars to utf8, unless I'm missing a
>> case?
>
> Oh, ri
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be
> larger than the running platform's maximum supported texture size, was
> addressed in openjfx14. The fix, based around
> the idea of capturing as many tiles of the maximum
On Fri, 29 May 2020 16:48:29 GMT, Johan Vos wrote:
>> Abhinay Agarwal has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typo: dispose should remove event handler
>
> worth discussing the case were a TextInput is the only control.
@mip
On Fri, 12 Jun 2020 12:37:01 GMT, Johan Vos wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/PangoGlyphLayout.java
>> line 140:
>>
>>> 139: runUtf8.put(run, str);
>>> 140: if (check(str, "Failed allocating UTF-8 buffer.", context,
>>> desc, a
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8244824
>
> Fix : As simple as it gets !!!
This pull request has now been integrated.
Changeset: b2008913
Author:Ajit Ghaisas
URL: https://git.openjdk.java.net/jfx/commit/b200891
In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and
Math.round produce different results and
EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error
on the line width and therefore sheared
rendering.
The changes were already proposed by the submitte
> ### Summary
> * Simplify and update the Gtk glass backend, making Linux a first-class
> OpenJFX platform.
>
> ### Goals
> * Make Linux a first-class OpenJFX platform (see Motivation);
> * Simplify the code and reduce it's size;
> * Update to gtk3 (it was originally a port from gtk2);
> * Remove
On Fri, 12 Jun 2020 12:49:42 GMT, Pankaj Bansal wrote:
> After the latest commit on June 10, this is not building for me on my Ubuntu
> 18.04. I am attaching the build log for
> reference. [build.log](https://github.com/openjdk/jfx/files/4770864/build.log)
It's now fixed. I had used two compila
On Fri, 12 Jun 2020 13:49:23 GMT, Thiago Milczarek Sayao
wrote:
> I had used two compilation parameters to limit Gtk on 3.8 (so it would
> generate error if any symbol > 3.8 were used).
> But that does not seem to work on 18.04, so I removed it.
Good. I was going to ask you about that, so I'm
On Wed, 3 Jun 2020 15:46:36 GMT, Oliver Schmidtmer
wrote:
> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and
> Math.round produce different results and
> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error
> on the line width and therefore
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be
> larger than the running platform's maximum supported texture size, was
> addressed in openjfx14. The fix, based around
> the idea of capturing as many tiles of the maximum
On Fri, 12 Jun 2020 13:23:29 GMT, Kevin Rushforth wrote:
>> Instead of a space you could use a ZWNJ U+FEFF. Because that is also the
>> endian-ness
>> mark, Unicode actually prefers you now to use U+2060 but you need to make
>> sure these
>> are processed correctly by pango. Unlike a space they
On Fri, 12 Jun 2020 14:49:50 GMT, Johan Vos wrote:
>> Oh, right. It will be a Long 0, not null. If you store it you will still
>> have the problem I mentioned with dispose
>> unless you add back in the `str != 0` check. And you would need a check for
>> `str != 0` in the layout method so that t
On Fri, 12 Jun 2020 13:05:03 GMT, Johan Vos wrote:
>> I agree. the text array is now the subset for the run, so effectively
>> run.getStart() should be zero,
>> so there should be no need for that call. This probably looks OK when there
>> is one run not otherwise.
>
> You're both correct. I si
On Fri, 12 Jun 2020 15:01:35 GMT, Johan Vos wrote:
>> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348
>
> Johan Vos has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use LinkedHashMap instead of HashMap
> Only store the poin
> ### Summary
> * Simplify and update the Gtk glass backend, making Linux a first-class
> OpenJFX platform.
>
> ### Goals
> * Make Linux a first-class OpenJFX platform (see Motivation);
> * Simplify the code and reduce it's size;
> * Update to gtk3 (it was originally a port from gtk2);
> * Remove
On Fri, 12 Jun 2020 13:51:58 GMT, Kevin Rushforth wrote:
>>> After the latest commit on June 10, this is not building for me on my
>>> Ubuntu 18.04. I am attaching the build log for
>>> reference.
>>> [build.log](https://github.com/openjdk/jfx/files/4770864/build.log)
>>
>> It's now fixed. I h
> ### Summary
> * Simplify and update the Gtk glass backend, making Linux a first-class
> OpenJFX platform.
>
> ### Goals
> * Make Linux a first-class OpenJFX platform (see Motivation);
> * Simplify the code and reduce it's size;
> * Update to gtk3 (it was originally a port from gtk2);
> * Remove
On Wed, 3 Jun 2020 16:07:24 GMT, Kevin Rushforth wrote:
>> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and
>> Math.round produce different results and
>> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one
>> error on the line width and therefore
On Fri, 12 Jun 2020 20:43:18 GMT, Kevin Rushforth wrote:
>> @Schmidor in general, we don't use the `/issue` command to identify other
>> issues that happen to be fixed by a commit.
>> Rather, if they are the same bug, or if one is caused by the other, we would
>> closed the other one as a dupli
On Mon, 18 May 2020 05:52:21 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244418
>>
>> Root Cause :
>> Incorrect assumption about menu list size.
>>
>> Fix :
>> Added check for empty menu list before trying to access it.
>>
>> Test :
>> Added a unit test tha
On Thu, 11 Jun 2020 20:47:12 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed unnecessery Ceil Functions
>
> The code looks good (with a couple minor formatting issues).
>
> All of
On Fri, 5 Jun 2020 07:02:57 GMT, Jesper Skov
wrote:
>> Here are a few preliminary comments:
>
> Can I do anything to expedite the landing of this - before it gets
> obsoleted? :)
Finally getting back to this. The build logic changes look good. So does the
new "readme" file. I tested it on Wi
On Fri, 1 May 2020 16:01:28 GMT, Jesper Skov
wrote:
>> build.gradle line 3391:
>>
>>> 3390: doFirst {
>>> 3391: if (IS_STUB_RUNTIME_OPENJFX) {
>>> 3392: println
>>> ""
>>
>> Perhaps this should be insi
On Thu, 30 Apr 2020 18:56:40 GMT, Jesper Skov
wrote:
> I have tested on Linux (Fedora 31) only.
> It works as intended (with one test failure due to 15-ea+4 being too old now).
>
> UPDATE_STUB_CACHE suggests there is some magic available to help manage the
> stub cache.
> But as I could not fi
On Fri, 12 Jun 2020 23:21:16 GMT, Kevin Rushforth wrote:
>> I have tested on Linux (Fedora 31) only.
>> It works as intended (with one test failure due to 15-ea+4 being too old
>> now).
>>
>> UPDATE_STUB_CACHE suggests there is some magic available to help manage the
>> stub cache.
>> But as I
42 matches
Mail list logo
