Hi Nir,
By default, the backend of System.Logger is java.util.logging,
as long as the java.logging module is present and no
custom LoggerFinder service has been deployed.
This means that in a usual testing environment, if a library
emits a log message using the System.Logger API, then a test
Hi Ajit,
Looks good to me. I obviously didn't review the
build changes.
best regards,
-- daniel
On 26/03/2018 12:36, Ajit Ghaisas wrote:
Thanks all for the review.
I have addressed the review comments in
-http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/
The changes are -
1.
Hi Kevin,
This sounds reasonable to me.
best regards,
-- daniel
On 23/03/2018 17:51, Kevin Rushforth wrote:
Hi Daniel,
Thanks for the review.
I like the idea of removing the unused levels and methods.
As for directly using System.Logger.Level, we have enough usages of the
Level and
Hi Mandy,
On 23/03/2018 17:00, mandy chung wrote:
System::getLogger should return the same instance if it has been
created.
Not necessarily. j.u.l does that, but System::getLogger may return a
new cheap wrapper. As you noted, if JavaFX sources only creates a
handful of loggers, the cost of
Hi Ajit,
I have two remarks,
1. I wonder if it's wise to keep the old unused levels like e.g.
Level.CONFIG in your new PlatformLogger.
The sun.util.logging.PlatformLogger had a bridge that allowed
it to transfer these levels unchanged to java.logging when
java.logging was the
Hi,
I don't recommend using sun.* proprietary APIs.
The safest way to suppress the logger output would be to
switch it off in a logging.properties file.
-Djava.util.logging.config.file=logging.properties
and inside:
logger-name.level = OFF
best regards,
-- daniel
On 22/09/14 05:30,
