Hi Ajit, Looks good to me. I obviously didn't review the build changes.
best regards, -- daniel On 26/03/2018 12:36, Ajit Ghaisas wrote:
Thanks all for the review. I have addressed the review comments in -http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/ The changes are - 1. Addressed the (c) year inaccuracies in files - modules/javafx.base/src/main/java/com/sun/javafx/collections/SetListenerHelper.java modules/javafx.graphics/src/main/java/javafx/scene/Scene.java 2. Removed tabs from modules/javafx.base/src/test/java/test/com/sun/javafx/binding/SelectBindingTest.java 3. Removed unused methods from com.sun.javafx.logging.PlatformLogger class. Also, I have created a new bug JDK-8200236 to address some of the valid suggestions from Mandy and Daniel. Request you to review the new webrev. Regards, Ajit
