Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-03 Thread Kevin Rushforth
On Fri, 29 Jul 2022 11:55:22 GMT, Laurent Bourgès wrote: >> At this point, due to time constraints, we will need to do this early in >> JavaFX 20 rather than late in JavaFX 19 (which is probably better anyway). > > @kevinrushforth could you tell me approximately when you will have free >

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-03 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v4]

2022-08-03 Thread Andy Goryachev
On Thu, 28 Jul 2022 16:00:11 GMT, Jeanette Winzenburg wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v6]

2022-08-03 Thread Andy Goryachev
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect > statement "Is functionally equivalent to calling > getSelectedIndices().contains(index)." > 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to > return true when at least one cell in *any* column

Integrated: Merge jfx19

2022-08-03 Thread Kevin Rushforth
On Wed, 3 Aug 2022 18:30:20 GMT, Kevin Rushforth wrote: > Merge `jfx19` into `master`. This pull request has now been integrated. Changeset: 4c1f4c20 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/4c1f4c20b99dfc8c8016c305983dfea5e1b9d6f2 Stats: 190 lines in 190

Re: RFR: Merge jfx19 [v2]

2022-08-03 Thread Kevin Rushforth
> Merge `jfx19` into `master`. Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits: - Merge jfx19 - Merge - 8289605: Robot capture tests fail intermittently on Mac M1 Reviewed-by: kcr - 8289397: Fix

RFR: Merge jfx19

2022-08-03 Thread Kevin Rushforth
Merge `jfx19` into `master`. - Commit messages: - Merge jfx19 - 8291589: Update copyright header for files modified in 2022 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jfx=862=00.0 -

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc

2022-08-03 Thread Andy Goryachev
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote: > The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc

2022-08-03 Thread Nir Lisker
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote: > The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc

2022-08-03 Thread Andy Goryachev
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote: > The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in

Re: RFR: 8289384: Fix warnings: method does not override the inherited method since it is private to a different package

2022-08-03 Thread Andy Goryachev
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote: > The fix includes: > - renaming of offending methods to avoid confusion > - explicitly declaring the offending methods as private Looks like the general sentiment is to keep the code as is and disable the warning. Withdrawing this PR.

Withdrawn: 8289384: Fix warnings: method does not override the inherited method since it is private to a different package

2022-08-03 Thread Andy Goryachev
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote: > The fix includes: > - renaming of offending methods to avoid confusion > - explicitly declaring the offending methods as private This pull request has been closed without being integrated. - PR:

[jfx19] Integrated: 8291589: Update copyright header for files modified in 2022

2022-08-03 Thread Ambarish Rapte
On Tue, 2 Aug 2022 19:16:26 GMT, Ambarish Rapte wrote: > Updating last modified year in the files that were modified during year 2022. This pull request has now been integrated. Changeset: dd30402a Author:Ambarish Rapte URL:

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-08-03 Thread Kevin Rushforth
On Thu, 21 Jul 2022 11:54:01 GMT, Florian Kirmaier wrote: >> Inline > > I've worked in the feedback, thank you @kevinrushforth > Small note, this change is not used for a while and is therefore well tested. @FlorianKirmaier This PR is pending the following: 1. Merge upstream master into your

Re: RFR: 8181084: JavaFX show big icons in system menu on macOS with Retina display [v5]

2022-08-03 Thread Kevin Rushforth
On Mon, 25 Jul 2022 18:53:21 GMT, Paul wrote: >> Looks good (and tested on Mac). I have some comments. > > Thanks for all the feedback. I've updated as per your suggestions @jperedadnr > and @kevinrushforth. Let me know how this looks to you - I'm learning a lot > here :-) > > I ran the tests

Re: RFR: 8218826: TableRowSkinBase: horizontal layout broken if row has padding [v2]

2022-08-03 Thread Ajit Ghaisas
On Tue, 28 Jun 2022 15:19:50 GMT, Marius Hanl wrote: >> This PR fixes a problem, where the layout is broken when a `(Tree)TableRow` >> has padding. >> As also mentioned in the ticket, the `layoutChildren` method in >> `TableRowSkinBase` is implemented wrong. >> >> The `layoutChildren` method

Re: 8087577: Fix host OS check with refactoring

2022-08-03 Thread Kevin Rushforth
A refactoring of build.gradle would be a very large undertaking that would likely not be accepted. Before you invest time in such an effort, you should describe at a high-level the sort of changes you envision. Starting with the high-level goal, it isn't clear to me that cross-building for

8087577: Fix host OS check with refactoring

2022-08-03 Thread Andre Queiroz
Hi, I've tried JFX cross building (Windows > Android; Linux > Android) and things got wrong, mainly on Windows. The build script tried to build native Windows libraries instead only Android native libraries. I'm working on a refactoring of the build script. There is a lot of work but, also, a

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-08-03 Thread Ambarish Rapte
On Sat, 30 Jul 2022 10:48:07 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/psMath.h line 98: >> >>> 96: * specular component. The computation is done in world space. >>> 97: */ >>> 98: void computeLight(float i, float3 n, float3 refl, float specPower, >>>

Re: JavaFX Media Enhancements Survey

2022-08-03 Thread إلياس سعداوي
1) ID3 metadata support for MP4 files. Rating:2 2) Support for multichannel audio rendering (more than 2 channels). Rating:1 3) Subtitles support for MP4 files and HTTP Live Streaming. Rating:1 4) HDR support. Rating:3 5) InputStream for AudioClip with PCM support. Rating:2 6) Public APIs to