> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect > statement "Is functionally equivalent to calling > <code>getSelectedIndices().contains(index)</code>." > 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to > return true when at least one cell in *any* column is selected on the given > row (was: *all* columns) > 3. change selectRowWhenInSingleCellSelectionMode() and > selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest > to reflect new reality. > > NOTE: proposed change alters semantics of isSelected(int) method (in the > right direction, in my opinion).
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: - 8235491: whitespace - 8235491: additional tests - Merge remote-tracking branch 'origin/master' into 8235491.isselected - 8235491: javadoc - 8235491: tree table view - Merge remote-tracking branch 'origin/master' into 8235491.isselected - 8235491: review comments - 8235491: whitespace - 8235491: javadoc - 8235491: 2022 - ... and 1 more: https://git.openjdk.org/jfx/compare/c300ac30...ad3c70b9 ------------- Changes: - all: https://git.openjdk.org/jfx/pull/839/files - new: https://git.openjdk.org/jfx/pull/839/files/6267a0e4..ad3c70b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=05 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=04-05 Stats: 447536 lines in 7514 files changed: 300975 ins; 103527 del; 43034 mod Patch: https://git.openjdk.org/jfx/pull/839.diff Fetch: git fetch https://git.openjdk.org/jfx pull/839/head:pull/839 PR: https://git.openjdk.org/jfx/pull/839
