Re: RFR: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar. [v7]

2022-08-16 Thread Sai Pradeep Dandem
> **Issue:** > When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the > horizontal scroll bar keeps flickering when the `TableView` width is reduced. > > **Cause:** > The table columns widths are recalculated only if the difference of the > `TableView` width and the total

Re: RFR: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar. [v6]

2022-08-16 Thread Kevin Rushforth
On Sat, 13 Aug 2022 06:58:13 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the >> horizontal scroll bar keeps flickering when the `TableView` width is reduced. >> >> **Cause:** >> The table columns widths are recalculated

Re: RFR: 8181084: JavaFX show big icons in system menu on macOS with Retina display [v5]

2022-08-16 Thread Kevin Rushforth
On Thu, 4 Aug 2022 08:22:29 GMT, Paul wrote: >> @gargoyle To clarify my inline comments, the minimal change you need to make >> is: >> >> 1. Change the tests of the four `jField` variables to remove the `> 0` (so >> it becomes a boolean test for non-null). >> 2. Change the tests of `width`

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

2022-08-16 Thread Kevin Rushforth
On Sat, 13 Aug 2022 13:24:30 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.6 release: >> >> The Marlin-renderer 0.9.4.6 release provides one bug fix in Stroker: skip >> repeated endpoint to preserve mitter orientation: see JDK-8264999, >>

RFR: 8292391: Add support for optional signing of native libraries

2022-08-16 Thread Kevin Rushforth
This PR enables an optional signing step inserted into the build right after the step to strip binaries that was added by [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260). As is the case with the `strip` step, the optional signing is only ever enabled for production builds when

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-16 Thread Nir Lisker
Nodejs, Rust, F sharp, Selenium... those are indeed some questionable entries for JavaFX. On Tue, Aug 16, 2022 at 6:25 PM John Neffenger wrote: > On 8/15/22 10:18 PM, Nir Lisker wrote: > > I also have entries there that don't exist. I suspect they have to do > > with building WebKit. Turns out

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v11]

2022-08-16 Thread Andy Goryachev
> The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in .settings/ Andy Goryachev has updated the pull request with

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-16 Thread John Neffenger
On 8/15/22 10:18 PM, Nir Lisker wrote: I also have entries there that don't exist. I suspect they have to do with building WebKit. Turns out they don't hurt. Right, they don't hurt. They're not for WebKit, though, and I found they over-complicate the sample as a starting-point for editing. It

Integrated: 8291908: VirtualFlow creates unneeded empty cells

2022-08-16 Thread Johan Vos
On Thu, 4 Aug 2022 14:30:40 GMT, Johan Vos wrote: > When calculating the viewportOffset, we now already take into account that > cells will have to shift. > > This prevents the creation of temporary empty cells in the layout phase. > One test needed to be fixed, since the number of invocations

Re: RFR: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane

2022-08-16 Thread Ajit Ghaisas
On Tue, 2 Aug 2022 10:45:54 GMT, Jose Pereda wrote: > As part of this PR or as possible follow-up, it could be also discussed that > the right/bottom padding of the graphic container shouldn't be 0 when there > is no header and the graphic is laid out to the left of the content area. We can

Re: RFR: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane

2022-08-16 Thread Ajit Ghaisas
On Tue, 2 Aug 2022 10:45:54 GMT, Jose Pereda wrote: > This PR fixes an issue when there is a DialogPane that has no header and no > graphic is set, by adding the `graphic-container` styleclass only when there > is a non-null graphic applied, preventing the padding that otherwise the > graphic

Re: RFR: 8291908: VirtualFlow creates unneeded empty cells

2022-08-16 Thread Ajit Ghaisas
On Thu, 4 Aug 2022 14:30:40 GMT, Johan Vos wrote: > When calculating the viewportOffset, we now already take into account that > cells will have to shift. > > This prevents the creation of temporary empty cells in the layout phase. > One test needed to be fixed, since the number of invocations