On Wed, 24 Aug 2022 14:49:47 GMT, Jeanette Winzenburg
wrote:
>> Dear @kleopatra : thank you for insightful comments and suggestions!
>>
>> I do agree that, in general, it might be beneficial to have one test case
>> per condition or failure, but it should not be a requirement. I believe it
>
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8292353: whitespace
--
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
-
On Fri, 12 Aug 2022 18:15:37 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last rev
On Fri, 12 Aug 2022 18:15:37 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last rev
On Wed, 17 Aug 2022 12:02:04 GMT, Ambarish Rapte wrote:
> Update libjpeg to current version release [9e](http://www.ijg.org/) of
> 16-Jan-2022
>
> reference: https://jpegclub.org/reference/reference-sources/
>
> Verified all test run on Windows and MacOS
This pull request has now been integra
On Fri, 12 Aug 2022 18:15:37 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last rev
On Wed, 24 Aug 2022 15:36:17 GMT, Jeanette Winzenburg
wrote:
>>> But: turned out that we currently don't have such a case :)
>>
>> But we do! (I this one of my earlier comments did not got lost by Jira,
>> sorry).
>>
>> In TextInputControlSkin : 334, we have
>>
>> control.setInputMethodRequ
On Wed, 24 Aug 2022 15:29:01 GMT, Andy Goryachev wrote:
> the constructor cannot distinguish between this property set by the user
true, but currently it doesn't even _try_ to.
So IMO that's __not__ a problematic pattern (as already pointed out in our
recent debate): the install sets whatever
On Wed, 24 Aug 2022 15:20:15 GMT, Jeanette Winzenburg
wrote:
> But: turned out that we currently don't have such a case :)
But we do! (I this one of my earlier comments did not got lost by Jira, sorry).
In TextInputControlSkin : 334, we have
control.setInputMethodRequests(new ExtendedInputMe
On Mon, 15 Aug 2022 15:37:15 GMT, Jeanette Winzenburg
wrote:
>>> A quick PoC is in [my fork off Andy's
>>> PR](https://github.com/kleopatra/jfx/tree/exp-skin-install-supportsInstall)
>>
>> @kleopatra :
>> Thank you so much for your effort to research the alternatives.
>>
>> The main issue th
On Wed, 24 Aug 2022 14:49:47 GMT, Jeanette Winzenburg
wrote:
>> Dear @kleopatra : thank you for insightful comments and suggestions!
>>
>> I do agree that, in general, it might be beneficial to have one test case
>> per condition or failure, but it should not be a requirement. I believe it
>
On Wed, 24 Aug 2022 15:04:58 GMT, Andy Goryachev wrote:
> I don't know, the file was created in 2013 by a certain Kevin Rushforth for
> RT-30490. Who am I to criticize the wisdom of the elders?
It was actually added a couple years earlier, by this commit:
commit bc3b2da484c5c957f557623261b279
On Tue, 23 Aug 2022 18:38:48 GMT, Andy Goryachev wrote:
> This change affects eclipse projects only - all eclipse projects are
> configured to use JUnit5.
Not the `base` module, the root one, called "jfx" or "rt".
-
PR: https://git.openjdk.org/jfx/pull/883
On Wed, 24 Aug 2022 14:59:57 GMT, Nir Lisker wrote:
> the root one, called "jfx" or "rt".
I don't know, the file was created in 2013 by a certain Kevin Rushforth for
RT-30490. Who am I to criticize the wisdom of the elders?
Besides, this question is beyond the scope of this PR.
-
On Wed, 24 Aug 2022 01:37:49 GMT, Nir Lisker wrote:
> I don't see why the base project needs a `.classpath` file at all considering
> that it doesn't contain sources.
'base' project does contain shims, other sources, generated sources. I think
we should keep it.
are the other changes ok?
---
On Tue, 23 Aug 2022 19:58:24 GMT, Andy Goryachev wrote:
>
> I do agree that, in general, it might be beneficial to have one test case per
> condition or failure, but it should not be a requirement.
well, this project follows (should, at least, there are legacy areas ;)
established best pract
On Wed, 24 Aug 2022 13:50:32 GMT, Ambarish Rapte wrote:
> Issue:
> When Narrator is running,
> 1. Deleting last character from `TextField` throws
> `IllegalArgumentException`, and
> 2. Deleting last character from `TextArea` throws `NPE`.
>
> Fix:
> When character is deleted, we receive an of
Issue:
When Narrator is running,
1. Deleting last character from `TextField` throws `IllegalArgumentException`,
and
2. Deleting last character from `TextArea` throws `NPE`.
Fix:
When character is deleted, we receive an offset larger by one than the current
text length. This scenario needs to b
On Wed, 17 Aug 2022 12:02:04 GMT, Ambarish Rapte wrote:
> Update libjpeg to current version release [9e](http://www.ijg.org/) of
> 16-Jan-2022
>
> reference: https://jpegclub.org/reference/reference-sources/
>
> Verified all test run on Windows and MacOS
Marked as reviewed by aghaisas (Review
Hi,
thanks for pointing me there but it doesn't seem to work for me. I want to
drop attachments from Outlook into my application. I tried to stream all
the DataFormats returned by getContentTypes() and used them to get content
either from e.getDragboard() and Clipboard.getSystemClipboard() and I
co
21 matches
Mail list logo
