On Fri, 16 Sep 2022 16:52:31 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293444: memory buddy
>
>
> Using Weak*Listeners eliminates the memory leak.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8293444: memory buddy
-
Changes:
- all: https://git.openjdk.org/jfx/pull/900/files
- new:
On Thu, 15 Sep 2022 17:12:14 GMT, Andy Goryachev wrote:
> Using Weak*Listeners eliminates the memory leak.
This looks like it will eliminate the leak. Using weak listeners like this
follows the same pattern as used by some of the other skins. I'll review and
test it next week.
On Thu, 1 Sep 2022 20:37:27 GMT, Alex wrote:
> This PR adds explicit [permissions
> section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions)
> to workflows. This is a security best practice because by default workflows
> run with [extended
On Wed, 7 Sep 2022 11:27:02 GMT, Alex wrote:
>> This PR adds explicit [permissions
>> section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions)
>> to workflows. This is a security best practice because by default workflows
>> run with
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote:
> Also, I would rather move the sources there to a specific package
> (test.manual ?) instead of a default package. Any objections?
That should probably be done via a separate cleanup bug, since it is outside
the scope of this IDE-only
On Mon, 5 Sep 2022 18:17:19 GMT, Alex wrote:
>> @sashashura You need to enable running GHA workflows in your personal fork
>> of the `jfx` repo. Given that you are changing the GHA workflow, we will
>> need to see the results from your run in this PR.
>
>> @sashashura You need to enable
On Wed, 14 Sep 2022 10:32:19 GMT, Jeanette Winzenburg
wrote:
>> Is it possible to have two or more rows with the same row index? i would
>> imagine that will break a lot of things.
>>
>> I am not sure why you think the lookup is brittle - after all,
>> VirtualFlowTestUtils uses lookup to
On Fri, 16 Sep 2022 16:13:57 GMT, Andy Goryachev wrote:
>> Modified the tree/table view internals to suppress the horizontal (a.k.a.
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
>> effect. This change complements fixes added in
>>
On Fri, 16 Sep 2022 16:14:49 GMT, Kevin Rushforth wrote:
>> will do.
>>
>> I do not like inconsistency: everywhere else in this file there is no space
>> after comma in type parameters, for example
>> ```TableViewSkinBase```
>> so, if one were to use a formatter, it will format to
>>
On Fri, 16 Sep 2022 16:06:23 GMT, Andy Goryachev wrote:
> will do.
just this one, though. Please don't reformat any others that you aren't
otherwise touching.
And yes, it is an area where we are inconsistent (it varies from file to file
and often within the same file).
-
PR:
On Fri, 16 Sep 2022 16:13:57 GMT, Andy Goryachev wrote:
>> Modified the tree/table view internals to suppress the horizontal (a.k.a.
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
>> effect. This change complements fixes added in
>>
On Mon, 12 Sep 2022 15:33:29 GMT, Andy Goryachev wrote:
>> Modified the tree/table view internals to suppress the horizontal (a.k.a.
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
>> effect. This change complements fixes added in
>>
> Modified the tree/table view internals to suppress the horizontal (a.k.a.
> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
> effect. This change complements fixes added in
> [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without addressing
> other bugs
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
On Fri, 16 Sep 2022 09:40:52 GMT, Ajit Ghaisas wrote:
>> Andy Goryachev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/8089280.suppress' into
>> 8089280.suppress
>> - 8089280: review comments
>
On Fri, 16 Sep 2022 14:09:39 GMT, Kevin Rushforth wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64
>
> The changes look good. I'm doing a final sanity test on
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 15 Sep 2022 11:56:56 GMT, Jens Lidestrom wrote:
>> Prior to this change it was not clear from the documentation if callers of
>> Platform#runLater must perform
>> any synchronisation to have writes of the calling thread be visible in the
>> JavaFX Application
>> Thread. It is important
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Mon, 12 Sep 2022 15:33:29 GMT, Andy Goryachev wrote:
>> Modified the tree/table view internals to suppress the horizontal (a.k.a.
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in
>> effect. This change complements fixes added in
>>
21 matches
Mail list logo
