Hi,
Another issue I stumbled across is the usage of the Independent property
on CheckBoxTreeItem. The docs read:
A BooleanProperty used to represent the independent state of this
> CheckBoxTreeItem. The independent state is used to represent whether
> changes to a single CheckBoxTreeItem should i
Yeah, I didn't consider the other direction, that makes sense.
--John
On 18/11/2022 18:28, Nir Lisker wrote:
I think that even if a node is set to indeterminate programmatically,
its parents should be updated at the very least (unless it's set to be
independent). Not updating the children seem
Hi,
I am trying to run tests with the officially released WebKit and Media
shared libraries using the -PSTUB_RUNTIME_OPENJFX option [1].
But it is failing in Gradle dependency verification with below error as
checksums are missing from verification metadata.
A problem occurred evaluating root pro
On Thu, 14 Jul 2022 08:05:25 GMT, Florian Kirmaier
wrote:
>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
>> a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests
I think that even if a node is set to indeterminate programmatically, its
parents should be updated at the very least (unless it's set to be
independent). Not updating the children seems reasonable.
On Fri, Nov 18, 2022 at 11:12 AM John Hendrikx
wrote:
>
> On 18/11/2022 00:10, Nir Lisker wrote:
On Fri, 18 Nov 2022 00:48:11 GMT, Andy Goryachev wrote:
> Added Util.parkCursor(Robot) method to move the cursor to lower left corner
> (while avoiding dock, tray, or active corners).
This pull request has now been integrated.
Changeset: 086dac0b
Author:Andy Goryachev
Committer: Kevin Rus
On Fri, 18 Nov 2022 17:10:04 GMT, Marius Hanl wrote:
>> That is a fair point.
>>
>> I'll have to change the code a bit, as `implementations()` method is called
>> before a `@BeforeClass`-tagged method (which is probably why originally
>> `Locale.setDefault()` was called there) and `aFormatter`
On Fri, 18 Nov 2022 17:00:42 GMT, Lukasz Kostyra wrote:
>> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConverterTest.java
>> line 60:
>>
>>> 58: private static final DateTimeFormatter aFormatter =
>>> DateTimeFormatter.ofPattern("dd MM HH mm ss");
>
On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra wrote:
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all
On Fri, 18 Nov 2022 17:00:08 GMT, Lukasz Kostyra wrote:
>> This is a good point. Moving the initialization of those two fields to the
>> `setupBeforeAll` method seems safest.
>
> That is a fair point.
>
> I'll have to change the code a bit, as `implementations()` method is called
> before a `@
On Fri, 18 Nov 2022 16:44:06 GMT, Andy Goryachev wrote:
>> Added Util.parkCursor(Robot) method to move the cursor to lower left corner
>> (while avoiding dock, tray, or active corners).
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last rev
On Fri, 18 Nov 2022 16:50:21 GMT, Andy Goryachev wrote:
>> The change moves Locale setting in the test to `@BeforeClass` and
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
>> locale and applies Locale.US, while `@AfterClass` method restores old VM
>> locale after
On Fri, 18 Nov 2022 16:17:55 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConverterTest.java
>> line 60:
>>
>>> 58: private static final DateTimeFormatter aFormatter =
>>> DateTimeFormatter.ofPattern("dd MM HH mm ss");
On Fri, 18 Nov 2022 15:45:46 GMT, Kevin Rushforth wrote:
>> The change moves Locale setting in the test to `@BeforeClass` and
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
>> locale and applies Locale.US, while `@AfterClass` method restores old VM
>> locale after
On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra wrote:
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all
> Added Util.parkCursor(Robot) method to move the cursor to lower left corner
> (while avoiding dock, tray, or active corners).
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8297213: review comments
-
Changes:
- a
On Fri, 18 Nov 2022 14:37:34 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8297213: review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/layout/RegionBackgroundImageUITest
On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra wrote:
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all
On Fri, 18 Nov 2022 16:00:33 GMT, Marius Hanl wrote:
>> The change moves Locale setting in the test to `@BeforeClass` and
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
>> locale and applies Locale.US, while `@AfterClass` method restores old VM
>> locale after all
On Fri, 18 Nov 2022 00:48:11 GMT, Andy Goryachev wrote:
> Added Util.parkCursor(Robot) method to move the cursor to lower left corner
> (while avoiding dock, tray, or active corners).
Looks good with one inline comment about a redundant call to `parkCursor`.
tests/system/src/test/java/test/rob
On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra wrote:
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all
On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra wrote:
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all
The change moves Locale setting in the test to @BeforeClass and @AfterClass
calls. @BeforeClass method call stores current default VM locale and applies
Locale.US, while @AfterClass method restores old VM locale after all tests are
completed.
I tested it both on Mac and Windows, in both cases L
On Wed, 16 Nov 2022 21:16:37 GMT, Johan Vos wrote:
>> Thiago Milczarek Sayao has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one n
On Thu, 17 Nov 2022 15:42:29 GMT, Johan Vos wrote:
>> Thiago Milczarek Sayao has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one n
On 18/11/2022 00:10, Nir Lisker wrote:
Hi,
I have been working on fixing some issues with the behavior
of CheckBoxTreeItem. I stumbled across this situation:
When a parent is de/selected, all of its children are set to the same
state. However, a CheckBoxTreeItem can be set to indeterminate
26 matches
Mail list logo
