On Tue, 20 Dec 2022 13:20:32 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> revert gradle min version
>
> build.properties line 93:
>
>> 91: # that is supported. It must be <= jfx.gradle.ve
On Thu, 24 Nov 2022 06:49:02 GMT, Michael Strauß wrote:
> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
> focus handling with event propagation. Since #852,
> `KeyHandler.setFocusVisible` is also called from mouse and touch event
> handlers, which makes the purpose
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
> Updating boot JDK to 19.0.1.
> Gradle 7.3 is not compatible with JDK 19.0.1 hence updated the gradle minimum
> version as well.
Ambarish Rapte has updated the pull request incrementally with one additional
commit since the last revision:
revert gradle min version
-
Changes:
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
>> focus handling with event propagation. Since #852,
>> `KeyHandler.setFocusVisible` is also called from mouse and touch event
>> handlers, which makes the purpo
On Wed, 21 Dec 2022 00:37:49 GMT, Thiago Milczarek Sayao
wrote:
>> This PR was previously discussed on #905.
>>
>> The approach is to grab the keyboard focus so the window that originated the
>> drag will keep it.
>>
>> I did some cleanup on grabbing related functions as well.
>>
>> `gdk_ke
> This PR was previously discussed on #905.
>
> The approach is to grab the keyboard focus so the window that originated the
> drag will keep it.
>
> I did some cleanup on grabbing related functions as well.
>
> `gdk_keyboard_focus()` is deprecated, so is `gdk_device*` functions in favor
> of
On Tue, 20 Dec 2022 01:43:11 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
On Tue, 20 Dec 2022 20:20:55 GMT, Kevin Rushforth wrote:
> @mstr2 The fix looks fine to me. I presume you have done enough testing to
> ensure no regressions?
>
I tested it by running it against SceneBuilder and playing around with focus,
where I noticed no regressions.
-
PR: ht
On Tue, 20 Dec 2022 01:43:11 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
On Tue, 20 Dec 2022 16:03:23 GMT, Ambarish Rapte wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into fixes/keyhandler-refactor
>> - review changes
>> - Remo
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
>> focus handling with event propagation. Since #852,
>> `KeyHandler.setFocusVisible` is also called from mouse and touch event
>> handlers, which makes the purpo
On Mon, 19 Dec 2022 15:29:28 GMT, Kevin Rushforth wrote:
>> **About Ubuntu 16.04:**
>> - `RestoreSceneSizeTest` should be fixed;
>> - I kept `gtk_window_focus_on_map` `TRUE` on Compiz - so it will behave as
>> before;
>> - I introduced a `WindowManager` enum in case different work arounds are
On Tue, 20 Dec 2022 01:43:11 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
> When recalculating sizes, we often don't want the current index and/or offset
> to change.
>
> Allow to fix the index/offset when doing recalculations.
>
> Fix JDK-8298728
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
move stateme
On Tue, 20 Dec 2022 01:35:14 GMT, Thiago Milczarek Sayao
wrote:
>> This PR was previously discussed on #905.
>>
>> The approach is to grab the keyboard focus so the window that originated the
>> drag will keep it.
>>
>> I did some cleanup on grabbing related functions as well.
>>
>> `gdk_ke
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
>> focus handling with event propagation. Since #852,
>> `KeyHandler.setFocusVisible` is also called from mouse and touch event
>> handlers, which makes the purpo
On Tue, 20 Dec 2022 08:42:10 GMT, Ambarish Rapte wrote:
> Updating boot JDK to 19.0.1.
> Gradle 7.3 is not compatible with JDK 19.0.1 hence updated the gradle minimum
> version as well.
Looks good, although there is no need to bump the minimum version of gradle.
I'll do a quick test and then a
On Thu, 15 Dec 2022 14:23:57 GMT, Karthik P K wrote:
> Spinner was not stopping because it was getting removed from scene before the
> mouse release event handler was getting invoked.
>
> Added listener for `sceneProperty` so that when Spinner is removed from the
> scene, `stopSpinning` method
On Tue, 20 Dec 2022 10:28:44 GMT, Ajit Ghaisas wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> Fix looks good to me!
@aghaisas could you please sponsor this PR?
-
PR: https
On Mon, 19 Dec 2022 07:20:11 GMT, Karthik P K wrote:
>> Spinner was not stopping because it was getting removed from scene before
>> the mouse release event handler was getting invoked.
>>
>> Added listener for `sceneProperty` so that when Spinner is removed from the
>> scene, `stopSpinning` m
Updating boot JDK to 19.0.1.
Gradle 7.3 is not compatible with JDK 19.0.1 hence updated the gradle minimum
version as well.
-
Commit messages:
- boot jdk 19.0.1
Changes: https://git.openjdk.org/jfx/pull/979/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=979&range=00
Issu
23 matches
Mail list logo
