On Thu, 23 Feb 2023 07:36:43 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update `textTranslateX
> When Text width was more than TextField width, the logic to update
> `textTranslateX` in `updateCaretOff` method was causing the issue of
> unexpected behavior for Right and Center alignment.
>
> Made changes to update `textTranslateX` in `updateCaretOff` method only when
> text width is less
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote:
>> Issue: current update is breaking the rendering of media controls on youtube
>> video playback
>>For the Webkit Gtk platform, the layout class name is returned as
>> AdwaitaLayoutTraits
>>which is incompatible with
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote:
>> Issue: current update is breaking the rendering of media controls on youtube
>> video playback
>>For the Webkit Gtk platform, the layout class name is returned as
>> AdwaitaLayoutTraits
>>which is incompatible with
On Wed, 22 Feb 2023 17:35:08 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java
>> line 108:
>>
>>> 106: private void showChoiceBox() throws Exception {
>>> 107: mouseClick(choiceBox.getLayoutX() + choiceBox.get
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
> offset was carried forward when the list is replaced with small number of
> items. Hence the scroll up arrow was displayed with empty popup.
>
> Changed code to scroll to top before popup display when content height
On Wed, 22 Feb 2023 10:56:01 GMT, Thiago Milczarek Sayao
wrote:
>> Are you sure this PR fixes this problem?
>>
>> I tested it and not only did it not fix the scroll up issue, the scroll down
>> was broken too.
>
> @Glavo I'm never sure :)
>
> It fixed for me using your example with a laptop
> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this
> scroll event type, deltas are sent to java with the value equal to zero.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix for Ubuntu 20.04
On Wed, 22 Feb 2023 15:24:57 GMT, Marius Hanl wrote:
>> Each user probably would have to configure a JDK for the project.
>
> Yes I agree. But since the minimum supported language level for OpenJFX is
> JDK-17 and this file is part of the version control, I would recommend we
> synchronize the
> This PR does:
>
> - Remove specific Idea files and let it be imported from gradle;
> - Adds checkstyle (to use with checkstyle plugin - it will let you know style
> mistakes);
> - Configures auto-format to sun style (with the changes mentioned in [Code
> Style Rules](https://wiki.openjdk.org/d
On Thu, 16 Feb 2023 15:15:11 GMT, Dean Wookey wrote:
> Each time a menu would change scenes, a new set of ListChangeListeners would
> be added to the items in the menu. The bigger problem however is that these
> list change listeners have a strong reference to the scene which is
> potentially
On Mon, 26 Dec 2022 19:08:55 GMT, JoachimSchriek wrote:
> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
> Contributor Agreement is signed but still in review.
> So please be patient with an absolute beginner as contributor ... .
> The work of this pull request was fully d
On Wed, 22 Feb 2023 15:46:47 GMT, Andy Goryachev wrote:
> are these two lines slightly misaligned?
>
The second line is aligned at 6 tabs from the start of the line. Because of
that it looks misaligned.
> perhaps we could convert this to double x = ...; double y = ...;
> mouseClick(x, y);
>
On Wed, 22 Feb 2023 15:50:25 GMT, Andy Goryachev wrote:
> I wonder if these failures are caused by JDK-8303060
It might be yes.
-
PR: https://git.openjdk.org/jfx/pull/1039
On Wed, 22 Feb 2023 11:08:14 GMT, Jose Pereda wrote:
>> This PR fixes a regression after
>> [JDK-8212102](https://bugs.openjdk.org/browse/JDK-8212102).
>>
>> When a TextField control has some previous content, and new text with only
>> invalid characters (0x7F, new line, tabs, <0x20) is set,
On Sat, 18 Feb 2023 15:55:37 GMT, JoachimSchriek wrote:
>> Can you enable GitHub actions and then do a test run (either manually or by
>> pushing an empty commit)?
>
> @kevinrushforth the changes are committed. I had to run the action manually
> although I had enabled actions before. I searched
On Wed, 22 Feb 2023 11:09:24 GMT, Karthik P K wrote:
> Other than UI components not getting loaded properly, i don't see other
> reasons for this inconsistent failure. I updated the test and added small
> delays to avoid these unexpected failures.
I wonder if these failures are caused by JDK-8
On Wed, 22 Feb 2023 14:13:35 GMT, Karthik P K wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed cod
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote:
>> Issue: current update is breaking the rendering of media controls on youtube
>> video playback
>>For the Webkit Gtk platform, the layout class name is returned as
>> AdwaitaLayoutTraits
>>which is incompatible with
On Wed, 22 Feb 2023 14:03:57 GMT, JoachimSchriek wrote:
>> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
>> Contributor Agreement is signed but still in review.
>> So please be patient with an absolute beginner as contributor ... .
>> The work of this pull request was ful
On Sun, 19 Feb 2023 01:22:58 GMT, Thiago Milczarek Sayao
wrote:
>> .idea/misc.xml line 8:
>>
>>> 6:
>>> 7: >> IDEtalkID="9BC0DE4049720C1246C2D3B835C6F7C3" />
>>> 8: >> languageLevel="JDK_17" project-jdk-name="19" project-jdk-type="JavaSDK">
>>
>> I think this should be `project-jdk-name
On Mon, 6 Feb 2023 08:47:03 GMT, Ajit Ghaisas wrote:
>> JoachimSchriek has refreshed the contents of this pull request, and previous
>> commits have been removed. Incremental views are not available.
>
> In your last commit- instead of only reverting your changes to the
> file`VirtualFlow.java`
On Wed, 22 Feb 2023 11:08:39 GMT, Karthik P K wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed cod
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
> offset was carried forward when the list is replaced with small number of
> items. Hence the scroll up arrow was displayed with empty popup.
>
> Changed code to scroll to top before popup display when content height
> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
> Contributor Agreement is signed but still in review.
> So please be patient with an absolute beginner as contributor ... .
> The work of this pull request was fully done in my spare time.
>
> I first filed the bug myself in
On Wed, 22 Feb 2023 14:00:05 GMT, JoachimSchriek wrote:
>> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
>> Contributor Agreement is signed but still in review.
>> So please be patient with an absolute beginner as contributor ... .
>> The work of this pull request was ful
> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
> Contributor Agreement is signed but still in review.
> So please be patient with an absolute beginner as contributor ... .
> The work of this pull request was fully done in my spare time.
>
> I first filed the bug myself in
On Sat, 18 Feb 2023 15:32:48 GMT, JoachimSchriek wrote:
>> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
>> Contributor Agreement is signed but still in review.
>> So please be patient with an absolute beginner as contributor ... .
>> The work of this pull request was ful
On Sun, 12 Feb 2023 22:13:41 GMT, John Hendrikx wrote:
> This fix hides mnemonics when the Scene's Window loses focus.
>
> Before integration, we need to make sure this is correct behavior for Mac and
> Linux as well. It is correct for Windows.
>
> How to test:
>
> - Create a control with a m
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote:
> Split off from https://github.com/openjdk/jfx/pull/837
>
> This uses a precompiled regex pattern and cleans up the code in
> WebColorFieldSkin a bit.
This pull request has now been integrated.
Changeset: 315939f9
Author:John Hendrik
On Thu, 16 Feb 2023 15:15:11 GMT, Dean Wookey wrote:
> Each time a menu would change scenes, a new set of ListChangeListeners would
> be added to the items in the menu. The bigger problem however is that these
> list change listeners have a strong reference to the scene which is
> potentially
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote:
> Split off from https://github.com/openjdk/jfx/pull/837
>
> This uses a precompiled regex pattern and cleans up the code in
> WebColorFieldSkin a bit.
@hjohn you can integrate this when you are ready.
-
PR: https://git.openj
On Wed, 15 Feb 2023 22:24:41 GMT, John Hendrikx wrote:
>> This fix hides mnemonics when the Scene's Window loses focus.
>>
>> Before integration, we need to make sure this is correct behavior for Mac
>> and Linux as well. It is correct for Windows.
>>
>> How to test:
>>
>> - Create a control
On Sat, 18 Feb 2023 13:30:42 GMT, Marius Hanl wrote:
>> This PR adds the last missing method for dealing with nested event loops.
>> As also written in the ticket, there is currently no (public) way to find
>> out whether it is safe to start an event loop now or not.
>> Classes like `Dialog` che
On Wed, 22 Feb 2023 11:08:39 GMT, Karthik P K wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed cod
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote:
>> Issue: current update is breaking the rendering of media controls on youtube
>> video playback
>>For the Webkit Gtk platform, the layout class name is returned as
>> AdwaitaLayoutTraits
>>which is incompatible with
> Issue: current update is breaking the rendering of media controls on youtube
> video playback
>For the Webkit Gtk platform, the layout class name is returned as
> AdwaitaLayoutTraits
>which is incompatible with the JAVA platform.
> Solution: Use mediaControlsAdwaitaJavaS
On Tue, 21 Feb 2023 16:50:02 GMT, Andy Goryachev wrote:
> I did notice two other issues with ChoiceBox (both present in the master as
> well as the fix, so both of them are unrelated to this PR):
>
> 1. adding ~1000 items takes a long time (1-2 seconds and a beach ball on
> Mac)
>
> 2
On Wed, 22 Feb 2023 10:56:01 GMT, Thiago Milczarek Sayao
wrote:
>> Are you sure this PR fixes this problem?
>>
>> I tested it and not only did it not fix the scroll up issue, the scroll down
>> was broken too.
>
> @Glavo I'm never sure :)
>
> It fixed for me using your example with a laptop
On Tue, 21 Feb 2023 13:27:43 GMT, Lukasz Kostyra wrote:
> On both platforms the results varied, sometimes it passed, others it failed.
> When it failed, it was assertions on
> `ChoiceBoxScrollUpOnCollectionChangeTest.java` @ line 131 or 132 (again, it
> wasn't consistently the same). I guess t
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
> offset was carried forward when the list is replaced with small number of
> items. Hence the scroll up arrow was displayed with empty popup.
>
> Changed code to scroll to top before popup display when content height
> This PR fixes a regression after
> [JDK-8212102](https://bugs.openjdk.org/browse/JDK-8212102).
>
> When a TextField control has some previous content, and new text with only
> invalid characters (0x7F, new line, tabs, <0x20) is set,
> `TextInputControl::filterInput` is used to strip them out,
On Tue, 21 Feb 2023 23:29:37 GMT, Andy Goryachev wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add curly braces
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TextInputControl.java
> line 185:
>
On Wed, 22 Feb 2023 05:31:29 GMT, Glavo wrote:
>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore
>> this scroll event type, deltas are sent to java with the value equal to zero.
>
> Are you sure this PR fixes this problem?
>
> I tested it and not only did it not fix t
44 matches
Mail list logo
