Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v3]

2023-02-28 Thread Johan Vos
On Sun, 19 Feb 2023 22:17:04 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java >> line 62: >> >>> 60: >>> 61: private static final String GTK2_REMOVED_WARNING = >>> 62: "WARNING: The JavaFX GTK 2 library was remove

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v8]

2023-02-28 Thread Johan Vos
On Fri, 24 Feb 2023 00:24:56 GMT, Thiago Milczarek Sayao wrote: >> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Review changes I looked at the code an

Re: RFR: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly [v7]

2023-02-28 Thread Karthik P K
> When Text width was more than TextField width, the logic to update > `textTranslateX` in `updateCaretOff` method was causing the issue of > unexpected behavior for Right and Center alignment. > > Made changes to update `textTranslateX` in `updateCaretOff` method only when > text width is less

Re: RFR: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly [v6]

2023-02-28 Thread Andy Goryachev
On Fri, 24 Feb 2023 05:58:36 GMT, Karthik P K wrote: >> When Text width was more than TextField width, the logic to update >> `textTranslateX` in `updateCaretOff` method was causing the issue of >> unexpected behavior for Right and Center alignment. >> >> Made changes to update `textTranslateX

Re: RFR: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly [v7]

2023-02-28 Thread Karthik P K
On Tue, 28 Feb 2023 13:30:57 GMT, Karthik P K wrote: >> When Text width was more than TextField width, the logic to update >> `textTranslateX` in `updateCaretOff` method was causing the issue of >> unexpected behavior for Right and Center alignment. >> >> Made changes to update `textTranslateX

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v7]

2023-02-28 Thread Jay Bhaskar
> Issue: default html5 video element not showing media controls > Details: Media control design has been refactored in the current Webkit Gtk > port. The CSS id > and properties related to media buttons, and slider have been > removed, due to which the > media st

Withdrawn: 8300954 : HTML default Range input control not rendered

2023-02-28 Thread Hima Bindu Meda
On Mon, 27 Feb 2023 18:56:35 GMT, Hima Bindu Meda wrote: > With this fix, default slider of input type: Range is rendered properly. > Verified build and unit tests.DRT tests related to "Range", also pass with > this fix. This pull request has been closed without being integrated. -

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v7]

2023-02-28 Thread Kevin Rushforth
On Tue, 28 Feb 2023 14:41:59 GMT, Jay Bhaskar wrote: >> Issue: default html5 video element not showing media controls >> Details: Media control design has been refactored in the current Webkit Gtk >> port. The CSS id >> and properties related to media buttons, and slider have >

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v7]

2023-02-28 Thread Jay Bhaskar
On Tue, 28 Feb 2023 14:41:59 GMT, Jay Bhaskar wrote: >> Issue: default html5 video element not showing media controls >> Details: Media control design has been refactored in the current Webkit Gtk >> port. The CSS id >> and properties related to media buttons, and slider have >

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v8]

2023-02-28 Thread Kevin Rushforth
On Tue, 28 Feb 2023 08:18:20 GMT, Johan Vos wrote: > I added a comment about the warning message being printed in case 1. I think that's a great suggestion. I'll re-review once the change is made to the warning message. - PR: https://git.openjdk.org/jfx/pull/999

Integrated: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-28 Thread Kevin Rushforth
On Wed, 15 Feb 2023 12:57:22 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

[jfx20] Integrated: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-28 Thread Kevin Rushforth
On Wed, 15 Feb 2023 12:56:57 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: RFR: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly [v7]

2023-02-28 Thread Andy Goryachev
On Tue, 28 Feb 2023 13:30:57 GMT, Karthik P K wrote: >> When Text width was more than TextField width, the logic to update >> `textTranslateX` in `updateCaretOff` method was causing the issue of >> unexpected behavior for Right and Center alignment. >> >> Made changes to update `textTranslateX

[jfx17u] Integrated: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-28 Thread Kevin Rushforth
On Wed, 15 Feb 2023 12:57:39 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

[jfx11u] Integrated: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-28 Thread Kevin Rushforth
On Wed, 15 Feb 2023 12:59:47 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: HEADS-UP: JBS fix versions changing on Feb 28 from "openjfxNN" to "jfxNN"

2023-02-28 Thread Kevin Rushforth
This transition is complete. Let me know if there are any questions or issues. -- Kevin On 2/27/2023 5:50 AM, Kevin Rushforth wrote: As a reminder, I plan to make this JBS version change live at https://bugs.openjdk.org/ on Tuesday, Feb 28th (tomorrow) at 16:00 UTC. -- Kevin On 2/15/2023 4

Integrated: Merge jfx20

2023-02-28 Thread Kevin Rushforth
Merge `jfx20` into `master`. I fixed the expected merge conflict in `.jcheck/conf` by keeping the version from `master`, so that the JBS fix version correctly remains at `jfx21` in the `master` branch. Since the fix for JDK-8302470 was the only fix brought forward from `jfx20`, the next effect o

Integrated: Merge jfx20

2023-02-28 Thread Kevin Rushforth
On Tue, 28 Feb 2023 23:11:33 GMT, Kevin Rushforth wrote: > Merge `jfx20` into `master`. I fixed the expected merge conflict in > `.jcheck/conf` by keeping the version from `master`, so that the JBS fix > version correctly remains at `jfx21` in the `master` branch. Since the fix > for JDK-83024