On Tue, 7 Mar 2023 00:23:48 GMT, Kevin Rushforth wrote:
> Have you run the test this on all platforms?
I have run the test in Mac and Windows multiple times. No failures found.
> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java
> line 62:
>
>>
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
> offset was carried forward when the list is replaced with small number of
> items. Hence the scroll up arrow was displayed with empty popup.
>
> Changed code to scroll to top before popup display when content height
On Fri, 3 Mar 2023 07:28:48 GMT, Karthik P K wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed
On Mon, 6 Mar 2023 21:08:05 GMT, Andy Goryachev wrote:
>> We have many tests that access VirtualFlow, so that seems ok.
>
> would it be possible to update the JBS ticket with a valid code example?
That would be very helpful.
-
PR: https://git.openjdk.org/jfx/pull/1052
On Thu, 2 Mar 2023 17:01:02 GMT, Thiago Milczarek Sayao
wrote:
>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Rollback + Change Warnings
> -
On Sat, 4 Mar 2023 17:45:05 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bug when window starts maximized and restores to wrong size
>
>
On Mon, 6 Mar 2023 21:01:11 GMT, Kevin Rushforth wrote:
>> You are right, it is public API. One can't get directly to it, but it is
>> possible to subclass the ListView and use the protected `getVirtualFlow()`
>> method.
>
> We have many tests that access VirtualFlow, so that seems ok.
would
On Mon, 6 Mar 2023 20:54:20 GMT, Andy Goryachev wrote:
>> This is the public API of VirtualFlow. I don't know whether it's possible
>> with the API of the Control - But the API of the VirtualFlow should be
>> stable too, right?
>
> You are right, it is public API. One can't get directly to
On Mon, 6 Mar 2023 16:04:02 GMT, Florian Kirmaier wrote:
> Possible fix for VirtualFlow freeze.
>
> I encountered the problem when experimenting with VirtualFlow.
>
> Guess @johanvos should take a look.
> All tests are still green, so with some luck, this doesn't break anything but
> fixes
On Mon, 6 Mar 2023 20:50:15 GMT, Florian Kirmaier wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java
>> line 2540:
>>
>>> 2538: // scroll to 50 and scroll 1 pixel
>>> 2539: vf.scrollTo(50);
>>> 2540: vf.scrollPixels(1);
>>
>>
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Mon, 6 Mar 2023 16:39:22 GMT, Andy Goryachev
On Thu, 2 Mar 2023 23:38:20 GMT, Thiago Milczarek Sayao
wrote:
> CSR: https://bugs.openjdk.org/browse/JDK-8303493
This is ready to move to "Proposed" now. I left a couple minor comments that
will need to be addressed before I formally review it and before it is
"Finalized".
-
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Mon, 27 Feb 2023 00:13:40 GMT, Thiago Milczarek
On Mon, 6 Mar 2023 16:04:02 GMT, Florian Kirmaier wrote:
> Possible fix for VirtualFlow freeze.
>
> I encountered the problem when experimenting with VirtualFlow.
>
> Guess @johanvos should take a look.
> All tests are still green, so with some luck, this doesn't break anything but
> fixes
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Mon, 6 Mar 2023 13:12:05 GMT, Karthik P K
On Mon, 6 Mar 2023 16:04:02 GMT, Florian Kirmaier wrote:
> Possible fix for VirtualFlow freeze.
>
> I encountered the problem when experimenting with VirtualFlow.
>
> Guess @johanvos should take a look.
> All tests are still green, so with some luck, this doesn't break anything but
> fixes
Possible fix for VirtualFlow freeze.
I encountered the problem when experimenting with VirtualFlow.
Guess @johanvos should take a look.
All tests are still green, so with some luck, this doesn't break anything but
fixes some known and unknown bugs.
-
Commit messages:
-
Hi Everyone,
Found a bug that can cause the VirtualFlow to no longer scroll,
So I've implemented a fix and a test for it.
https://github.com/openjdk/jfx/pull/1052
Florian Kirmaier
On Sun, 26 Feb 2023 16:47:23 GMT, Jay Bhaskar wrote:
> Issue: default html5 video element not showing media controls
> Details: Media control design has been refactored in the current Webkit Gtk
> port. The CSS id
> and properties related to media buttons, and slider have been
On Mon, 6 Mar 2023 12:55:51 GMT, Jay Bhaskar wrote:
>> Issue: default html5 video element not showing media controls
>> Details: Media control design has been refactored in the current Webkit Gtk
>> port. The CSS id
>> and properties related to media buttons, and slider have
On Mon, 6 Mar 2023 13:12:05 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update
On Mon, 6 Mar 2023 12:55:51 GMT, Jay Bhaskar wrote:
>> Issue: default html5 video element not showing media controls
>> Details: Media control design has been refactored in the current Webkit Gtk
>> port. The CSS id
>> and properties related to media buttons, and slider have
> When Text width was more than TextField width, the logic to update
> `textTranslateX` in `updateCaretOff` method was causing the issue of
> unexpected behavior for Right and Center alignment.
>
> Made changes to update `textTranslateX` in `updateCaretOff` method only when
> text width is
> Issue: default html5 video element not showing media controls
> Details: Media control design has been refactored in the current Webkit Gtk
> port. The CSS id
> and properties related to media buttons, and slider have been
> removed, due to which the
> media
> When Text width was more than TextField width, the logic to update
> `textTranslateX` in `updateCaretOff` method was causing the issue of
> unexpected behavior for Right and Center alignment.
>
> Made changes to update `textTranslateX` in `updateCaretOff` method only when
> text width is
> Issue: default html5 video element not showing media controls
> Details: Media control design has been refactored in the current Webkit Gtk
> port. The CSS id
> and properties related to media buttons, and slider have been
> removed, due to which the
> media
26 matches
Mail list logo
