On Thu, 6 Apr 2023 17:35:05 GMT, Michael Strauß wrote:
> Looks good to me.
@mstr2 Thanks, solved your review comments
-
PR Comment: https://git.openjdk.org/jfx/pull/1056#issuecomment-1499985346
> Description copied from issue:
>
> There are up to two additional invalidations performed that really should be
> avoided, causing downstream fluent bindings to be recomputed with the same
> values. This is very confusing as these should only be called when there is
> an actual change, and n
On Fri, 7 Apr 2023 06:22:05 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
> example, the following commands create a reproducible build:
>
>
> $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct)
> $ bash gradlew s
On Thu, 6 Apr 2023 20:17:15 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
On Thu, 6 Apr 2023 20:17:15 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
Add the common base component for all the new implementing native classes
Change native peer creation to use the new base component The new code will
instantiate new protocol implementation for the given role if it exists or an
old one if it does not exist
Added BUTTON role implementing class
On Thu, 6 Apr 2023 18:57:34 GMT, Kevin Rushforth wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix NPE
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTFontFile.java
> line 276:
>
>> 274:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
> glyphs from another font.
> The root of this issue
This fixes a problem with mixing Emoji and regular text in Webview.
The Prism implementation expects that Emoji will not be in the same call to
drawString as regular glyphs,
since they need very different handling.
This fix breaks up the runs webview hands to Prism.
The test program in the bug rep
On Thu, 6 Apr 2023 17:45:14 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
On Thu, 6 Apr 2023 16:49:34 GMT, Kevin Rushforth wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix ranges
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
> line 245:
>
>> 243:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
> glyphs from another font.
> The root of this issue
On Fri, 10 Mar 2023 05:19:13 GMT, John Hendrikx wrote:
> Description copied from issue:
>
> There are up to two additional invalidations performed that really should be
> avoided, causing downstream fluent bindings to be recomputed with the same
> values. This is very confusing as these shoul
On Mon, 27 Mar 2023 23:05:00 GMT, John Hendrikx wrote:
> Fix bug in CSS caching code that could reset values on unrelated nodes.
>
> The bug occurs due to a cache entry being constructed incorrectly when the
> initial node that triggered the cache entry creation has user set values. The
> calc
On Wed, 5 Apr 2023 19:07:25 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
On Wed, 5 Apr 2023 19:07:25 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
When custom skin was loaded, the listeners added in `ContextMenuContent` class
while loading the default skin were not removed. This was causing the NPE when
outdated listeners were invoked.
Updated the code to dispose listeners in the `dispose` method of
`ContextMenuSkin` so that when new skin
On Mon, 26 Dec 2022 03:03:50 GMT, Michael Strauß wrote:
> On Windows, a `Stage` that is restricted by minimum and maximum sizes can
> briefly be observed to appear with incorrect dimensions when it is first
> shown. The root cause of this bug is that the native `WinWindow._setBounds`
> method
On Thu, 6 Apr 2023 11:43:57 GMT, John Hendrikx wrote:
> There are some documentation changes in public API, is a csr needed?
Thanks for checking. Since the changes are simple clarification, I'm OK letting
this in without a CSR.
-
PR Comment: https://git.openjdk.org/jfx/pull/1041#i
On Wed, 12 Jan 2022 20:45:02 GMT, Martin Fox wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
>> key) the glass code will dynamically query the key's unshifted character to
>> determine the Java code to assign to it. This is necessary since the
>> relationsh
On Sat, 18 Feb 2023 17:59:12 GMT, Nir Lisker wrote:
> Most of the changes revolve around unifying the sorting methods for a
> collection with `Comparable` elements with sorting methods that take an
> external `Comparator` by passing `Comparator.naturalOrder()` from the former
> to the latter.
On Tue, 28 Mar 2023 15:09:29 GMT, Kevin Rushforth wrote:
> A malformed unicode string containing only half of a surrogate pair (either a
> high or low surrogate without the other half) will cause a native exception
> in the macOS `NSPasteboardItem setString:forType:` method. This uncaught
> ex
There are no current plans to implement a new image loader for the WebP
format. As with any new feature, if enough application developers would
benefit from it, and if there is someone willing to drive the feature,
then we could consider it. One caveat, though, is that it would need to
be done
24 matches
Mail list logo
