On Mon, 18 Jul 2022 12:18:49 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
I had a look and made list of every transition with their properties:
Transition
-> FadeTransition (node, duration)
-> FillTransition (shape, duration)
-> ParallelTransition (node)
-> PathTransition (node, duration)
-> PauseTransition (duration)
-> RotateTransition (node, duration)
-> ScaleTransiti
On Mon, 8 May 2023 20:18:45 GMT, Johan Vos wrote:
> Increase the security version for JavaFX 17 to 8
> Fix for JDK-8307642
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx17u/pull/131#pullrequestreview-1418515332
On Mon, 8 May 2023 19:58:16 GMT, Johan Vos wrote:
> Increase security version for JavaFX 11 to 20
> Fix for JDK-8307641
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx11u/pull/139#pullrequestreview-1418514841
On Mon, 8 May 2023 20:18:45 GMT, Johan Vos wrote:
> Increase the security version for JavaFX 17 to 8
> Fix for JDK-8307642
This pull request has now been integrated.
Changeset: c525c2a2
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/c525c2a2a0f891584f2f20b9592a17336be60
On Mon, 8 May 2023 19:58:16 GMT, Johan Vos wrote:
> Increase security version for JavaFX 11 to 20
> Fix for JDK-8307641
This pull request has now been integrated.
Changeset: 992e6e4c
Author:Johan Vos
URL:
https://git.openjdk.org/jfx11u/commit/992e6e4c9680e2d28e441d21ee21f954ba030b84
Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
Only Windows and macOS parts were affected, tests work good on both platforms.
I looked through the code and didn't find any other cases of
`Runtime.getRuntime().exec(String)` being used, so that should cover all
possibl
On Wed, 3 May 2023 21:27:29 GMT, Andy Goryachev wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> window
On Wed, 12 Apr 2023 15:13:25 GMT, Ambarish Rapte wrote:
> Issue:
> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
> The state of this CheckBox is not visible to an accessibility client
> application.
> If we analyze a simple program that contains a CheckBoxTreeItem using a
> windows app
On Fri, 12 Mar 2021 16:27:27 GMT, Martin Fox wrote:
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
> expected by more accurately mapping from a Mac key code to a Java key code
> based on the user’s active keyboard layout (the existing code assumes a US
> QWERTY layou
On Mon, 8 May 2023 19:28:54 GMT, Andy Goryachev wrote:
> I agree that the idea of explicitly clearing the cells when they are not
> needed would be a much better solution. It will, however, require non-trivial
> changes in VirtualFlow, would impact three controls (List|Tree|TableView) and
> wo
On Fri, 5 May 2023 20:00:55 GMT, John Hendrikx wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>> KeyCharacterCo
On Fri, 5 May 2023 20:25:23 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line
>> 709:
>>
>>> 707: * The default implementation bridges into the existing
>>> getKeyCodeForChar call.
>>> 708: */
>>> 709: public boolean getKeyCanG
I made a similar observation about the list of transitions.
Looking at Duration, is it normal for a property to unbind itself when it
is assigned an illegal value?
The Duration property also looks more verbose because Node uses the
SimpleObjectProperty concrete class, which is less memory efficien
On Tue, 9 May 2023 14:12:09 GMT, Lukasz Kostyra wrote:
> Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
>
> Only Windows and macOS parts were affected, tests work good on both platforms.
>
> I looked through the code and didn't find any other cases of
> `Runtime.get
On Tue, 9 May 2023 18:23:15 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/HostServicesDelegate.java
>> line 138:
>>
>>> 136: try {
>>> 137: if (osName.startsWith("Mac OS")) {
>>> 138: Runtime.getRuntime
On Tue, 9 May 2023 17:54:35 GMT, Andy Goryachev wrote:
>> Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
>>
>> Only Windows and macOS parts were affected, tests work good on both
>> platforms.
>>
>> I looked through the code and didn't find any other cases of
>> `R
On Tue, 9 May 2023 18:26:02 GMT, Andy Goryachev wrote:
>> Don't think we have an enum (maybe we should), but `PlatformUtil` already
>> takes care of identifying the OS, also using
>> `System.getProperty("os.name")`. You can use `PlatformUtil.isMac()`. If we
>> make an enum, that's where is sho
On Tue, 9 May 2023 18:30:56 GMT, Nir Lisker wrote:
>> There was a recent PR
>> https://github.com/openjdk/jdk/pull/13357
>> adding an enum deep in the jdk bowels
>>
>> we probably can't use that
>
>> There was a recent PR
>> [openjdk/jdk#13357](https://github.com/openjdk/jdk/pull/13357) adding
On Tue, 9 May 2023 05:10:25 GMT, Karthik P K wrote:
>> Since surrogate pairs are internally considered as 2 characters and text
>> field is null in `HitInfo` when `getInsertionIndex` is invoked from
>> `TextFlow`, wrong insertion index was returned.
>>
>> Updated code to calculate insertion in
On Tue, 9 May 2023 20:19:50 GMT, Kevin Rushforth wrote:
>> you are right, wrong PR, sorry
>> https://github.com/openjdk/jdk/pull/12931
>
> No, we can't use that. More to the point, it is unrelated to this PR (and
> thus out of scope).
But I do think it would be a good idea to use `PlatformUtil`
On Tue, 9 May 2023 18:37:24 GMT, Andy Goryachev wrote:
>>> There was a recent PR
>>> [openjdk/jdk#13357](https://github.com/openjdk/jdk/pull/13357) adding an
>>> enum deep in the jdk bowels
>>>
>>> we probably can't use that
>>
>> Isn't that for the architecture, not the OS?
>
> you are right
On Fri, 5 May 2023 20:04:12 GMT, John Hendrikx wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>> KeyCharacterCo
On Tue, 9 May 2023 20:22:05 GMT, Kevin Rushforth wrote:
>> No, we can't use that. More to the point, it is unrelated to this PR (and
>> thus out of scope).
>
> But I do think it would be a good idea to use `PlatformUtil` here, so maybe
> file a cleanup issue to look for places where we explicit
On Mon, 8 May 2023 18:55:38 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by using WeakInvalidationListener
>> (which is the right approach in this particular situation) - the leak is
>> specific to TreeTableRowSkin.
>>
>> Added a unit test.
>>
>> Added Refresh buttons an
On Tue, 9 May 2023 14:12:09 GMT, Lukasz Kostyra wrote:
> Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
>
> Only Windows and macOS parts were affected, tests work good on both platforms.
>
> I looked through the code and didn't find any other cases of
> `Runtime.get
On Tue, 9 May 2023 15:37:39 GMT, Kevin Rushforth wrote:
> For the purposes of fixing the regression bug, I would like to proceed with
> this fix as is.
I think that's fine, but I do think you should remove the changes that don't
contribute to the fix (I'm pretty sure the weak listeners in the
27 matches
Mail list logo
