Re: RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v6]

2023-05-30 Thread Ambarish Rapte
On Sat, 15 Apr 2023 23:32:40 GMT, Thiago Milczarek Sayao wrote: >> This PR does: >> >> - Remove specific Idea files and let it be imported from gradle; >> - Adds checkstyle (to use with checkstyle plugin - it will let you know >> style mistakes); >> - Configures auto-format to sun style (with

Re: RFR: 8308191: [macOS] VoiceOver decorations are shifted on second monitor

2023-05-30 Thread Alexander Zuev
On Tue, 30 May 2023 23:11:06 GMT, Andy Goryachev wrote: > Noticed two intermittent issues when moving the same javafx window between > the monitors: > > 1. at some point, the window turned completely black. moving it on another > monitor fixed the issue: That might be because when moving bet

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows [v2]

2023-05-30 Thread Andy Goryachev
On Tue, 30 May 2023 10:39:28 GMT, Johan Vos wrote: >> Only update the VirtualFlow parameters in case the size of a cell has >> changed. >> >> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional >> recalculation in case the size of a cell is set. This recalculation is only >>

Re: RFR: 8308191: [macOS] VoiceOver decorations are shifted on second monitor

2023-05-30 Thread Andy Goryachev
On Tue, 30 May 2023 21:17:08 GMT, Alexander Zuev wrote: > The coordinate system of the Mac OS X is reversed to the JavaFX coordinate > system meaning that zero point [0,0] is the bottom left corner of the main > screen and positive Y coordinate means elevation of the point above the zero > lin

Re: RFR: 8308191: [macOS] VoiceOver decorations are shifted on second monitor

2023-05-30 Thread Andy Goryachev
On Tue, 30 May 2023 21:44:27 GMT, Kevin Rushforth wrote: > Can you also review? as an originator of this bug report, most certainly will. - PR Comment: https://git.openjdk.org/jfx/pull/1147#issuecomment-1569150216

Re: RFR: 8308191: [macOS] VoiceOver decorations are shifted on second monitor

2023-05-30 Thread Kevin Rushforth
On Tue, 30 May 2023 21:17:08 GMT, Alexander Zuev wrote: > The coordinate system of the Mac OS X is reversed to the JavaFX coordinate > system meaning that zero point [0,0] is the bottom left corner of the main > screen and positive Y coordinate means elevation of the point above the zero > lin

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-30 Thread Kevin Rushforth
On Fri, 26 May 2023 11:13:31 GMT, Joeri Sykora wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see [JDK-8303

RFR: 8308191: [macOS] VoiceOver decorations are shifted on second monitor

2023-05-30 Thread Alexander Zuev
The coordinate system of the Mac OS X is reversed to the JavaFX coordinate system meaning that zero point [0,0] is the bottom left corner of the main screen and positive Y coordinate means elevation of the point above the zero line. Taking that into account we should use the main screen's height

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows [v2]

2023-05-30 Thread Kevin Rushforth
> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). The > sol

Integrated: 8308307: Update to gcc 12.2.0 on Linux

2023-05-30 Thread Kevin Rushforth
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote: > Update the compiler on Linux to gcc 12.2. This provides the needed C++20 > support for the next WebKit update. This pull request has now been integrated. Changeset: 5bbb95b1 Author:Kevin Rushforth URL: https://git.openjdk.o

Integrated: 8308306: Update to Xcode 14.3 on macOS

2023-05-30 Thread Kevin Rushforth
On Sat, 20 May 2023 14:47:50 GMT, Kevin Rushforth wrote: > Update the compiler on macOS to Xcode 14.3. In addition to providing the > needed C++20 support for the next WebKit update, initial testing by the JDK > team shows that this fixes a reproducible builds problem, so it might help > addre

Re: RFR: 8309001: Add Linux/riscv64 support to WebKit

2023-05-30 Thread Kevin Rushforth
On Tue, 30 May 2023 17:39:57 GMT, Eric Long wrote: > RISC-V is a new free and open-source ISA that is being widely adopted in the > recent years. Currently WebKit is ready for riscv64, and only minor changes > is needed to support the platform. Can you enable GitHub Actions for your personal f

RFR: 8309001: Add Linux/riscv64 support to WebKit

2023-05-30 Thread Eric Long
RISC-V is a new free and open-source ISA that is being widely adopted in the recent years. Currently WebKit is ready for riscv64, and only minor changes is needed to support the platform. - Commit messages: - 8309001: Add Linux/riscv64 support Changes: https://git.openjdk.org/jfx/

Integrated: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop

2023-05-30 Thread Lukasz Kostyra
On Wed, 12 Apr 2023 16:50:38 GMT, Lukasz Kostyra wrote: > Crashes started happening due to macOS DnD API change from macOS 10.14 > onwards. 10.14 incrodues some [DnD > constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop) >

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [v7]

2023-05-30 Thread Ambarish Rapte
On Tue, 30 May 2023 08:57:40 GMT, Lukasz Kostyra wrote: >> Crashes started happening due to macOS DnD API change from macOS 10.14 >> onwards. 10.14 incrodues some [DnD >> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop

Re: RFR: 8299756: Minor updates in CSS Reference [v2]

2023-05-30 Thread Andy Goryachev
On Sat, 27 May 2023 13:19:02 GMT, Marius Hanl wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line > 367: > >> 365:

Re: RFR: 8299756: Minor updates in CSS Reference [v2]

2023-05-30 Thread Andy Goryachev
> Minor fixes and addition of missing sections: > > - The 'system' font is missing from the list of generic font family names in > the section. ✓ > - Explicitly add text color property -fx-fill to Text section, so as not to > confuse with Labeled -fx-text-fill ✓ > - TextFlow section is missing,

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [v7]

2023-05-30 Thread Kevin Rushforth
On Tue, 30 May 2023 08:57:40 GMT, Lukasz Kostyra wrote: >> Crashes started happening due to macOS DnD API change from macOS 10.14 >> onwards. 10.14 incrodues some [DnD >> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-30 Thread Kevin Rushforth
On Fri, 26 May 2023 11:13:31 GMT, Joeri Sykora wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see [JDK-8303

Re: RFR: 8308307: Update to gcc 12.2.0 on Linux

2023-05-30 Thread Joeri Sykora
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote: > Update the compiler on Linux to gcc 12.2. This provides the needed C++20 > support for the next WebKit update. Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1141#pullrequestreview-145

Re: RFR: 8308306: Update to Xcode 14.3 on macOS [v2]

2023-05-30 Thread Joeri Sykora
On Thu, 25 May 2023 16:30:38 GMT, Kevin Rushforth wrote: >> Update the compiler on macOS to Xcode 14.3. In addition to providing the >> needed C++20 support for the next WebKit update, initial testing by the JDK >> team shows that this fixes a reproducible builds problem, so it might help >> a

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows [v2]

2023-05-30 Thread Andy Goryachev
On Tue, 30 May 2023 10:39:28 GMT, Johan Vos wrote: >> Only update the VirtualFlow parameters in case the size of a cell has >> changed. >> >> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional >> recalculation in case the size of a cell is set. This recalculation is only >>

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows [v2]

2023-05-30 Thread Karthik P K
On Tue, 30 May 2023 10:39:28 GMT, Johan Vos wrote: >> Only update the VirtualFlow parameters in case the size of a cell has >> changed. >> >> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional >> recalculation in case the size of a cell is set. This recalculation is only >>

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows [v2]

2023-05-30 Thread Johan Vos
On Fri, 26 May 2023 20:21:15 GMT, Andy Goryachev wrote: > I've tested this change on Windows 11 at 225% scale (just in case). TableView > performance is much better (I think there is still a bit of difference > between looking at the top of the table vs. the bottom, but it's hardly > noticeabl

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows [v2]

2023-05-30 Thread Johan Vos
> Only update the VirtualFlow parameters in case the size of a cell has changed. > > The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional > recalculation in case the size of a cell is set. This recalculation is only > needed in case the size of that specific cell has changed. >

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [v7]

2023-05-30 Thread Lukasz Kostyra
> Crashes started happening due to macOS DnD API change from macOS 10.14 > onwards. 10.14 incrodues some [DnD > constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop) > which our DnD code happened to trigger on some occasions

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [v6]

2023-05-30 Thread Ambarish Rapte
On Wed, 24 May 2023 15:32:11 GMT, Lukasz Kostyra wrote: >> Crashes started happening due to macOS DnD API change from macOS 10.14 >> onwards. 10.14 incrodues some [DnD >> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop