On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Thu, 27 Apr 2023 10:11:42 GMT, John Hendrikx wrote:
> Region has floor and ceiling functions that ensure that calling them twice in
> a row will yield the same result:
>
> ceil(x) = ceil(ceil(x))
>
> However, due to use of a constant `EPSILON` which is added/subtracted before
> doing
On Wed, 31 May 2023 20:03:04 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove seed
>> - Add test cases for negative values
>> - Add copyright headers
>
> modules/javafx.graphics/src
On Mon, 27 Mar 2023 13:50:40 GMT, John Hendrikx wrote:
> The class `PseudoClassState` is private API, but was exposed erroneously in
> the CSS API. Instead, `Set` should have been used. This PR
> corrects this.
This pull request has now been integrated.
Changeset: 3fa02ee9
Author:John Hen
On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse with Labeled -fx-text-fill ✓
> - TextFlow section is missing,
On Wed, 31 May 2023 22:57:36 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 3155:
>
>> 3
On Tue, 30 May 2023 15:50:17 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Mon, 15 May 2023 15:09:27 GMT, Martin Fox wrote:
> In macOS 10.12 Apple renamed a bunch of constants to match the Swift
> enumeration style. JavaFX is still using the old deprecated constants which
> generates over 50 warnings during the build. JavaFX 18 upped the minimum
> macOS version to
On Mon, 15 May 2023 15:09:27 GMT, Martin Fox wrote:
> In macOS 10.12 Apple renamed a bunch of constants to match the Swift
> enumeration style. JavaFX is still using the old deprecated constants which
> generates over 50 warnings during the build. JavaFX 18 upped the minimum
> macOS version to
> - Added missing exception checks for JNI calls.
> - Improved JNI error checking by checking for both exception and return
> value.
> - Minor code clean up.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8304290: Some JNI ca
On Tue, 18 Apr 2023 02:08:03 GMT, Alexander Matveev
wrote:
> - Added missing exception checks for JNI calls.
> - Improved JNI error checking by checking for both exception and return
> value.
> - Minor code clean up.
8304290: Some JNI calls made without checking exceptions in media [v2]
- F
On Tue, 9 May 2023 09:05:57 GMT, Ambarish Rapte wrote:
>> - Added missing exception checks for JNI calls.
>> - Improved JNI error checking by checking for both exception and return
>> value.
>> - Minor code clean up.
>
> modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 66
On Sat, 20 May 2023 00:57:08 GMT, John Hendrikx wrote:
>> I took a closer look at the compatibility issues Joe raised in the CSR, and
>> I can confirm that yes, this change will break binary compatibility for any
>> application that calls the existing method. It would also can break source
>>
On Wed, 31 May 2023 20:48:05 GMT, Alexander Zuev wrote:
>> Add the common base component for all the new implementing native classes
>> Change native peer creation to use the new base component The new code will
>> instantiate new protocol implementation for the given role if it exists or
>>
On Mon, 22 May 2023 22:43:32 GMT, Kevin Rushforth wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Properly use NSObject instead of the GlassAccessible type.
>
> modules/javafx.graphics/src/main/native-glass/mac/a
> Add the common base component for all the new implementing native classes
> Change native peer creation to use the new base component The new code will
> instantiate new protocol implementation for the given role if it exists or
> an old one if it does not exist
> Added BUTTON role implementi
On Tue, 30 May 2023 21:17:08 GMT, Alexander Zuev wrote:
> The coordinate system of the Mac OS X is reversed to the JavaFX coordinate
> system meaning that zero point [0,0] is the bottom left corner of the main
> screen and positive Y coordinate means elevation of the point above the zero
> lin
> Add the common base component for all the new implementing native classes
> Change native peer creation to use the new base component The new code will
> instantiate new protocol implementation for the given role if it exists or
> an old one if it does not exist
> Added BUTTON role implementi
On Tue, 30 May 2023 21:17:08 GMT, Alexander Zuev wrote:
> The coordinate system of the Mac OS X is reversed to the JavaFX coordinate
> system meaning that zero point [0,0] is the bottom left corner of the main
> screen and positive Y coordinate means elevation of the point above the zero
> lin
On Fri, 5 May 2023 08:08:30 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
>>
On Tue, 30 May 2023 21:17:08 GMT, Alexander Zuev wrote:
> The coordinate system of the Mac OS X is reversed to the JavaFX coordinate
> system meaning that zero point [0,0] is the bottom left corner of the main
> screen and positive Y coordinate means elevation of the point above the zero
> lin
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao
wrote:
> This PR does:
>
> - Remove specific Idea files and let it be imported from gradle;
> - Adds checkstyle (to use with checkstyle plugin - it will let you know style
> mistakes);
> - Configures auto-format to sun style (with the ch
On Tue, 30 May 2023 15:50:17 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
24 matches
Mail list logo
