On Fri, 2 Jun 2023 19:41:04 GMT, Andy Goryachev wrote:
>> No, it wasn't due to null text. That is provably impossible.
>>
>> The exception from JDK-8302511 is as follows (copied from the bug report).
>>
>> Exception in thread "JavaFX Application Thread"
>> java.lang.IllegalArgumentException: o
On Fri, 2 Jun 2023 19:18:13 GMT, Phil Race wrote:
>> The exception in 8302511 was likely caused by a prior exception due to null
>> text, which corrupted insertionIndex value in HitInfo.
>>
>> The goal of this change is to always compute insertionIndex (an I believe we
>> do it correctly this
All,
If you have fixes that you need to get into jfx20u for JavaFX 20.0.2,
please do so by Monday, June 12th. Note that approval from one of the
project leads is needed as outlined in this message [1].
Thanks.
-- Kevin
[1] https://mail.openjdk.org/pipermail/openjfx-dev/2023-March/039371.htm
On Fri, 2 Jun 2023 18:50:07 GMT, Andy Goryachev wrote:
>> I did note that TextFlow passed null which really looked like a WIP to me
>> but its a separate issue.
>> The exception in 8302511 which is the entire subject of that bug isn't
>> possible if text == null.
>> My point is that if you pass
On Fri, 2 Jun 2023 18:37:19 GMT, Phil Race wrote:
>>> Assuming line 473 is the one still there today, it looks to me as if that
>>> would be reached if you had the caret on an empty line that isn't the last
>>> line.
>>
>> In this case also code hits the condition in 451 as the text run is not
On Thu, 27 Apr 2023 11:39:24 GMT, Nir Lisker wrote:
>> Adds the javadoc commands to generate the NEW page and to be able to select
>> versions in the DEPRECATED page.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Auto-dete
On Fri, 2 Jun 2023 07:19:01 GMT, Karthik P K wrote:
>> The main issue is that insertion index was not computed in the
>> PrismTextLayout, supposedly to allow for delaying the computation until it's
>> needed (if needed at all). A good intention, but the execution had two
>> issues:
>> 1. HitI
On Fri, 21 Apr 2023 13:30:38 GMT, Nir Lisker wrote:
> 1. The `-since` option does not play well with the javafx one: if
> documentation was added on a `private` property field with the `@since` tag,
> it will not be included in the NEW and DEPRECATED lists. I presume that the
> `-since` releas
On Wed, 26 Apr 2023 04:17:23 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Fri, 2 Jun 2023 15:56:23 GMT, Eric Long wrote:
>> RISC-V is a new free and open-source ISA that is being widely adopted in the
>> recent years. Currently WebKit is ready for riscv64, and only minor changes
>> is needed to support the platform.
>
> Eric Long has updated the pull request with
On Fri, 2 Jun 2023 15:53:00 GMT, Eric Long wrote:
> Sorry I messed up a bit and force pushed, but the workflow should be
> triggered.
The GHA run was triggered, thanks.
-
PR Comment: https://git.openjdk.org/jfx/pull/1146#issuecomment-1574002389
> RISC-V is a new free and open-source ISA that is being widely adopted in the
> recent years. Currently WebKit is ready for riscv64, and only minor changes
> is needed to support the platform.
Eric Long has updated the pull request with a new target base due to a merge or
a rebase. The pull re
On Tue, 30 May 2023 17:39:57 GMT, Eric Long wrote:
> RISC-V is a new free and open-source ISA that is being widely adopted in the
> recent years. Currently WebKit is ready for riscv64, and only minor changes
> is needed to support the platform.
Sorry I messed up a bit and force pushed, but the
On Tue, 30 May 2023 17:39:57 GMT, Eric Long wrote:
> RISC-V is a new free and open-source ISA that is being widely adopted in the
> recent years. Currently WebKit is ready for riscv64, and only minor changes
> is needed to support the platform.
Can you trigger a GHA run? Since it wasn't enable
On Tue, 30 May 2023 18:29:53 GMT, Kevin Rushforth wrote:
> Can you enable GitHub Actions for your personal fork to help verify that this
> doesn't impact builds on our core platforms?
Sure, enabled.
-
PR Comment: https://git.openjdk.org/jfx/pull/1146#issuecomment-1573943898
On Fri, 2 Jun 2023 13:30:38 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 3083:
>>
>>> 3081: if (itemSizeCache.size() > cellIndex) {
>>> 3082: Double oldSize = itemSizeCache.get(cellIndex);
>>> 3083:
On Thu, 1 Jun 2023 20:30:06 GMT, Marius Hanl wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 3083:
>
>> 3081
On Wed, 19 Apr 2023 12:14:45 GMT, Johan Vos wrote:
> Only update the VirtualFlow parameters in case the size of a cell has changed.
>
> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional
> recalculation in case the size of a cell is set. This recalculation is only
> needed i
I haven't seen anything exactly like this, but it might be related to a
system setting or a terminal setting (if the app is launched from a
terminal) on the affected systems. You might check is whether the
"Secure Keyboard Entry" setting in the Terminal is enabled on the
affected macOS systems.
On Wed, 19 Apr 2023 13:13:45 GMT, Johan Vos wrote:
> Calculate position of first visible element before propagating changes.
> Make sure to restore the position of said element after the changes are done.
>
> Fix JDK-8306447
This pull request has now been integrated.
Changeset: 1a0f6c7f
Author
On Sat, 29 Apr 2023 20:05:52 GMT, Johan Vos wrote:
>> Calculate position of first visible element before propagating changes.
>> Make sure to restore the position of said element after the changes are done.
>>
>> Fix JDK-8306447
>
> Johan Vos has updated the pull request incrementally with one a
On Tue, 30 May 2023 10:39:28 GMT, Johan Vos wrote:
>> Only update the VirtualFlow parameters in case the size of a cell has
>> changed.
>>
>> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional
>> recalculation in case the size of a cell is set. This recalculation is only
>>
On Thu, 1 Jun 2023 20:26:33 GMT, Marius Hanl wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 3085:
>
>> 3083
On Thu, 1 Jun 2023 22:54:06 GMT, Andy Goryachev wrote:
>> Regarding
>> "If we can initialize insertionIndex to a positive value, then the buggy
>> code in HitInfo.getInsertionIndex()
>> will never get executed, and we can remove it later (in JDK-8302511)."
>>
>> it seems to me that this new cod
24 matches
Mail list logo
