Withdrawn: 8305768: Unify WindowContext in glass-gtk

2023-06-10 Thread duke
On Sat, 8 Apr 2023 00:53:12 GMT, Thiago Milczarek Sayao wrote: > This unifies and organizes WindowContext of the glass-gtk. > > It does not change any behaviour, just reorganizes the code. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/j

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v18]

2023-06-10 Thread Thiago Milczarek Sayao
On Tue, 6 Jun 2023 14:03:35 GMT, Kevin Rushforth wrote: >>> I ran an automated test job using your latest patch and all of the tests >>> now pass. >>> >>> > Maybe it's possible to do a Java fix where the new Scene without size >>> > inherits the old Scene size? This way I think it possible to

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v20]

2023-06-10 Thread Thiago Milczarek Sayao
On Tue, 6 Jun 2023 01:09:36 GMT, Thiago Milczarek Sayao wrote: >> I replicated the fix on #1054 on Linux. >> >> Also fixes [Monocle: Stage no longer gets focus after fix for >> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) > > Thiago Milczarek Sayao has updated the pull request inc

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v8]

2023-06-10 Thread Kevin Rushforth
On Sat, 10 Jun 2023 00:20:43 GMT, John Hendrikx wrote: > It's not really a memory leak, the amount of memory that it can take can just > be quite large in the right circumstances. In that case, I edited the title of the JBS bug to remove the `Memory leak and` part (I also remove the `(hbox)` s

Re: RFR: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions [v2]

2023-06-10 Thread Kevin Rushforth
On Thu, 27 Apr 2023 11:39:24 GMT, Nir Lisker wrote: >> Adds the javadoc commands to generate the NEW page and to be able to select >> versions in the DEPRECATED page. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Auto-dete

Re: [External] : Text Surrounding

2023-06-10 Thread Thiago Milczarek SayĆ£o
Andy, Looking at Gtk code on: https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextview.c -> gtk_text_view_retrieve_surrounding_handler It seems to concat 3 words backwards + selection + 3 words forward (there are more complicated cases). I was looking around on JavaFX code and it does not

Re: RFR: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions [v2]

2023-06-10 Thread Kevin Rushforth
On Thu, 8 Jun 2023 21:53:35 GMT, Marius Hanl wrote: > > I am somewhat divided on which version to start with. On one hand, it makes > > sense to use last LTS version (or previous, if the current one is also > > LTS), so 17. > > I think we should either start from 9 or 11. Depending on the sour