Thanks for filing this bug.
Regards,
Ajit
On 13-Jul-2023, at 6:14 AM, John Hendrikx wrote:
I've managed to reproduce it -- it seems it may be a regression, or it is
exposing a new bug after a fix done to the scrollbar (in 19.0.2.1 I can't
reproduce it, but I also can't fully click the scroll
On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev wrote:
> To avoid confusion on the os x dynamic linker side i renamed native classes
> from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix
> down the line to avoid any confusion when running with the latest JDK that
> also
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Thu, 13 Jul 2023 03:22:43 GMT, Kevin Rushforth wrote:
> I might recommend filing a follow-up issue to improve the docs, since that
> can be done after RDP1.
I'm fine with that, I can create one and then work through @nlisker comments.
I plan to integrate this in a couple of hours, just befo
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Tue, 11 Jul 2023 23:19:21 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Tue, 13 Jun 2023 14:39:57 GMT, John Neffenger wrote:
>> Please review these changes to the Gradle build files and the dependency
>> verification file. The initial version of this pull request extends the
>> permitted build platforms for Linux to the Java architectures `arm`,
>> `ppc64le`, a
I've managed to reproduce it -- it seems it may be a regression, or it
is exposing a new bug after a fix done to the scrollbar (in 19.0.2.1 I
can't reproduce it, but I also can't fully click the scrollbar back
up). In 21-ea-24 I can reproduce it by scrolling all the way down, then
trying to "c
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Wed, 12 Jul 2023 22:33:44 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix subscriber -> valueSubscriber
>
> modules/javafx.base/src/test/java/test/javafx/beans/ObservableSubscriptionsTe
> Makes `Subscription` public (removing some of its methods that are
> unnecessary), and adds methods that can provide `Subscription`s in
> `ObservableValue`.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix ObservableSubscripti
On Tue, 11 Jul 2023 23:19:21 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Mon, 10 Jul 2023 16:41:47 GMT, Andy Goryachev wrote:
>> At this point I don't have a strong opinion on whether this field is private
>> or not. Originally I wanted it to be private because I thought of it as
>> "whatever magic value makes KeyCharacterCombinations work" and was concerned
>>
I have a video clip of how to reproduce the exception. Do you mind creating a
bug?
Thank you
-andy
From: John Hendrikx
Date: Wednesday, July 12, 2023 at 09:33
To: Andy Goryachev , Ajit Ghaisas
Cc: openjfx-dev@openjdk.org
Subject: Re: [External] : Re: ListView with ImageViews for cells very
This is okay for me in Eclipse, although it will show the docs for the
anonymous inner class updateItem method, which is not that helpful :)
--John
On 12/07/2023 17:13, Andy Goryachev wrote:
I think we just found a bug in Eclipse: it shows javadoc for the wrong
method -
I'm unable to get this one myself, but the trace can hopefully point us
to the problem.
I also find that the behavior of the Horizontal scrollbar leaves a lot
to be desired. Clicking in the empty area should shift it by a full
view width, but it only shifts by like 16 pixels orso.
So there
On Tue, 11 Jul 2023 23:19:21 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
... and just by randomly clicking on the scrollbar I got this:
Exception in thread "JavaFX Application Thread"
java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 2
at
java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100)
at
java.base/jdk.i
Yes, sorry, it does mention that, and I missed it by mistake, late night
programming I guess.
--John
On 12/07/2023 16:57, Kevin Rushforth wrote:
The updateItem docs [1] already say this. I had missed that the test
program didn't do this, so thanks to Ajit for pointing it out.
And yes, https:
Hi Ajit,
Thanks for checking, that is indeed a bit of a beginner mistake there...
sorry for that.
I added the line, and it is much improved (luckily), but I still see
issues 2 and 3.
I can narrow down 2 a bit. When there is only space to show a single
row (or less than a single line), the
On Tue, 11 Jul 2023 20:12:44 GMT, Kevin Rushforth wrote:
> Is there a way to hide the symbols so that they are not exported?
I do not think we can hide these symbols from the library - they have to be
public for us to instantiate them dynamically based on the accessibility role
of the FX node.
On Wed, 12 Jul 2023 13:24:16 GMT, Ambarish Rapte wrote:
> Updating last modified year in copyright header of the files that were
> modified during year 2023.
This pull request has now been integrated.
Changeset: 411c1b11
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit
The updateItem docs [1] already say this. I had missed that the test
program didn't do this, so thanks to Ajit for pointing it out.
And yes, https://bugs.openjdk.org/browse/JDK-8090254 should be closed as
not an issue with a reference to the doc bug that clarified this.
-- Kevin
[1]
https:/
Ajit is right - perhaps javadoc for updateItem() should explicitly mention this?
Also, perhaps https://bugs.openjdk.org/browse/JDK-8090254 should be closed - we
recently updated javadoc to read
Warning: Nodes should not be inserted directly into the items list
(this is a different issue altogeth
On Wed, 12 Jul 2023 13:24:16 GMT, Ambarish Rapte wrote:
> Updating last modified year in copyright header of the files that were
> modified during year 2023.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1176#pullrequestreview-1526415
Updating last modified year in copyright header of the files that were modified
during year 2023.
-
Commit messages:
- 8310582: Update copyright header for files modified in 2023
Changes: https://git.openjdk.org/jfx/pull/1176/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=
Hi John,
This looks like a user code issue and not a JavaFX bug.
Most of the vertical scrollbar issues that you have mentioned get fixed by
adding a call to "super.updateItem(image, empty);" as a first call in the cell
factory method "protected void updateItem(Image image, boolean empty)”
29 matches
Mail list logo
