On Wed, 9 Aug 2023 05:13:36 GMT, Jayathirth D V wrote:
> This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u.
>
> We should not use stack memory for large VLA allocations in pango.c
@kevinrushforth and @arapte please review.
-
PR Comment:
This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u.
We should not use stack memory for large VLA allocations in pango.c
-
Commit messages:
- Backport 1752b62320f9e42f6d0d2c1f8278cf2ab205a8f4
Changes: https://git.openjdk.org/jfx21u/pull/8/files
Webrev:
On Mon, 13 Dec 2021 19:46:27 GMT, Martin Fox wrote:
> The algorithm in `KeyCharacterCombination.match` relies on the call
> `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It
> defies the way most keyboard API’s work and no platform has got it right yet.
> In particular
On Tue, 8 Aug 2023 12:25:53 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Migrate old tests to JUnit 5
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/BorderPaneTest.java
>
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
> However, this padding needs to be taken into account as well,
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote:
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
> However,
On Tue, 8 Aug 2023 22:04:08 GMT, Alexander Matveev wrote:
> This is clean backport of JDK-8313900.
This pull request has now been integrated.
Changeset: 27b179a3
Author:Alexander Matveev
URL:
https://git.openjdk.org/jfx21u/commit/27b179a38df9eff614155e5e1b8c298910622f53
Stats:
This is clean backport of JDK-8313900.
-
Commit messages:
- Backport 9f180e20adc5bc8e6892d9672a414e8b7f614a20
Changes: https://git.openjdk.org/jfx21u/pull/7/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=7=00
Issue: https://bugs.openjdk.org/browse/JDK-8313900
Stats: 13
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote:
> - Fixed by checking for `NULL` pointer after memory allocation.
> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint`
> array, so `new` will return `NULL` instead of throwing exception. This done
> for consistency
On Tue, 8 Aug 2023 17:39:18 GMT, Jay Bhaskar wrote:
>> Issue : Enabling modern media controls on webkit 616.1 does not load button
>> images on HTML5 Video Element
>> Solution: Add resources and correct MediaControl Stylesheet
>
> Jay Bhaskar has updated the pull request incrementally with one
On Tue, 8 Aug 2023 13:25:04 GMT, Jose Pereda wrote:
> Should I port the test back to JUnit 4, then? Or convert the existing test
> class to JUnit 5?
If the changes aren't too intrusive, it would be OK to convert to JUnit 5.
Otherwise, port the test back to JUnit 4.
-
PR Comment:
On Tue, 8 Aug 2023 17:33:29 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp
>> line 28:
>>
>>> 26: #include "ModernMediaControlResource.h"
>>> 27:
>>> 28: ModernMediaControlResource::ModernMediaControlResource() {
>>
On Tue, 8 Aug 2023 16:39:30 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
>
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
more clean up
On Tue, 8 Aug 2023 16:09:58 GMT, Jay Bhaskar wrote:
>> Issue : Enabling modern media controls on webkit 616.1 does not load button
>> images on HTML5 Video Element
>> Solution: Add resources and correct MediaControl Stylesheet
>
> Jay Bhaskar has updated the pull request incrementally with one
On Tue, 8 Aug 2023 16:04:58 GMT, Jay Bhaskar wrote:
>> tests/manual/web/HTML5VideoControlTest.java line 48:
>>
>>> 46:
>>> 47: HBox content = new HBox();
>>> 48: content.getChildren().addAll(createInstructionsBox(), webView);
>>> // Swap the order here
>>
>> Is the comment
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote:
> - Fixed by checking for `NULL` pointer after memory allocation.
> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint`
> array, so `new` will return `NULL` instead of throwing exception. This done
> for consistency
On Tue, 8 Aug 2023 11:41:11 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
>
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
clean up
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
>
On Fri, 4 Aug 2023 22:12:55 GMT, Marius Hanl wrote:
> The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for
> the sake of testing.
> It is only changed by some JUnit tests to remove the need of setting up the
> whole table framework.
> This PR shifts this flag from those
On Sun, 6 Aug 2023 11:46:32 GMT, Jay Bhaskar wrote:
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
I tested this on Windows and confirm that the media controls are
On Fri, 30 Jun 2023 14:40:14 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote:
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
> However,
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote:
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
> However,
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote:
> We should not use stack for array memory allocations in JNI.
> Updated pango.c to use malloc for arrays and release them at appropriate
> places.
This pull request has now been integrated.
Changeset: 1752b623
Author:Jayathirth D V
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote:
> - Fixed by checking for `NULL` pointer after memory allocation.
> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint`
> array, so `new` will return `NULL` instead of throwing exception. This done
> for consistency
On Fri, 4 Aug 2023 22:12:55 GMT, Marius Hanl wrote:
> The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for
> the sake of testing.
> It is only changed by some JUnit tests to remove the need of setting up the
> whole table framework.
> This PR shifts this flag from those
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote:
> - Fixed by checking for `NULL` pointer after memory allocation.
> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint`
> array, so `new` will return `NULL` instead of throwing exception. This done
> for consistency
On Mon, 7 Aug 2023 15:18:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line
>> 85:
>>
>>> 83: }
>>> 84:
>>> 85: @Test
>>
>> Minor - I think it would be best to keep old code untouched to not mix up
>> the file history in
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Guillaume Tâche has updated the pull request incrementally with one
32 matches
Mail list logo
