> So far, BorderPane does the calculation for the children min/pref > width/height taken into account only the margin applied to them, if any, but > not the total padding that could be applied as well to the BorderPane itself. > > However, this padding needs to be taken into account as well, and this PR > modifies BorderPane to subtract its insets from its size while doing the > children min/pref width/height calculations. > > A parameterized test has been included. > > It is a simplified version of the test case attached to > https://bugs.openjdk.org/browse/JDK-8313709, but still shows how without this > patch, two of the cases (padding with or without margin) fail, while pass > with it.
Jose Pereda has updated the pull request incrementally with one additional commit since the last revision: Migrate old tests to JUnit 5 ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1203/files - new: https://git.openjdk.org/jfx/pull/1203/files/ce6c0dad..e0c79da5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1203&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1203&range=00-01 Stats: 9 lines in 1 file changed: 5 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jfx/pull/1203.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1203/head:pull/1203 PR: https://git.openjdk.org/jfx/pull/1203
