On Tue, 22 Aug 2023 09:54:11 GMT, Prasanta Sadhukhan
wrote:
> Issue is when setting the content of a SwingNode, the old content is not
> garbage collected owing to the fact
> JLightweightFrame is never being released by SwingNodeDisposer
>
> The SwingNodeDisposer holds an hard pointer to the J
> Issue is when setting the content of a SwingNode, the old content is not
> garbage collected owing to the fact
> JLightweightFrame is never being released by SwingNodeDisposer
>
> The SwingNodeDisposer holds an hard pointer to the JLightweightFrame that
> prevents its collection
>
> Modified
Thanks for the heads-up Kevin,
I gave it a spin and found that generally because I use Task to load my
fxml views I had problems.
Some of these I could resolve by wrapping the offending line with runlater
in the fxml initialise method. This reminded me though of the days when
Tooltips had to be
On Tue, 22 Aug 2023 14:52:50 GMT, Andy Goryachev wrote:
>> Could be useful. Do you think it should be done as part of this PR or should
>> we create separate bug and take it up in test sprint?
>
> sure, we can use the upcoming test sprint to add these tests. would you
> please create a ticket?
On Tue, 22 Aug 2023 06:30:02 GMT, John Hendrikx wrote:
> Backport of https://bugs.openjdk.org/browse/JDK-8312058
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1218#pullrequestreview-1589905070
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Tue, 22 Aug 2023 06:03:01 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commi
> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares
> two methods:
> - public ObservableMap getProperties();
> - public boolean hasProperties();
>
> 2. Node, MenuItem, and Toggle now extend ContainsProperties interface.
>
> 3. Making implemented methods in Node, MenuIte
On Tue, 22 Aug 2023 09:13:08 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 22 Aug 2023 05:51:32 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> li
On Tue, 22 Aug 2023 09:37:46 GMT, Karthik P K wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/AreaChartTest.java
>> line 502:
>>
>>> 500:
>>> 501: //JDK-8283675
>>> 502: @Test public void testChartFillRemovedOnClearingSeries() {
>>
>> should we add a similar te
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K wrote:
> The issue is present in AreaChart along with the LineChart. Issue is fixed in
> both the charts as part of this PR.
> The line elements in case of Line chart and both line element and fill
> element in the case of Area charts were not clear
On Tue, 22 Aug 2023 09:54:11 GMT, Prasanta Sadhukhan
wrote:
> Issue is when setting the content of a SwingNode, the old content is not
> garbage collected owing to the fact
> JLightweightFrame is never being released by SwingNodeDisposer
>
> The SwingNodeDisposer holds an hard pointer to the J
On Tue, 22 Aug 2023 09:54:11 GMT, Prasanta Sadhukhan
wrote:
> Issue is when setting the content of a SwingNode, the old content is not
> garbage collected owing to the fact
> JLightweightFrame is never being released by SwingNodeDisposer
>
> The SwingNodeDisposer holds an hard pointer to the J
Issue is when setting the content of a SwingNode, the old content is not
garbage collected owing to the fact
JLightweightFrame is never being released by SwingNodeDisposer
The SwingNodeDisposer holds an hard pointer to the JLightweightFrame that
prevents its collection
Modified `SwingNode.setCo
On Mon, 21 Aug 2023 23:11:49 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Mon, 21 Aug 2023 18:41:01 GMT, Andy Goryachev wrote:
> @karthikpandelu would you please check if we already have a similar issue and
> create one if not?
I couldn't find a similar issue, created
[JDK-8314754](https://bugs.openjdk.org/browse/JDK-8314754)
> modules/javafx.controls/src/test/j
18 matches
Mail list logo
