On Fri, 8 Sep 2023 18:37:43 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Fri, 8 Sep 2023 05:17:43 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Fri, 8 Sep 2023 18:37:43 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 8 Sep 2023 18:18:30 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> only public
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line 99:
>
On Fri, 8 Sep 2023 18:32:18 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Fri, 8 Sep 2023 18:13:45 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> only public
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line 103:
On Fri, 8 Sep 2023 15:01:34 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Fri, 8 Sep 2023 16:50:25 GMT, Michael Strauß wrote:
>> if that's the case, isn't it possible to have the same key added at runtime?
>> this scenario cannot be handled by the current code, as far as I can tell.
>
> I'm not sure if I understand what you mean that the same key can be added at
On Wed, 6 Sep 2023 18:22:38 GMT, Kevin Rushforth wrote:
> As mentioned in the JBS Description, I generated this PR by running the same
> copyright tool we use to update the jfx repo, with a slight modification to
> not filter out those files that already had "Copyright.*2023", since those
> ar
On Wed, 6 Sep 2023 18:22:38 GMT, Kevin Rushforth wrote:
> As mentioned in the JBS Description, I generated this PR by running the same
> copyright tool we use to update the jfx repo, with a slight modification to
> not filter out those files that already had "Copyright.*2023", since those
> ar
On Tue, 22 Aug 2023 09:46:28 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> Looks good. Gave a couple of minor optional suggestions.
>
> As to the topic of class finding, I t
> There was a field in a subclass hiding a field in a superclass.
Alexandre Iline has updated the pull request incrementally with two additional
commits since the last revision:
- Copyright. :|
- Copyright year
-
Changes:
- all: https://git.openjdk.org/jfx-tests/pull/8/files
On Fri, 8 Sep 2023 14:36:11 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Handle key removals
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/ChangedValue.ja
On Fri, 8 Sep 2023 17:04:56 GMT, Alexandre Iline wrote:
> There was a field in a subclass hiding a field in a superclass.
@jayathirthrao FYI
-
PR Comment: https://git.openjdk.org/jfx-tests/pull/8#issuecomment-1711980230
There was a field in a subclass hiding a field in a superclass.
-
Commit messages:
- JDK-8315895: Some 3D camera tests fail because of NPE
Changes: https://git.openjdk.org/jfx-tests/pull/8/files
Webrev: https://webrevs.openjdk.org/?repo=jfx-tests&pr=8&range=00
Issue: https://bugs
On Fri, 8 Sep 2023 14:31:07 GMT, Andy Goryachev wrote:
>> Looks like I spoke too soon. Mappings can actually be removed at runtime,
>> one such example is `Windows.SPI.HighContrastColorScheme`, which is only
>> available if `Windows.SPI.HighContrast` is `true`.
>>
>> This doesn't change the `C
On Fri, 8 Sep 2023 15:01:34 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request i
On Thu, 7 Sep 2023 16:41:23 GMT, Andy Goryachev wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
>> (using Math.floor), see for instance
>> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
>> methods Region.snapPortionX/Y().
>
> And
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color tolerance will not c
On Fri, 1 Sep 2023 03:16:11 GMT, Prasanta Sadhukhan
wrote:
> Added automated test for 8262518:SwingNode.setContent does not close previous
> content, resulting in memory leak
This pull request has now been integrated.
Changeset: eb7de72d
Author:Prasanta Sadhukhan
URL:
https://git.
On Thu, 7 Sep 2023 16:41:23 GMT, Andy Goryachev wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
>> (using Math.floor), see for instance
>> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
>> methods Region.snapPortionX/Y().
>
> And
On Fri, 8 Sep 2023 06:38:54 GMT, Karthik P K wrote:
>> Snapping introduces differences between computed values and snapped values,
>> so we need to use non-zero tolerance when checking for equality. The
>> maximum tolerance is (1 / scale) - one display pixel scaled back to the
>> local coordi
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 8 Sep 2023 13:02:31 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commi
On Fri, 8 Sep 2023 05:17:43 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Mon, 4 Sep 2023 06:34:18 GMT, Prasanta Sadhukhan
wrote:
>> Added automated test for 8262518:SwingNode.setContent does not close
>> previous content, resulting in memory leak
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revisio
On Fri, 8 Sep 2023 05:16:35 GMT, Michael Strauß wrote:
>> The set of preferences that is reported by a platform is hard-coded in the
>> native platform implementation, and depends on the operating system version.
>> It might indeed be the case that an OS upgrade/downgrade could result in a
>>
On Thu, 7 Sep 2023 21:55:31 GMT, Kevin Rushforth wrote:
> Fix icu to compile with the latest VS 2022 compilers. Note that this fix is
> already present in the upstream ICU repo. See
> unicode-org/icu@c7e967c456ceff6436607ca2a3da034320ca34c3
>
> I've built this using the current compilers on al
On Fri, 8 Sep 2023 12:29:28 GMT, Johan Vos wrote:
> Didn't test with VS 2022 17.6.5 though but most important is that we don't
> have regression with the required compilers...
My thoughts exactly.
-
PR Comment: https://git.openjdk.org/jfx/pull/1235#issuecomment-1711664955
On Fri, 8 Sep 2023 07:07:40 GMT, Jayathirth D V wrote:
> Two perspective lod tests fail because of minute differences in expected
> values.
>
> Failing tests:
> test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
> test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java:
>
> Exception:
> te
On Thu, 7 Sep 2023 23:32:15 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request w
On Thu, 7 Sep 2023 21:55:31 GMT, Kevin Rushforth wrote:
> Fix icu to compile with the latest VS 2022 compilers. Note that this fix is
> already present in the upstream ICU repo. See
> unicode-org/icu@c7e967c456ceff6436607ca2a3da034320ca34c3
>
> I've built this using the current compilers on al
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color tolerance will not c
On Thu, 7 Sep 2023 07:58:08 GMT, Jayathirth D V wrote:
> Currently only 18 out of 62 3D tests run properly in jfx-tests repo.
> All the shape tests under "test/scenegraph/fx3d/shapes" and
> "test/scenegraph/fx3d/subscene/shapes" fail because they are not able to find
> image input they need.
>
On Fri, 8 Sep 2023 10:27:45 GMT, Ajit Ghaisas wrote:
> The changes are fine and they work. One suggestion is to define a common
> constant for 5% of tolerance value rather than using 0.05 in each of the
> changed file. This will allow us to adjust the tolerance percentage more
> easily in futu
Below tests fail due to "resource not found" error.
- test/scenegraph/binding/effects/IdentityTest.java
- test/scenegraph/lcd/controls/tests/AccordionTest.java
- Almost all ControlsTests/Chart tests
Fix :
Moved required resources to appropriate directory.
-
Commit messages:
- addres
On Thu, 7 Sep 2023 09:26:59 GMT, Ajit Ghaisas wrote:
> A few SceneGraphTests and ControlsTests/chart test classes are abstract
> classes and serve as base classes for other tests.
> They are excluded from test execution and hence result in avoiding false
> failure reports.
Please collate such
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color tolerance will not c
On Thu, 7 Sep 2023 07:58:08 GMT, Jayathirth D V wrote:
> Currently only 18 out of 62 3D tests run properly in jfx-tests repo.
> All the shape tests under "test/scenegraph/fx3d/shapes" and
> "test/scenegraph/fx3d/subscene/shapes" fail because they are not able to find
> image input they need.
>
I think the interfaces may expose things that have been developed
independently with different names but are the same thing.
For example, Window has the `showing` property, but effectively it works
similar to `visible`. The split between `Disable` and `Disabled` should
be removed IMHO by maki
On Wed, 6 Sep 2023 18:22:38 GMT, Kevin Rushforth wrote:
> As mentioned in the JBS Description, I generated this PR by running the same
> copyright tool we use to update the jfx repo, with a slight modification to
> not filter out those files that already had "Copyright.*2023", since those
> ar
Two perspective lod tests fail because of minute differences in expected values.
Failing tests:
test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java:
Exception:
test test.scenegraph.fx3d.lod.LodTests.sphereInitialLightOnTest(): failure
org
On Thu, 7 Sep 2023 09:26:59 GMT, Ajit Ghaisas wrote:
> A few SceneGraphTests and ControlsTests/chart test classes are abstract
> classes and serve as base classes for other tests.
> They are excluded from test execution and hence result in avoiding false
> failure reports.
LGTM.
I think in 3D
On Thu, 7 Sep 2023 18:26:50 GMT, Andy Goryachev wrote:
> Snapping introduces differences between computed values and snapped values,
> so we need to use non-zero tolerance when checking for equality. The maximum
> tolerance is (1 / scale) - one display pixel scaled back to the local
> coordin
45 matches
Mail list logo
