Integrated: 8317836: FX nodes embedded in JFXPanel need to track component orientation

2023-10-31 Thread Prasanta Sadhukhan
On Thu, 26 Oct 2023 09:34:17 GMT, Prasanta Sadhukhan wrote: > FX Nodes embedded in a Swing JFXPanel does not track the component > orientation and FX nodes remain unaffected when component orientation changes. > Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value > from

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 22:33:00 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line > 63

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 21:04:15 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line

Re: RFR: 8301302: Platform preferences API [v19]

2023-10-31 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 22:31:11 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line > 45

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 21:05:23 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/javafx/application/Appearance.java line >

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 20:58:55 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/P

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 20:19:42 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/com/sun/javafx/application/PlatformImpl.

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 20:13:11 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java

Re: RFR: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-10-31 Thread Andy Goryachev
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote: > After finding the Window virtual key code for a character getKeyCodeForChar > was using a mapping table that only works correctly for U.S. English to > retrieve the Java key code. This caused getKeyCodeForChar to encode keys > differently t

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-31 Thread Andy Goryachev
Dear Martin: This basically is the minimal API surface as far as InputMap is concerned. There are probably some methods still missing, such as ... Say I want Ctrl-J to be Copy instead of whatever it’s default binding is. InputMap.unbind(FunctionTag.COPY); • missing method. Or we could add I

Re: RFR: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-10-31 Thread Andy Goryachev
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote: > After finding the Window virtual key code for a character getKeyCodeForChar > was using a mapping table that only works correctly for U.S. English to > retrieve the Java key code. This caused getKeyCodeForChar to encode keys > differently t

Re: RFR: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-10-31 Thread Andy Goryachev
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote: > After finding the Window virtual key code for a character getKeyCodeForChar > was using a mapping table that only works correctly for U.S. English to > retrieve the Java key code. This caused getKeyCodeForChar to encode keys > differently t

Re: [External] : Re: Proof of concept pull request for Behavior API (PR 1265)

2023-10-31 Thread Andy Goryachev
Thank you, John. -andy From: John Hendrikx Date: Tuesday, October 31, 2023 at 16:13 To: Andy Goryachev , openjfx-dev@openjdk.org , Kevin Rushforth Subject: Re: [External] : Re: Proof of concept pull request for Behavior API (PR 1265) Hi Andy, I'm sorry if you feel I blocked your proposal.

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Nir Lisker
On Tue, 31 Oct 2023 20:35:47 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/P

Re: RFR: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-10-31 Thread Martin Fox
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote: > After finding the Window virtual key code for a character getKeyCodeForChar > was using a mapping table that only works correctly for U.S. English to > retrieve the Java key code. This caused getKeyCodeForChar to encode keys > differently t

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-31 Thread Martin Fox
Andy, I should have been clearer on why I wrote this up. I think once you’ve identified the minimum API surface that’s probably all you should implement. More important to me is whether reducing the API to a bunch of function tags and two API calls does everything that needs to be done. For exa

Re: [External] : Re: Proof of concept pull request for Behavior API (PR 1265)

2023-10-31 Thread John Hendrikx
Hi Andy, I'm sorry if you feel I blocked your proposal.  Discussions better happen at a stage far before a PR is being reviewed, and instead of having these discussions here, we could have had them on the PR. I'll try and formalize my proposals. --John On 30/10/2023 20:32, Andy Goryachev w

Re: [External] : Re: Prioritized event handlers

2023-10-31 Thread Andy Goryachev
Dear John: I am not convinced. I think there is no need for an extra mechanism (I am referring to waves), the scenario you are describing here that when I do `scene.addEventHandler(KeyEvent.KEY_PRESSED)` I won't see navigation keys because they are all consumed by a focused control. should, i

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Nir Lisker
On Tue, 31 Oct 2023 17:28:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: Prioritized event handlers

2023-10-31 Thread John Hendrikx
On 31/10/2023 18:12, Martin Fox wrote: I understand John’s point: you want all the user installed filters and handlers across all levels to be processed before switching to system level processing. I also understand this prioritization proposal is designed to push our existing set of system ha

Re: [External] : Re: Prioritized event handlers

2023-10-31 Thread John Hendrikx
On 31/10/2023 21:03, Andy Goryachev wrote: Dear Martin: I understand John’s point: you want all the user installed filters and handlers across all levels to be processed before switching to system level processing. I also understand this prioritization proposal is designed to push our existi

Re: RFR: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-10-31 Thread Andy Goryachev
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote: > After finding the Window virtual key code for a character getKeyCodeForChar > was using a mapping table that only works correctly for U.S. English to > retrieve the Java key code. This caused getKeyCodeForChar to encode keys > differently t

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

2023-10-31 Thread Sai Pradeep Dandem
> **Issue:** > Using pseudo classes in programmatic query using Node.lookupAll() or > Node.lookup() gives unexpected results. > > **Cause:** > There is no check for checking the psuedo states matching in the applies() > method of SimpleSelector.java. So checking for "applies()" alone is not > s

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread John Hendrikx
On Tue, 31 Oct 2023 17:28:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v12]

2023-10-31 Thread Sai Pradeep Dandem
On Mon, 30 Oct 2023 16:17:20 GMT, Kevin Rushforth wrote: >> Sai Pradeep Dandem has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8185831: Changes to doc as per review comments > > modules/javafx.graphics/src/main/java/javafx/scene/Node.jav

Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show [v2]

2023-10-31 Thread Andy Goryachev
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote: >> When a window is visible the maximized, iconified, and fullscreen properties >> are two-way streets; changes made in Java are sent on to the platform window >> and changes in the platform window are sent back into Java. >> >> When a window

Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show [v2]

2023-10-31 Thread Andy Goryachev
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote: >> When a window is visible the maximized, iconified, and fullscreen properties >> are two-way streets; changes made in Java are sent on to the platform window >> and changes in the platform window are sent back into Java. >> >> When a window

Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show [v2]

2023-10-31 Thread Andy Goryachev
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote: >> When a window is visible the maximized, iconified, and fullscreen properties >> are two-way streets; changes made in Java are sent on to the platform window >> and changes in the platform window are sent back into Java. >> >> When a window

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors.

2023-10-31 Thread Andy Goryachev
On Tue, 19 Sep 2023 22:26:31 GMT, Phil Race wrote: >> The Method javafx.print.getWidth and getHeight returns a double of points. >> But the values are always rounded to full integers. This causes especially >> problems, >> with mm based Papers. >> >> I asked in the mailing list, with the conclu

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]

2023-10-31 Thread John Hendrikx
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier wrote: >> The Method javafx.print.getWidth and getHeight returns a double of points. >> But the values are always rounded to full integers. This causes especially >> problems, >> with mm based Papers. >> >> I asked in the mailing list, with th

Re: [External] : Re: Prioritized event handlers

2023-10-31 Thread Andy Goryachev
Dear Martin: I understand John’s point: you want all the user installed filters and handlers across all levels to be processed before switching to system level processing. I also understand this prioritization proposal is designed to push our existing set of system handlers to a separate phase

[jfx17u] Integrated: 8319066: Application window not always activated in macOS 14 Sonoma

2023-10-31 Thread Jose Pereda
On Tue, 31 Oct 2023 19:17:19 GMT, Jose Pereda wrote: > Clean backport of 8319066: Application window not always activated in macOS > 14 Sonoma > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 22bd6571 Author:Jose Pereda URL: https://git.openjdk.org/j

[jfx21u] Integrated: 8319066: Application window not always activated in macOS 14 Sonoma

2023-10-31 Thread Jose Pereda
On Tue, 31 Oct 2023 18:41:56 GMT, Jose Pereda wrote: > Clean backport of 8319066: Application window not always activated in macOS > 14 Sonoma > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 1b18effd Author:Jose Pereda URL: https://git.openjdk.org/

[jfx17u] RFR: 8319066: Application window not always activated in macOS 14 Sonoma

2023-10-31 Thread Jose Pereda
Clean backport of 8319066: Application window not always activated in macOS 14 Sonoma Reviewed-by: kcr, arapte - Commit messages: - 8319066: Application window not always activated in macOS 14 Sonoma Changes: https://git.openjdk.org/jfx17u/pull/166/files Webrev: https://webrevs.op

[jfx21u] RFR: 8319066: Application window not always activated in macOS 14 Sonoma

2023-10-31 Thread Jose Pereda
Clean backport of 8319066: Application window not always activated in macOS 14 Sonoma Reviewed-by: kcr, arapte - Commit messages: - 8319066: Application window not always activated in macOS 14 Sonoma Changes: https://git.openjdk.org/jfx21u/pull/23/files Webrev: https://webrevs.op

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier wrote: >> The Method javafx.print.getWidth and getHeight returns a double of points. >> But the values are always rounded to full integers. This causes especially >> problems, >> with mm based Papers. >> >> I asked in the mailing list, with th

Integrated: 8319066: Application window not always activated in macOS 14 Sonoma

2023-10-31 Thread Jose Pereda
On Mon, 30 Oct 2023 12:46:03 GMT, Jose Pereda wrote: > On macOS 14. when a JavaFX application is launched from the command line it > is not activated, and the terminal application remains active. > > This PR forces the application activation on macOS 14, in case the app didn't > get activated

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]

2023-10-31 Thread Michael Strauß
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier wrote: >> The Method javafx.print.getWidth and getHeight returns a double of points. >> But the values are always rounded to full integers. This causes especially >> problems, >> with mm based Papers. >> >> I asked in the mailing list, with th

Re: RFR: 8301302: Platform preferences API [v14]

2023-10-31 Thread Michael Strauß
On Thu, 7 Sep 2023 12:24:53 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove javadocs >> - Add signal handler for gtk-theme-name > > modules/javafx.graphics/src/main/java/com/sun/glass/ui

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: RFR: 8311895: CSS Transitions [v9]

2023-10-31 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-scale-x: 1.1; > -fx-scale-y: 1.1; > > transi

Re: Prioritized event handlers

2023-10-31 Thread Martin Fox
I understand John’s point: you want all the user installed filters and handlers across all levels to be processed before switching to system level processing. I also understand this prioritization proposal is designed to push our existing set of system handlers to a separate phase. But is that a

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v10]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 16:36:06 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v10]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 16:36:06 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v10]

2023-10-31 Thread Prasanta Sadhukhan
> FX Nodes embedded in a Swing JFXPanel does not track the component > orientation and FX nodes remain unaffected when component orientation changes. > Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value > from the JFXPanel. Prasanta Sadhukhan has updated the pull request

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v9]

2023-10-31 Thread Prasanta Sadhukhan
On Tue, 31 Oct 2023 16:13:57 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 16:23:23 GMT, Andy Goryachev wrote: > Perhaps we can clean up the logic a bit, something like > > ``` > boolean rtl = ComponentOrientation.RIGHT_TO_LEFT.equals(cor); > stage.setNodeOrientation(rtl ? RTL : LTR) > ``` Yes, that's also what I trying to suggest in an earlier com

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 16:19:24 GMT, Kevin Rushforth wrote: > We would need to check whether Scene's getEffectiveOrientation handles that > correctly. I checked. It doesn't. effectiveOrientation must be either RTL or LTR (which makes sense), so without additional adjustments to the fix, I think w

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 16:19:24 GMT, Kevin Rushforth wrote: > For the Scene, yes, but we aren't talking about that. I got confused by the variable name "stage". You are right! The last code https://github.com/openjdk/jfx/pull/1271/commits/3b7be5d9888a24a5d1db2a5abcad3c647533544f works as expe

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 16:11:05 GMT, Andy Goryachev wrote: > The initial value for node orientation property is INHERIT For the Scene, yes, but we aren't talking about that. The EmbeddedWindow currently never has the value of INHERIT. It is either LTR (default) or RTL. Maybe it _should_ be set to

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 16:08:32 GMT, Kevin Rushforth wrote: > For the _effective_ NodeOrientation attribution in the embedded window, > there's no such thing as INHERIT. It's either LTR (default) or RTL. Correct. The initial value for node orientation property is INHERIT which generates effectiv

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Prasanta Sadhukhan
On Tue, 31 Oct 2023 15:54:00 GMT, Andy Goryachev wrote: > What would the behavior of a JLabel in a JPanel be when the JFrame is set > back to UNKNOWN? It sets it back to LTR it is toggled from RIGHT_TO_LEFT to UNNOWN. So, I updated PR to set JFXPanel to LTR for UNKNOWN..If set to INHERIT, then

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 15:55:39 GMT, Andy Goryachev wrote: > > if (!cor.equals(ComponentOrientation.UNKNOWN)) { > > boolean rtl = cor.equals(ComponentOrientation.RIGHT_TO_LEFT); > > stage.setNodeOrientation(rtl ? NodeOrientation.RIGHT_TO_LEFT : > > NodeOrientation.LEFT_TO_RIGH**T); } else { > > sta

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v9]

2023-10-31 Thread Prasanta Sadhukhan
> FX Nodes embedded in a Swing JFXPanel does not track the component > orientation and FX nodes remain unaffected when component orientation changes. > Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value > from the JFXPanel. Prasanta Sadhukhan has updated the pull request

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 15:54:40 GMT, Kevin Rushforth wrote: > if (!cor.equals(ComponentOrientation.UNKNOWN)) { > boolean rtl = cor.equals(ComponentOrientation.RIGHT_TO_LEFT); > stage.setNodeOrientation(rtl ? NodeOrientation.RIGHT_TO_LEFT : > NodeOrientation.LEFT_TO_RIGH**T); } else { > stage.setNod

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 15:47:37 GMT, Kevin Rushforth wrote: > What would the behavior of a JLabel in a JPanel be when the JFrame is set > back to UNKNOWN? I would expect a Scene in a JFXPanel to work the same way. exactly my point! the orientation of JComboBoxes in the toolbar in the monkey test

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 15:42:50 GMT, Prasanta Sadhukhan wrote: > I can add in JFXPanel.java > ``` > if (!cor.equals(ComponentOrientation.UNKNOWN)) { > boolean rtl = cor.equals(ComponentOrientation.RIGHT_TO_LEFT); > stage.setNodeOrientation(rtl ? NodeOrientation.RIGHT_TO_LEFT : > NodeOrientation.LEF

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Kevin Rushforth
On Mon, 30 Oct 2023 14:00:56 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 15:37:45 GMT, Prasanta Sadhukhan wrote: > Tha tis grey area which is not mentioned in the spec so I think retaining > existing is the appropriate according to me.. We may need others to weigh in. My understanding, UNKNOWN works exactly as INHERIT, behaving as LTR if nothi

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Prasanta Sadhukhan
On Mon, 30 Oct 2023 14:00:56 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Prasanta Sadhukhan
On Tue, 31 Oct 2023 15:36:20 GMT, Andy Goryachev wrote: > > I expect RTL because INHERIT is unsupported so it will retain the existing > > orientation, > > Why existing and not the initial? Tha tis grey area which is not mentioned in the spec so I think retaining existing is the appropriate a

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 15:34:14 GMT, Prasanta Sadhukhan wrote: > I expect RTL because INHERIT is unsupported so it will retain the existing > orientation, Why existing and not the initial? - PR Comment: https://git.openjdk.org/jfx/pull/1271#issuecomment-1787469258

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Prasanta Sadhukhan
On Tue, 31 Oct 2023 15:07:32 GMT, Andy Goryachev wrote: > > I think it is expected to retain RTL in this case.. > > Ok, INHERIT is not supported, but why do you expect RTL? Shouldn't it go back > to UNKNOWN and therefore LTR? > > ``` > public static final > [ComponentOrientation](https://docs

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-31 Thread Andy Goryachev
Dear Martin: Thank you for the analysis! Let me address each point 1) Ensure the user gets events before the control does. That’s a topic for a different thread. Partially supported, given the current limitation of the FX event handling mechanism. A user key binding registered via InputMap

Re: RFR: 8319066: Application window not always activated in macOS 14 Sonoma [v2]

2023-10-31 Thread Ambarish Rapte
On Mon, 30 Oct 2023 15:50:09 GMT, Jose Pereda wrote: >> On macOS 14. when a JavaFX application is launched from the command line it >> is not activated, and the terminal application remains active. >> >> This PR forces the application activation on macOS 14, in case the app >> didn't get activ

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-10-31 Thread Martin Fox
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) — >> w

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-10-31 Thread Martin Fox
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) — >> w

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 03:10:08 GMT, Prasanta Sadhukhan wrote: > I think it is expected to retain RTL in this case.. Ok, INHERIT is not supported, but why do you expect RTL? Shouldn't it go back to UNKNOWN and therefore LTR? public static final [ComponentOrientation](https://docs.oracle.com/e

Re: RFR: JDK-8269921 TextFlow: listeners on bounds can throw NPE while computing text bounds [v5]

2023-10-31 Thread Andy Goryachev
On Tue, 31 Oct 2023 14:37:15 GMT, Kevin Rushforth wrote: >> generally speaking - the behavior relating to the bounds is broken. >> >> Some components behave differently, after setting a listener to the bounds. >> 1.) Groups tend to call layout in the children. >> 2.) And Text seems to call lay

Re: RFR: 8319079: Missing range checks in decora [v2]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 05:55:56 GMT, Jayathirth D V wrote: >> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking >> for range when we read data from the source/destination buffers in native >> code. >> >> We need to add appropriate range checks in native JNI code also apa

Re: RFR: JDK-8269921 TextFlow: listeners on bounds can throw NPE while computing text bounds [v5]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 12:30:23 GMT, Florian Kirmaier wrote: >> I would suggest investigating this a bit further. >> >> The semantics of this method is to return valid Bounds, and it looks like we >> do not honor this contract. It is possible that we get the original >> exception because the li

Re: RFR: 8301302: Platform preferences API [v14]

2023-10-31 Thread Nir Lisker
On Wed, 6 Sep 2023 23:03:46 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8319066: Application window not always activated in macOS 14 Sonoma [v2]

2023-10-31 Thread Kevin Rushforth
On Mon, 30 Oct 2023 15:50:09 GMT, Jose Pereda wrote: >> On macOS 14. when a JavaFX application is launched from the command line it >> is not activated, and the terminal application remains active. >> >> This PR forces the application activation on macOS 14, in case the app >> didn't get activ

Re: RFR: JDK-8269921 TextFlow: listeners on bounds can throw NPE while computing text bounds [v5]

2023-10-31 Thread Florian Kirmaier
On Mon, 30 Oct 2023 15:22:51 GMT, Andy Goryachev wrote: >> Yes, we are definitely missing something. >> I looked at it for quite some time, without a better solution as this check. >> If you'd like to investigate further - I would recommend you look into the >> stack trace of the ticket. >> It's

Re: JDK-8303478

2023-10-31 Thread Kevin Rushforth
Hi, Yes, if you are willing to contribute a fix, follow the steps in CONTRIBUTING.md. Please also include an automated test for the fix. Thank you. -- Kevin On 10/31/2023 2:11 AM, Bruno Carle wrote: Hello, I have written a small fix for https://bugs.openjdk.org/browse/JDK-8303478. The fix p

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]

2023-10-31 Thread Florian Kirmaier
On Thu, 26 Oct 2023 01:51:52 GMT, Michael Strauß wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8316518 >> small change based on codereview > > modules/javafx.graphics/src/main/java/javafx/print/Paper.ja

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]

2023-10-31 Thread Florian Kirmaier
> The Method javafx.print.getWidth and getHeight returns a double of points. > But the values are always rounded to full integers. This causes especially > problems, > with mm based Papers. > > I asked in the mailing list, with the conclusion (me and John Hendrix) that > is best to just fix this

Re: RFR: 8311895: CSS Transitions [v7]

2023-10-31 Thread null
On Wed, 9 Aug 2023 18:41:32 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Example >> >> .button { >> -fx-background-color: dodgerblue; >> } >> >> .button:hover { >> -fx-background-color:

Re: RFR: JDK-8187314: All Cells: must show backing data always

2023-10-31 Thread Ajit Ghaisas
On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl wrote: > Before, the `updateItem` method was called with the new value that was > committed via `commitEdit()`. > This is problematic as developers may setup a commit handler via > `setOnEditCommit`, which may reject the edit (or change the value oth

JDK-8303478

2023-10-31 Thread Bruno Carle
Hello, I have written a small fix for https://bugs.openjdk.org/browse/JDK-8303478. The fix prevents the DatePicker from losing focus if the date is not parsable. Should I create a pull request? I have seen the steps in CONTRIBUTING.md and I will try to follow them. Best Regards Bruno

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-31 Thread vlaaad
On Sun, 22 Oct 2023 21:25:45 GMT, Martin Fox wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v2]

2023-10-31 Thread vlaaad
On Mon, 30 Oct 2023 18:08:52 GMT, Martin Fox wrote: >> vlaaad has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Revert java changes and set NSFunctionKeyMask for non-F1-F24 menu items > > modules/javafx.graphics/src/main/native-glass/mac/G

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-10-31 Thread vlaaad
> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). > > Context: the warning might be more important than it seems. Our JavaFX-based > desktop app has [an issue](https://github.com/defold/defold/issues/7845) — > when the user opens 2 instances of the app, one of the i