Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-07 Thread Ambarish Rapte
On Tue, 7 Nov 2023 16:04:56 GMT, Martin Fox wrote: >> @vlaaad >> Yes please, I think we should have a test along with this fix. A test is >> missing for this scenario. >> If a unit test is not feasible, can you please check to add a system test ? >> ( may be something like setting F1 as accele

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-07 Thread Ambarish Rapte
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) — >> w

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

2023-11-07 Thread Martin Fox
On Mon, 6 Nov 2023 17:53:42 GMT, Ambarish Rapte wrote: >> @arapte anything else I could do? > > @vlaaad > Yes please, I think we should have a test along with this fix. A test is > missing for this scenario. > If a unit test is not feasible, can you please check to add a system test ? ( > may

[jfx21u] Integrated: 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache

2023-11-07 Thread Jose Pereda
On Tue, 7 Nov 2023 11:55:36 GMT, Jose Pereda wrote: > Clean backport of 8307536: FileAlreadyExistsException from NativeLibLoader > when running concurrent applications with empty cache > > Reviewed-by: kcr, angorya, jvos This pull request has now been integrated. Changeset: ea9f143a Author:

[jfx21u] RFR: 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache

2023-11-07 Thread Jose Pereda
Clean backport of 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache Reviewed-by: kcr, angorya, jvos - Commit messages: - 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with

Re: Public Behavior API proposal

2023-11-07 Thread John Hendrikx
Hi Michael, Thanks a lot for this early feedback. I think in light of it I will rework the proposal(s) to include semantic events right from the beginning. More inline comments below. --John On 07/11/2023 08:09, Michael Strauß wrote: Hi John, I like that you clearly define the terms Contr