The change listener on caretPositionProperty() was not getting invoked on
replacing the content with same text as there was no change in caret position.
Since the textProperty invalidation sets the forward bias to true by default,
incorrect caret position was calculated when the same text was r
On Mon, 13 Nov 2023 18:45:13 GMT, Kevin Rushforth wrote:
> This PR updates the micro version of the compiler on macOS to 14.3.1 (from
> 14.3) to match JDK 22.
>
> I've run headless and headful tests.
Marked as reviewed by sykora (Author).
-
PR Review: https://git.openjdk.org/jfx/
On Mon, 13 Nov 2023 18:45:13 GMT, Kevin Rushforth wrote:
> This PR updates the micro version of the compiler on macOS to 14.3.1 (from
> 14.3) to match JDK 22.
>
> I've run headless and headful tests.
This pull request has now been integrated.
Changeset: d24e96a6
Author:Kevin Rushforth
UR
> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from
> 17.5.0) to match JDK 22.
>
> I've run headless and headful tests.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains two commits:
- Merge b
On Tue, 31 Oct 2023 17:24:05 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Example
>>
>> .button {
>> -fx-background-color: dodgerblue;
>> }
>>
>> .button:hover {
>> -fx-background-color:
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A foll
On Fri, 10 Nov 2023 10:34:08 GMT, Johan Vos wrote:
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
@arapte can you be the primary reviewer for this?
-
PR Comment
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote:
> After finding the Window virtual key code for a character getKeyCodeForChar
> was using a mapping table that only works correctly for U.S. English to
> retrieve the Java key code. This caused getKeyCodeForChar to encode keys
> differently t
On Thu, 2 Nov 2023 19:49:52 GMT, Thiago Milczarek Sayao
wrote:
> Observed that the window manager takes care of showing and hiding children
> because we set `gtk_window_set_transient_for`.
>
> Works since Ubuntu 16.04.
>
> This PR removes the code to show or hide children because it "duplicat
On Mon, 30 Oct 2023 15:03:05 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
On Mon, 30 Oct 2023 15:03:05 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Thu, 2 Nov 2023 19:49:52 GMT, Thiago Milczarek Sayao
wrote:
> Observed that the window manager takes care of showing and hiding children
> because we set `gtk_window_set_transient_for`.
>
> Works since Ubuntu 16.04.
>
> This PR removes the code to show or hide children because it "duplicat
This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match JDK
22.
I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
-
Commit messages:
- 8319996: Update to GCC 13.2.0 on Linux
Changes: https://git.openjdk.org/jfx/pull/1286/files
Webrev: https
On Tue, 14 Nov 2023 00:24:30 GMT, Kevin Rushforth wrote:
> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match
> JDK 22.
>
> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
Reviewers: @arapte @johanvos @tiainen
-
PR Comment: https://g
On Tue, 14 Nov 2023 16:52:16 GMT, Andy Goryachev wrote:
>> A KeyCharacterCombination should match a key if the target character is
>> printed on that key. For example, the user should be able to invoke the
>> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
>> key th
Clean backport of compiler update to jfx21u
-
Commit messages:
- Backport d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c
Changes: https://git.openjdk.org/jfx21u/pull/27/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=27&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8318
On Wed, 8 Nov 2023 19:43:24 GMT, Kevin Rushforth wrote:
>> Fix [JDK-8319669](https://bugs.openjdk.org/browse/JDK-8319669) as follows:
>>
>> 1. Override the `NSApplicationDelegate` method
>> `applicationSupportsSecureRestorableState` in `GlassApplication` and return
>> `YES`. This silences the
On Tue, 14 Nov 2023 20:26:00 GMT, Martin Fox wrote:
>> It looks like the scope of this change went beyond the original problem in
>> JBS.
>> Would it be possible to update the JBS ticket with the information in this
>> PR description?
>
> @andy-goryachev-oracle You're right, this PR also deals
On Tue, 14 Nov 2023 12:47:51 GMT, Kevin Rushforth wrote:
>> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from
>> 17.5.0) to match JDK 22.
>>
>> I've run headless and headful tests.
>
> Kevin Rushforth has updated the pull request with a new target base due to a
> merge
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote:
> After finding the Window virtual key code for a character getKeyCodeForChar
> was using a mapping table that only works correctly for U.S. English to
> retrieve the Java key code. This caused getKeyCodeForChar to encode keys
> differently t
On Wed, 8 Nov 2023 19:43:24 GMT, Kevin Rushforth wrote:
>> Fix [JDK-8319669](https://bugs.openjdk.org/browse/JDK-8319669) as follows:
>>
>> 1. Override the `NSApplicationDelegate` method
>> `applicationSupportsSecureRestorableState` in `GlassApplication` and return
>> `YES`. This silences the
On Fri, 10 Nov 2023 16:51:22 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minor
thank you for adding a test case!
t
On Fri, 10 Nov 2023 21:23:54 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
Dear colleagues:
I would like to thank John and Michael for a lively discussion, during which we
clarified a number of concepts, specifically the roles of Control (C), Skin
(S), and Behavior (B). There is still a bit of difference in how we see
things, but I am pleased to say we do have a lot
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote:
> After finding the Window virtual key code for a character getKeyCodeForChar
> was using a mapping table that only works correctly for U.S. English to
> retrieve the Java key code. This caused getKeyCodeForChar to encode keys
> differently t
On Tue, 14 Nov 2023 21:03:59 GMT, Andy Goryachev wrote:
>> @andy-goryachev-oracle You're right, this PR also deals with the problem of
>> the map retaining stale entries when the user switches layout. I added
>> details about this to the JBS ticket. We could treat it as a separate bug if
>> yo
On Tue, 14 Nov 2023 12:47:51 GMT, Kevin Rushforth wrote:
>> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from
>> 17.5.0) to match JDK 22.
>>
>> I've run headless and headful tests.
>
> Kevin Rushforth has updated the pull request with a new target base due to a
> merge
On Tue, 14 Nov 2023 00:24:30 GMT, Kevin Rushforth wrote:
> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match
> JDK 22.
>
> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
Marked as reviewed by arapte (Reviewer).
-
PR Review: https:/
30 matches
Mail list logo
