Re: Public Behavior API proposal

2023-11-20 Thread Michael Strauß
I don't want to restart the process, but I suspect that InputMap might be better suited for specific controls only, not as a general-purpose API. Maybe InputMap is part of a specific type of Behavior? Do you think that InputMap can carry its own weight, independent of a future extension of the cont

Re: RFR: 8318387: Update GStreamer to 1.22.6

2023-11-20 Thread Alexander Matveev
On Fri, 17 Nov 2023 21:27:04 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. > - Tested on all platforms with all supported media streams. > - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older > GLib versions on Linux following A

Re: RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2023-11-20 Thread Alexander Matveev
> - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. > - Tested on all platforms with all supported media streams. > - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older > GLib versions on Linux following APIs were changed from new to old one > (restored GStreamer 1.

JavaFX 21.0.2 will be closed for fixes on December 4th

2023-11-20 Thread Kevin Rushforth
All, If you have backports that you want to get into jfx21u for JavaFX 21.0.2, please do so by Monday, December 4th. Note that approval from one of the project leads is needed as outlined in this message [1]. Thanks. -- Kevin [1] https://mail.openjdk.org/pipermail/openjfx-dev/2023-August/04

RFR: JDK-8320444: Column drag header is positioned wrong for nested columns

2023-11-20 Thread Marius Hanl
When a nested column is dragged, the column drag header (blue) is positioned wrong. It appears at the very left of the table and not where the column is. ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c38-9549-e2e20f5bd4f8) The fix is to calculate the bound based off the

Re: Public Behavior API proposal

2023-11-20 Thread Andy Goryachev
Dear Michael: I don’t understand. In the past month and a half, we identified a number of problems, and are converging at a solution. Do you want to restart the process? Is there a special order of doing things you would rather see? -andy From: openjfx-dev on behalf of Michael Strauß

Re: Public Behavior API proposal

2023-11-20 Thread Michael Strauß
Hi Andy! I think this can be a valid approch, but I have concerns regarding the order in which we do things here. In my opinion, InputMap is a special case of a more general Behavior API. We should decide whether we want to revamp the control architecture at all, and if we do, then we should do t

Re: Public Behavior API proposal

2023-11-20 Thread Andy Goryachev
Dear colleagues: I wanted to gauge your opinion on a slightly different approach that addresses both John’s stateless behaviors use case as well as make it unnecessary to change existing event handling APIs but still enforce the right order of event handler execution. Let’s call it a Split Inp

Re: RFR: 8301302: Platform preferences API [v28]

2023-11-20 Thread Kevin Rushforth
On Mon, 20 Nov 2023 19:12:25 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v28]

2023-11-20 Thread Andy Goryachev
On Mon, 20 Nov 2023 19:12:25 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v28]

2023-11-20 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v6]

2023-11-20 Thread Kevin Rushforth
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote: >> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed

2023-11-20 Thread Kevin Rushforth
On Mon, 20 Nov 2023 05:37:38 GMT, Ambarish Rapte wrote: > Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y > client application requests for it. > Ideally we should use the text set by `Node.setAccessibleText()` as the > `UIA_NamePropertyId`. > For other controls suc

Integrated: 8303826: Add FX test for JDK-8252255

2023-11-20 Thread Prasanta Sadhukhan
On Thu, 9 Nov 2023 03:43:48 GMT, Prasanta Sadhukhan wrote: > Manual regression test for 8252255: Blurry rendering of SwingNode with HiDPI > scaling in JavaFX is added This pull request has now been integrated. Changeset: a1036b26 Author:Prasanta Sadhukhan URL: https://git.openjdk.

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-11-20 Thread Johan Vos
On Fri, 10 Nov 2023 12:37:13 GMT, John Hendrikx wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java > li

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-11-20 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: process reviewers co