[jfx21u] RFR: 8318387: Update GStreamer to 1.22.6

2023-11-22 Thread Alexander Matveev
Clean backport of JDK-8318387. - Commit messages: - Backport 606878af275dbad551a10653c92a2deef61c10cd Changes: https://git.openjdk.org/jfx21u/pull/33/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=33=00 Issue: https://bugs.openjdk.org/browse/JDK-8318387 Stats: 45668

Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]

2023-11-22 Thread Phil Race
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier wrote: >> The Method javafx.print.getWidth and getHeight returns a double of points. >> But the values are always rounded to full integers. This causes especially >> problems, >> with mm based Papers. >> >> I asked in the mailing list, with

Re: RFR: 8313648: JavaFX application continues to show a black screen after graphic card driver crash

2023-11-22 Thread Marius Hanl
On Sat, 5 Aug 2023 12:28:16 GMT, Thorsten Fischer wrote: > Hi, > > I did open the bug report. Some notes to this PR: > > My colleagues and I are able to reproduce this bug regularly, even though it > takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows > up. We are

Re: RFR: 8313648: JavaFX application continues to show a black screen after graphic card driver crash

2023-11-22 Thread mintykat
On Sat, 5 Aug 2023 12:28:16 GMT, Thorsten Fischer wrote: > Hi, > > I did open the bug report. Some notes to this PR: > > My colleagues and I are able to reproduce this bug regularly, even though it > takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows > up. We are

Integrated: JDK-8320444: Column drag header is positioned wrong for nested columns

2023-11-22 Thread Marius Hanl
On Mon, 20 Nov 2023 22:24:58 GMT, Marius Hanl wrote: > When a nested column is dragged, the column drag header (blue) is positioned > wrong. > It appears at the very left of the table and not where the column is. > >

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-11-22 Thread Ambarish Rapte
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote: >> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y >> client application requests for it. >> Ideally we should use the text set by `Node.setAccessibleText()` as the >> `UIA_NamePropertyId`. >> For other

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v6]

2023-11-22 Thread Ambarish Rapte
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote: >> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-11-22 Thread Ambarish Rapte
> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y > client application requests for it. > Ideally we should use the text set by `Node.setAccessibleText()` as the > `UIA_NamePropertyId`. > For other controls such as Slider, ListView we use the text set by >

Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-11-22 Thread John Neffenger
On Tue, 21 Nov 2023 20:19:04 GMT, John Neffenger wrote: > Backport 16169240667876633895b27464eb90033abb6166 > > Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me > a day or two to test it again before starting your review. I ran the builds and unit tests on Linux,

Re: [External] : Re: JavaFX 21.0.2 will be closed for fixes on December 4th

2023-11-22 Thread Johan Vos
No concerns, good idea. On Tue, Nov 21, 2023 at 5:23 PM Kevin Rushforth wrote: > This one looks OK to me as long as there are no dependencies on other > fixes. It's been in jfx22 for a couple months, and don't recall any > regressions. > > Johan and Jose: you reviewed it, any concerns? > > --