On Thu, 30 Nov 2023 08:37:35 GMT, Hima Bindu Meda wrote:
>> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen.
>
> Hima Bindu Meda has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - update license for libxslt
> - upd
On Fri, 1 Dec 2023 14:28:43 GMT, Karthik P K wrote:
>> The change listener on caretPositionProperty() was not getting invoked on
>> replacing the content with same text as there was no change in caret
>> position. Since the textProperty invalidation sets the forward bias to true
>> by default,
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Mon, 4 Dec 2023 21:57:23 GMT, Kevin Rushforth wrote:
> I left comments about the NULL checks. I'll review the changes you made plus
> the files I haven't reviewed yet.
I've added the suggested null checks for all New* JNI functions, as well as for
`gtk_style_new`.
-
PR Comment
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Sat, 2 Dec 2023 00:58:28 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line
>> 68:
>>
>>> 66: jobject PlatformSupport::collectPreferences() const {
>>> 67: jobject prefs = env->NewObject(jHashMapCls, jHashMapInit);
>>> 68: if (EXC
On Sat, 2 Dec 2023 01:43:52 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Tue, 21 Nov 2023 00:01:14 GMT, Andy Goryachev wrote:
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
This pull request has now been integrated.
Changeset: aedc8879
Author:Andy Gory
Yep, that's exactly my point.
One may argue that using a local variable might help. I don't think there is a
warning for this kind of code pattern though.
-andy
From: openjfx-dev on behalf of Michael Strauß
Date: Monday, December 4, 2023 at 09:55
To:
Cc: openjfx-dev@openjdk.org
Subject: R
This might be different.
If we can guarantee that the access to the underlying variable(s) is single
threaded - then no. But we had at least one bug recently in JFXPanel where two
threads were involved. Those cases need to use a very different access
pattern(s), depending on the exact circums
Side effects are not limited to race conditions. A getter might return
a different value every time, or it might execute code other than
simply returning a value, or a lazy evaluation scheme might cause
other code to be executed. The point is, we don't know that at the
call site, we'd need to inspe
Thank you, Nir, for a thoughtful discussion.
It looks like whatever requirement that resulted in a lazy initialization is
not applicable anymore, or perhaps some later code changes in CssStyleHelper
changed the design in such a way that the lazy initialization is no longer
possible.
The idea o
I also see lots of instances of a pattern where the the return value
of a getter is checked, but then the getter is called again:
if (getScene() != null) {
getScene().getWindow() // and so on
}
While this generally works, we can't be 100% sure that this isn't
potentially defective
Good point.
-- Kevin
On 12/4/2023 9:24 AM, Johan Vos wrote:
Also, these commits often affect many files at once (in scattered
locations), and that makes backports harder.
- Johan
On Mon, Dec 4, 2023 at 6:14 PM Kevin Rushforth
wrote:
We did a few of these sort of cleanup fixes a year
Yes it might be worth looking at the possible null reference warnings.
Maybe file an umbrella Task to look through the warnings and decide what
to do with them? I don't think I like the "SuppressWarnings" as one of
the remedies, but we can discuss that further once we have a list.
-- Kevin
On
On Mon, 4 Dec 2023 06:39:47 GMT, Ambarish Rapte wrote:
> Update Copyright year in files modified in year 2023.
This pull request has now been integrated.
Changeset: a993b200
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx21u/commit/a993b20052ef561bd3b1958b1bd20f99ca562b05
Sta
Also, these commits often affect many files at once (in scattered
locations), and that makes backports harder.
- Johan
On Mon, Dec 4, 2023 at 6:14 PM Kevin Rushforth
wrote:
> We did a few of these sort of cleanup fixes a year or so ago.
>
> In general, this sort of cleanup *might* be useful, bu
On Thu, 30 Nov 2023 08:37:35 GMT, Hima Bindu Meda wrote:
>> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen.
>
> Hima Bindu Meda has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - update license for libxslt
> - upd
The last two are just unnecessary code, I see no problems turning this warning
off.
But the 'potential null access' one, though being a bit overeager, might
warrant a deeper scrutiny, as it might point to real bugs. I would suggest to
turn this warning on and fix or mark the occurences with "S
We did a few of these sort of cleanup fixes a year or so ago.
In general, this sort of cleanup *might* be useful, but also causes some
code churn and takes review cycles to ensure that there is no
unintentional side effect.
The last two might be OK cleanup tasks, but I wouldn't make them a hi
Dear colleagues:
Imported the openjfx project into another workspace with a more stringent error
checking and discovered a few issues:
* potential null pointer access: 295
* unnecessary cast or instanceof: 190
* redundant null check: 61
Do we want to clean these up?
-andy
On Mon, 4 Dec 2023 06:39:47 GMT, Ambarish Rapte wrote:
> Update Copyright year in files modified in year 2023.
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx21u/pull/38#pullrequestreview-1762790881
22 matches
Mail list logo
