On Wed, 7 Feb 2024 23:43:41 GMT, Andy Goryachev wrote:
> I see the emoji and tab text options work now, but inline nodes still fail.
I don't see issue with inline nodes. Please let me know in which case you are
facing issue.
On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Wed, 7 Feb 2024 23:31:43 GMT, Andy Goryachev wrote:
> > so I think that the 2nd line is incorrect.
>
> interesting: I would think the second line is correct. Could you check what a
> browser does in this situation?
Tested with `pre-wrap` which I think is the closest match there is for
On Wed, 7 Feb 2024 10:43:53 GMT, Karthik P K wrote:
> Since the emoji itself is not rendered properly I don't think it is an issue
> relevant to this PR.
Quite possibly, these are grapheme clusters which are currently not supported:
`☝☝☝臘♂️`
I see the emoji and tab text options work now,
On Wed, 7 Feb 2024 23:28:12 GMT, John Hendrikx wrote:
> so I think that the 2nd line is incorrect.
interesting: I would think the second line is correct. Could you check what a
browser does in this situation?
-
PR Comment:
On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx wrote:
>> one thing: you may sync up with the latest master branch, that's the
>> configuration I am testing.
>
> @andy-goryachev-oracle
>
> I'm not quite seeing what you are seeing. Here is a screenshots of `LOGICAL`
> setting with the text
On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx wrote:
>> one thing: you may sync up with the latest master branch, that's the
>> configuration I am testing.
>
> @andy-goryachev-oracle
>
> I'm not quite seeing what you are seeing. Here is a screenshots of `LOGICAL`
> setting with the text
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
Andy Goryachev has updated the pull request incrementally with one
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
Andy Goryachev has updated the pull request incrementally with two
I've created a proposal that defines preview features [0]. The
definition very closely matches the language used in JEP-12, but is
adapted for JavaFX in some places.
Additionally, I've created the internal helper class `PreviewFeature`
that can be used to verify that applications have opted into
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
The flicker
On Mon, 5 Feb 2024 16:46:40 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where
On Tue, 6 Feb 2024 23:32:25 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix test comment
>
> one thing: you may sync up with the latest master branch, that's the
> configuration I am
On Wed, 7 Feb 2024 08:14:26 GMT, Robert Lichtenberger
wrote:
> I hope this is the right approach for an RFE ...
thank you for filing an RFE, @effad
-
PR Comment: https://git.openjdk.org/jfx/pull/1358#issuecomment-1932319542
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
Hi,
Just adding my 2 cents to the discussion.
I think there's a precedent to this that the JavaFX team was using back in
JavaFX 8 and before it. It wasn't for preview features, but it had a
somewhat similar purpose.
There was an "@treatAsPrivate" annotation. This annotation was used in
methods
Hi,
I don't think it's possible to give a custom warning at compile time
without the user having a specific annotation processor active (ie, to
get the warning, they'd first need to set up an annotation processor
which FX provides). The problem here is that we can't enforce the use
of the
Yes, something like an opt-in property might be workable and is worth
considering. We would also want to explore ideas for producing a
compile-time warning along with with a pattern to document them. I'm not
familiar enough with what you can do with annotations, but maybe there
is something
On Wed, 7 Feb 2024 10:23:20 GMT, Ambarish Rapte wrote:
>> Requesting content layout when font changes.
>>
>> This change makes the visual impact of
>> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
>> perhaps both bugs should be fixed at the same time.
>
> With
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger
wrote:
> The PR simply moves column and view-updates outside the loop. Since the
> column or view never changes within the for-loop it is not necessary to call
> these again and again.
Looks good to me.
Checking `updateTableColumn` and
On Wed, 7 Feb 2024 09:59:45 GMT, Robert Lichtenberger
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>> line 670:
>>
>>> 668: cell.updateTableRow(tableRow);
>>> 669: cell.updateIndex(row);
>>> 670:
>>
>> we could also
On Wed, 7 Feb 2024 10:43:12 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to
As for the maven releases for EA snapshots: you're right, we're not
building/publishing them weekly.
We have an increasing number of requests for builds for particular
configurations, and with the more frequent LTS versions, the total build
processes are taking more time. All those builds are
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
With this
On Wed, 7 Feb 2024 08:52:32 GMT, Marius Hanl wrote:
>> The PR simply moves column and view-updates outside the loop. Since the
>> column or view never changes within the for-loop it is not necessary to call
>> these again and again.
>
>
Hi Kevin, Michael,
I think throwing an exception when using features that are preview
without a prerequisite property being present or set to some value would
be a good idea. JavaFX has quite a few properties already, and a
special one for previews would make it possible to ensure that such
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger
wrote:
> The PR simply moves column and view-updates outside the loop. Since the
> column or view never changes within the for-loop it is not necessary to call
> these again and again.
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger
wrote:
> The PR simply moves column and view-updates outside the loop. Since the
> column or view never changes within the for-loop it is not necessary to call
> these again and again.
I've filed
30 matches
Mail list logo
