On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> one thing: you may sync up with the latest master branch, that's the 
>> configuration I am testing.
>
> @andy-goryachev-oracle
> 
> I'm not quite seeing what you are seeing.  Here is a screenshots of `LOGICAL` 
> setting with the text `The   quick   brown   fox   jumps   over   the   lazy  
>  dog`; notice that there is a horizontal scroll bar -- that looks incorrect:
> 
> ![image](https://github.com/openjdk/jfx/assets/995917/0ce6b106-2fd6-4688-9f3c-ba7ec23484ad)
> 
> Now, for the `VISUAL` setting it is a bit hard to see if it is doing the 
> right thing because the `Text` node is lacking any kind of border to see 
> where the actual bounds are.  However, I do clearly see it responding to 
> underline on/off, so it is taking that into account somehow (which makes 
> sense for `VISUAL`)
> 
> `VISUAL` with underline on (notice scroll bar):
> 
> ![image](https://github.com/openjdk/jfx/assets/995917/90d770fc-3001-4492-ae68-0359739e81d9)
> 
> And off (notice scroll bar is gone):
> 
> ![image](https://github.com/openjdk/jfx/assets/995917/6171ec23-9a2f-4b13-81ff-5bfe999b1f30)
> 
> So, it seems that:
> - Logical bounds still have a bug where the `Text` is getting a scroll bar
> - Visual bounds seem to be what you'd expect (I see no bugs -- text is 
> correctly aligned with respect to **other** lines, but there may be trailing 
> spaces that take up additional visual space which results in the overall 
> alignment to be off (ie. right aligned text is not touching the right most 
> edge, since there are spaces there, but **only** when strike through or 
> underline is on (!!) ) -- again it is bit hard to tell as there is no border 
> to see where the visual bounds really are -- you have to look at the 
> horizonal scroll bar :)

@hjohn are you trying a single line?
Try this string:

The quick brown fox jumps over the lazy dog     
    The quick brown fox jumps over the lazy dog     


![Screenshot 2024-02-07 at 14 50 
56](https://github.com/openjdk/jfx/assets/107069028/b883d887-c16a-4af4-bd17-21ba9b8fdec6)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1236#issuecomment-1933066608

Reply via email to