Re: RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors [v5]

2024-02-12 Thread Kevin Rushforth
On Mon, 5 Feb 2024 16:46:40 GMT, Martin Fox wrote: >> Turning on warnings-as-errors for the macOS glass native code. Deprecated >> declarations are excluded and still appear as warnings. >> >> In the code that tries to locate the application's dock icon there were >> three instances where

Integrated: 8307117: TextArea: wrapText property ignored when changing font

2024-02-12 Thread Andy Goryachev
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote: > Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. This pull

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v5]

2024-02-12 Thread Andy Goryachev
On Sat, 10 Feb 2024 17:53:27 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

Re: [External] : Re: Platform preferences theme detection

2024-02-12 Thread Kevin Rushforth
Never mind about not knowing whether it's a JavaFX or an AWT bug. It's either a JavaFX bug or an inherent limitation. The problem you are running into is that when the AWT toolkit is initialized before the JavaFX toolkit, then necessarily, AWT is in charge of the NSApplication. Prior to the

Re: [External] : Re: Platform preferences theme detection

2024-02-12 Thread Kevin Rushforth
I can reproduce this on macOS 13.x using JDK 21.0.2 and the latest JavaFX. If I run the PlatformPreferencesChangedTest program in tests/manual/events we correctly detect the appearance changes. If I first initialize the AWT toollkit as follows, then it doesn't detect the changes:     public

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

2024-02-12 Thread John Hendrikx
On Mon, 12 Feb 2024 16:15:03 GMT, Andy Goryachev wrote: > It looks like the original intent was to have one monospaced (Monaco) and one > proportional (Tahoma) font. Perhaps we could come up with a list of > candidates and pick a font to use based on availability? These would all have to be

Re: [External] : Re: Platform preferences theme detection

2024-02-12 Thread Kevin Rushforth
Actually, it's worse than not detecting changes, it's simply not getting the right values at all. If I run the program when the system appearance is already in Dark mode, it doesn't get the correct values at start up. -- Kevin On 2/12/2024 9:20 AM, Kevin Rushforth wrote: I can reproduce this

Re: [External] : Re: Platform preferences theme detection

2024-02-12 Thread Christopher Schnick
Just tested with JDK 21.0.2 and the behavior is unchanged. I don't have an older macOS version <14 to test whether this issue is actually specific to 14 or not. On 12/02/2024 17:49, Kevin Rushforth wrote: There were changes to AWT in JDK 22 for macOS 14, so it might be worth trying JDK

Re: [External] : Re: Platform preferences theme detection

2024-02-12 Thread Kevin Rushforth
There were changes to AWT in JDK 22 for macOS 14, so it might be worth trying JDK 21.0.2. In the mean time, I'll do some testing of this as well now that I know it is related to initializing the AWT toolkit. -- Kevin On 2/12/2024 8:36 AM, Christopher Schnick wrote: I am using JDK 21+35 and

Re: Platform preferences theme detection

2024-02-12 Thread Christopher Schnick
I am using JDK 21+35 and JavaFX 22-ea+28 to run the project on macOS. I guess I can try upgrading to JDK 21.0.2, but I will just assume that there haven't been many changes to awt in that time. Interestingly, I found another issue that occurs when that call to |GraphicsEnvironment| is

Re: Platform preferences theme detection

2024-02-12 Thread Kevin Rushforth
That likely means that initializing the AWT toolkit is interfering with this functionality. I presume you are using a very recent ea build of JavaFX 22. What version of JDK are you using? -- Kevin On 2/10/2024 9:05 PM, Christopher Schnick wrote: Well, that is going to be a fun one to

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

2024-02-12 Thread Andy Goryachev
On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v5]

2024-02-12 Thread Kevin Rushforth
On Sat, 10 Feb 2024 17:53:27 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

2024-02-12 Thread Kevin Rushforth
On Mon, 12 Feb 2024 10:00:57 GMT, Karthik P K wrote: > I ran the tests in my Mac system with macOS 14.3 and found 2 tests are > failing with following error: I see the same two failures on our CI macOS 13.x and macOS 14.x test machines. On our Linux systems, all tests are skipped (meaning

[jfx22u] Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-12 Thread Hima Bindu Meda
On Mon, 12 Feb 2024 15:46:41 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 82618d0e Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/82618d0e41806df238128b7199a09bf208ebb428 Stats: 1877 lines in 128 files

[jfx22u] Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-12 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8 Changes: https://git.openjdk.org/jfx22u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u=11=00 Issue: https://bugs.openjdk.org/browse/JDK-8325258 Stats: 1877 lines in 128 files

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

2024-02-12 Thread Karthik P K
On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v12]

2024-02-12 Thread Karthik P K
On Fri, 9 Feb 2024 17:33:04 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add some clarifying documentation >> - Do not collapse trailing spaces of last line (where no soft wrap occurs) >