On Fri, 9 Feb 2024 17:33:04 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add some clarifying documentation >> - Do not collapse trailing spaces of last line (where no soft wrap occurs) > > modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java > line 1245: > >> 1243: * no matter where it occurs). >> 1244: */ >> 1245: > > @karthikpandelu could you please take a look at this comment here and this PR > in general (since you both are modifying the same file)? > > Is there anything to add? I checked my changes along with the changes in this PR. The changes made in [PR#1323](https://github.com/openjdk/jfx/pull/1323) works fine with these changes and proper hit test values are obtained. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1236#discussion_r1485956832
