Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-13 Thread John Hendrikx
On Fri, 9 Feb 2024 07:59:47 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-13 Thread Ambarish Rapte
On Tue, 13 Feb 2024 21:15:16 GMT, Kevin Rushforth wrote: > The fix looks good to me, and my initial testing shows that it works as > expected. I left a few suggestions on minor wording changes inline. I'll > reapprove if you make the changes. Thank you Kevin, Please have a re-look, I made the

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-13 Thread Ambarish Rapte
> This is accessibility specific fix. > > **Issue**: When a ListView is shown for first time then accessibility focus > rectangle is not drawn around the focused ListIem > > **Cause:** >The ListView takes a little time to create it's skin(ListViewSkin) and the > skins for

Re: RFR: JDK-8325798: Spinner throws uncatchable exception on tab out from garbled text

2024-02-13 Thread Michael Strauß
On Tue, 13 Feb 2024 20:42:08 GMT, Marius Hanl wrote: > When a `Spinner` is configured with e.g. Integers > (`IntegerSpinnerValueFactory`) and the user types in a `String`, e.g. 'abc' > and focuses another `Node`, an exception is thrown (`NumberFormatException`). > This exception is literally

Re: RFR: JDK-8325798: Spinner throws uncatchable exception on tab out from garbled text

2024-02-13 Thread Andy Goryachev
On Tue, 13 Feb 2024 20:42:08 GMT, Marius Hanl wrote: > When a `Spinner` is configured with e.g. Integers > (`IntegerSpinnerValueFactory`) and the user types in a `String`, e.g. 'abc' > and focuses another `Node`, an exception is thrown (`NumberFormatException`). > This exception is literally

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time

2024-02-13 Thread Kevin Rushforth
On Tue, 13 Feb 2024 12:29:49 GMT, Ambarish Rapte wrote: > This is accessibility specific fix. > > **Issue**: When a ListView is shown for first time then accessibility focus > rectangle is not drawn around the focused ListIem > > **Cause:** >The ListView takes a little time to create

Re: RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-13 Thread Kevin Rushforth
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote: > Issue: The current implementation of complex text rendering paths on the Java > platform is experiencing side effects. > Solution: We need to align with WebKit 616.1 standards. The patch supports > two paths simple rendering path and

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v5]

2024-02-13 Thread Marius Hanl
On Sat, 10 Feb 2024 17:53:27 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

RFR: JDK-8325798: Spinner throws uncatchable exception on tab out from garbled text

2024-02-13 Thread Marius Hanl
When a `Spinner` is configured with e.g. Integers (`IntegerSpinnerValueFactory`) and the user types in a `String`, e.g. 'abc' and focuses another `Node`, an exception is thrown (`NumberFormatException`). This exception is literally uncatchable, as it happens on focus lost. The issue is the same

Re: [External] : Re: Platform preferences theme detection

2024-02-13 Thread Michael Strauß
The reason why the values are wrong might be that in PlatformSupport.m L105, we query [NSApp effectiveApperance], but this always seems to return the light appearance if JavaFX doesn't own the NSApplication. On Mon, Feb 12, 2024 at 6:26 PM Kevin Rushforth wrote: > > Actually, it's worse than not

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time

2024-02-13 Thread Kevin Rushforth
On Tue, 13 Feb 2024 12:29:49 GMT, Ambarish Rapte wrote: > This is accessibility specific fix. > > **Issue**: When a ListView is shown for first time then accessibility focus > rectangle is not drawn around the focused ListIem > > **Cause:** >The ListView takes a little time to create

Re: RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-13 Thread Kevin Rushforth
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote: > Issue: The current implementation of complex text rendering paths on the Java > platform is experiencing side effects. > Solution: We need to align with WebKit 616.1 standards. The patch supports > two paths simple rendering path and

RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-13 Thread Jay Bhaskar
Issue: The current implementation of complex text rendering paths on the Java platform is experiencing side effects. Solution: We need to align with WebKit 616.1 standards. The patch supports two paths simple rendering path and complex rendering path based on text rendering mode.

Re: RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors [v5]

2024-02-13 Thread Martin Fox
On Mon, 12 Feb 2024 20:48:22 GMT, Kevin Rushforth wrote: >> Martin Fox has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Work-around for using a call not present in the Xcode 13.3 SDK. >> - Need correctly formed NSNotification when

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-13 Thread John Hendrikx
On Sat, 10 Feb 2024 15:13:44 GMT, Kevin Rushforth wrote: >>> > need 2 passes, because there already is a method named like that: >>> >>> oh yeah, sorry. `getStyleClassesSet()` ? >> >> That one is still available yes :) > > @hjohn I'm now leaning towards either `getStyleClassNames` or >

RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time

2024-02-13 Thread Ambarish Rapte
This is accessibility specific fix. **Issue**: When a ListView is shown for first time then accessibility focus rectangle is not drawn around the focused ListIem **Cause:** The ListView takes a little time to create it's skin(ListViewSkin) and the skins for ListItems(ListCellSkin) If