On Mon, 26 Feb 2024 15:10:33 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add additional test for IOOBE detection.
>> This test comes from JDK-8323787
>
> Getting back to this I ran the t
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the un
On Mon, 26 Feb 2024 11:35:06 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/RTLTextFlowCharacterIndexTest.java
>> line 238:
>>
>>> 236:
>>> 237: @Test
>>> 238: public void testTextAndTextFlowHitInfoForRTLEnglishText() throws
>>> Exception {
>>
>> I just
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to calculat
On Tue, 27 Feb 2024 05:09:20 GMT, Karthik P K wrote:
>> yes, this bothered me from the start. I did have a test case in the MT with
>> two text nodes with the same text, and it seemed to work correctly. or did
>> I miss something?
>
> Actually most of the repeating text cases are handled. I s
On Mon, 26 Feb 2024 16:41:05 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>> nec
On Mon, 26 Feb 2024 16:41:05 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>> nec
On Tue, 27 Feb 2024 13:51:08 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
Replace Thread.currentThread().getId() with Thread.currentThread().threadId()
-
Commit messages:
- Replace Thread.currentThread().getId() with Thread.currentThread().threadId()
Changes: https://git.openjdk.org/jfx/pull/1383/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=138
On Tue, 27 Feb 2024 17:58:13 GMT, Anirvan Sarkar wrote:
> Replace Thread.currentThread().getId() with Thread.currentThread().threadId()
Looks okay. `threadId` was added in JDK 19, but since we're on 21 now that
should be fine.
-
Marked as reviewed by jhendrikx (Committer).
PR Re
On Thu, 22 Feb 2024 23:13:26 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every pla
> IJG has released latest version of libjpeg 9f and we need to update our
> version also match 9f changes.
> IJG reference : https://www.ijg.org/
>
> With updated changes both headless and headful tests are green on all
> platforms.
>
> Also while updating to 9f noticed that many files don't ha
12 matches
Mail list logo
