RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux

Because of the difference in the size of characters in default fonts in different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. Increased the scene width to accommodate all the characters as required for the test to validate HitInfo values in all the platforms. - Com

Re: Re: [External] : Re: Q: Labeled.textTruncated Property (RFE)

Thank you for the feedback! The property is being added to Labeled, which happens to be a base class for the cells' skins. The truncated property therefore must work in all the subclasses, even those where computePrefWidth is hacked via `Properties.DEFER_TO_PARENT_PREF_WIDTH`. > Second, I wou

Re: Aw: Re: Skin ListenerHelper

The chapter with leaking skins is almost completed: memory leaks are plugged, the testing framework is in place, switching is fully supported. The only open ticket under umbrella JDK-8241364 ☂ Cleanup skin implementations to allow switching is du

Aw: Re: Skin ListenerHelper

Thanks for providing the examples with the Subscription API.Note though that I rather want to talk about that we have 2 different components taking care of the listeners and both are mixed up. ListenerHelper is totally fine for me, but that should be the only one.It would be nice to complete

[jfx22u] Integrated: 8327979: Change JavaFX release version to 22.0.2 in jfx22u

On Tue, 12 Mar 2024 13:44:48 GMT, Kevin Rushforth wrote: > Bump version number to 22.0.2 This pull request has now been integrated. Changeset: fdb2002b Author:Kevin Rushforth URL: https://git.openjdk.org/jfx22u/commit/fdb2002bad9fb3d1e36c0542182bdf4d1d0dd32f Stats: 2 lines in 2

Re: [jfx22u] RFR: 8327979: Change JavaFX release version to 22.0.2 in jfx22u

On Tue, 12 Mar 2024 13:44:48 GMT, Kevin Rushforth wrote: > Bump version number to 22.0.2 Marked as reviewed by arapte (Reviewer). - PR Review: https://git.openjdk.org/jfx22u/pull/19#pullrequestreview-1931624966

Re: RFR: 8092102: Labeled: truncated property [v4]

On Mon, 11 Mar 2024 22:03:49 GMT, Marius Hanl wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> labeled helper > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableCellSkin.java > line 133:

Re: RFR: 8324326: Update ICU4C to 74.2

On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms I haven't looked at it detail or tested it yet, but I did spot one thing that raises a question. @johanvos or @tiainen can one of you be the second rev

Re: RFR: 8324326: Update ICU4C to 74.2

On Tue, 12 Mar 2024 15:02:48 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/ThirdParty/icu/CMakeLists.txt line >> 593: >> >>> 591: >>> 592: # Get just file name without extension >>> 593: set(ICU_DATA_FILE_NAME "icudt74l") >> >> Shouldn't this be 742? > > Never mind.

Re: RFR: 8324326: Update ICU4C to 74.2

On Tue, 12 Mar 2024 14:56:55 GMT, Kevin Rushforth wrote: >> Updated icu to v74.2. Sanity testing looks fine. Verified build on all >> platforms > > modules/javafx.web/src/main/native/Source/ThirdParty/icu/CMakeLists.txt line > 593: > >> 591: >> 592: # Get just file name without extension >> 5

RFR: 8324326: Update ICU4C to 74.2

Updated icu to v74.2. Sanity testing looks fine. Verified build on all platforms - Commit messages: - Revert file permissions similar to master - Tab correction - Resolve PR error - Tab Correction - Merge branch 'master' into icu-74 - updated LICENSE - white space corrections

[jfx22u] RFR: 8327979: Change JavaFX release version to 22.0.2 in jfx22u

Bump version number to 22.0.2 - Commit messages: - 8327979: Change JavaFX release version to 22.0.2 in jfx22u Changes: https://git.openjdk.org/jfx22u/pull/19/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=19&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327979

[jfx21u] RFR: 8322795: CSS performance regression up to 10x

8322795: CSS performance regression up to 10x - Commit messages: - Backport 1dff7a1618a945a9a10ad2168f78aad3658e91a9 Changes: https://git.openjdk.org/jfx21u/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=54&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8

Re: Skin ListenerHelper

With subscriptions these kinds of helpers are really not needed anymore. Just do: Subscription combined = Subscription.combine( property1.subscribe( ... ), property2.subscribe( ... ) ); And clean it up with `combined.unsubscribe` in `dispose`. For non-property clean