On Sun, 24 Mar 2024 15:11:29 GMT, drmarmac wrote:
> This PR adds the missing checks, as well as code documentation that an
> IndexOutOfBoundsException may be thrown.
The fix and tests look good. I left a couple comments on the docs.
modules/javafx.base/src/main/java/javafx/collections/transfor
Thank you.
-- Kevin
On 4/29/2024 2:35 PM, Thiago Milczarek Sayão wrote:
I thought about possible legal conflicts.
The code is on my github - I'm exploring and testing before starting
the real work.
wayland-scanner generates code from the protocol specs, which are xml
files.
https://waylan
On Fri, 16 Feb 2024 22:35:49 GMT, Martin Fox wrote:
> At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event
> using the operation mask tracked in the GlassDragSource to determine the
> final transfer mode. That mask is only updated when a window in the JavaFX
> app is t
I thought about possible legal conflicts.
The code is on my github - I'm exploring and testing before starting the
real work.
wayland-scanner generates code from the protocol specs, which are xml files.
https://wayland.app/protocols/
I will write a new generator/scanner from scratch - it's not t
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
As a reminder, contributors must not include 3rd-party code in any
openjdk repo. Per the terms of the OCA, all code that you contribute to
OpenJDK must be your own code. This includes code you push to
openjdk/jfx-sandbox and code in a branch of a personal fork of
openjdk/jfx from which you crea
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prop
On Mon, 8 Apr 2024 18:19:22 GMT, Alexander Zuev wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> commit
On Mon, 29 Apr 2024 15:47:54 GMT, Oliver Kopp wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java
>> line 104:
>>
>>> 102: int length = text.length();
>>> 103: start = Utils.clamp(0, start, length);
>>> 104: end = Utils.clamp(st
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Mon, 29 Apr 2024 09:30:18 GMT, Florian Kirmaier
wrote:
>> In some situations, a part of the SG is no longer rendered.
>> I created a test program that showcases this problem.
>>
>> Explanation:
>>
>> This can happen, when a part of the SG, is covered by another Node.
>> In this part, one no
On Mon, 29 Apr 2024 12:35:19 GMT, Ambarish Rapte wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert using utility method
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java
>
On Mon, 29 Apr 2024 08:55:58 GMT, Karthik P K wrote:
> Is this expected?
I think it might be a bug - even though it's unclear how many words the text
"𑂦𑂷𑂔𑂣𑂳𑂩𑂲" contains, I would not expect it to go to the beginning of that
segment.
I suspect the code in `TextInputControl.endOfNextWord(boolean
On Mon, 29 Apr 2024 14:09:52 GMT, Ambarish Rapte wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert using utility method
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java
>
On Mon, 29 Apr 2024 14:09:03 GMT, yosbits wrote:
> I found a serious problem with this change.
Thank you! I've created https://bugs.openjdk.org/browse/JDK-8331319 feel free
to update / clarify the information in the ticket.
-
PR Comment: https://git.openjdk.org/jfx/pull/1356#issu
On Fri, 26 Apr 2024 22:58:37 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compa
On Fri, 26 Apr 2024 22:58:37 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compa
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote:
> This is a Mac only bug. If the user was in the middle of IM text composition
> and clicked on a different node the partially composed text was left in the
> old node and the IM window wasn't dismissed. This PR implements the existing
> fini
> Wayland implementation will require EGL.
>
> EGL works with Xorg as well. The idea is to be EGL first and if it fails,
> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available.
>
>
> See:
> [Switching the Linux graphics stack from GLX to
> EGL](https://mozillagfx.wordpress.com
> Wayland implementation will require EGL.
>
> EGL works with Xorg as well. The idea is to be EGL first and if it fails,
> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available.
>
>
> See:
> [Switching the Linux graphics stack from GLX to
> EGL](https://mozillagfx.wordpress.com
> In some situations, a part of the SG is no longer rendered.
> I created a test program that showcases this problem.
>
> Explanation:
>
> This can happen, when a part of the SG, is covered by another Node.
> In this part, one node is totally covered, and the other node is visible.
>
> When the
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
23 matches
Mail list logo
