On Mon, 29 Apr 2024 14:09:52 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert using utility method > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java > line 104: > >> 102: int length = text.length(); >> 103: start = Utils.clamp(0, start, length); >> 104: end = Utils.clamp(start, end, length); > > This is only cleanup and not required for this fix. I applied the software engineering principle to leave the code cleaner than seen. (Martin Fowler et all) Should I revert this? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1583314511
