Re: RFR: 8332539: Update libxml2 to 2.12.7

2024-05-27 Thread Joeri Sykora
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen Tests are green here as well. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1464#pullrequestreview-2080216007

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-05-27 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X concept when >> the window appea

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v21]

2024-05-27 Thread Thiago Milczarek Sayao
> This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Screencast from 17-09-2023 > 21:59:04.webm](https://github.com/openj

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v13]

2024-05-27 Thread Thiago Milczarek Sayao
> Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: > [Switching the Linux graphics stack from GLX to > EGL](https://mozillagfx.wordpress.com

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v13]

2024-05-27 Thread Thiago Milczarek Sayao
On Mon, 27 May 2024 09:30:18 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

Re: RFR: 8311895: CSS Transitions [v20]

2024-05-27 Thread drmarmac
On Sun, 26 May 2024 08:08:26 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the >> `Interpolatable` interface.

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v6]

2024-05-27 Thread Marius Hanl
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is > broken when `sizeToScene()` was called before or after. > > The approach here is to ignore the `sizeToScene()` request when the `Stage` > is maximized or set to fullscreen. > Otherwise the Window Manager of the OS

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v7]

2024-05-27 Thread Marius Hanl
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is > broken when `sizeToScene()` was called before or after. > > The approach here is to ignore the `sizeToScene()` request when the `Stage` > is maximized or set to fullscreen. > Otherwise the Window Manager of the OS

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-05-27 Thread Jose Pereda
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =

Re: RFR: 8322964: Optimize performance of CSS selector matching [v10]

2024-05-27 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized and

Re: RFR: 8322964: Optimize performance of CSS selector matching [v11]

2024-05-27 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized and

Re: RFR: 8322964: Optimize performance of CSS selector matching [v12]

2024-05-27 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized and

Re: RFR: 8322964: Optimize performance of CSS selector matching [v9]

2024-05-27 Thread John Hendrikx
On Sat, 25 May 2024 13:50:56 GMT, Kevin Rushforth wrote: >> The code looks good. I didn't test it, but I'm fine with integrating. > >> Also some clarification on the contributing rules: "all Reviewers who have >> requested the chance to review have done so" -- does the indication at the >> top