Re: RFR: 8311895: CSS Transitions [v17]

On Tue, 4 Jun 2024 21:14:54 GMT, Kevin Rushforth wrote: >> I think it's fine. Another option is to link to the part of the reference >> where they are. > > I would prefer to keep them in one place (scene) and link to the ones there > (`../scene/doc-files/`). I've linked to the files in `scene/

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v7]

On Mon, 27 May 2024 19:41:18 GMT, Marius Hanl wrote: >> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` >> is broken when `sizeToScene()` was called before or after. >> >> The approach here is to ignore the `sizeToScene()` request when the `Stage` >> is maximized or

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v3]

On Thu, 23 May 2024 13:48:48 GMT, Marius Hanl wrote: >> The fix looks good. The spec changes (updated javadocs) look good. Can you >> create the CSR for the spec change? >> >> I have a couple overall comments: >> >> * I wanted to verify different orders of operation, so I wrote a (manual) >>

Re: RFR: 8311895: CSS Transitions [v22]

On Wed, 5 Jun 2024 21:47:21 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html >> line 704: >> >>> 702: >>> 703: >> scope="row">transition‑property >>> 704: [ none | all | # >>> ] >> >> Why is there a

Re: RFR: 8311895: CSS Transitions [v23]

> Implementation of [CSS Transitions](https://www.w3.org/TR/css-transitions-1/). > > ### Future enhancements > CSS transition support for backgrounds and borders: #1471 > > ### Limitations > This implementation supports both shorthand and longhand notations for the > `transition` property. Howe

Re: RFR: 8311895: CSS Transitions [v22]

On Wed, 5 Jun 2024 17:43:46 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 62 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - document css parser

Re: RFR: 8277848: Binding and Unbinding to List leads to memory leak [v10]

On Wed, 5 Jun 2024 07:29:58 GMT, Florian Kirmaier wrote: >> Florian Kirmaier has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 10 commits: >> >> - Merge branch 'openjdk:master' into JDK-8277848-list-binding-leak >> - JDK-8277848 >

Re: RFR: 8311895: CSS Transitions [v22]

On Fri, 31 May 2024 15:09:38 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://www.w3.org/TR/css-transitions-1/). >> >> ### Future enhancements >> CSS transition support for backgrounds and borders: #1471 >> >> ### Limitations >> This implementation supports both sh

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 20:49:08 GMT, Nir Lisker wrote: >> I've included the images that are also used in the CSS reference >> documentation. Now there are two copies of these images in two different >> `doc-files` folders, but I guess that's okay. > > I think it's fine. Another option is to link t

Re: RFR: 8330304: MenuBar: Invisible Menu works incorrectly with keyboard arrows [v2]

On Fri, 31 May 2024 15:17:19 GMT, Andy Goryachev wrote: >> The root cause is that the skin used two fields to store one entity >> (`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible >> menu(s) are present. >> >> The fix involves using a single index variable. >> >> Also wa

Re: RFR: 8314683: TextArea: scroll bar size and content padding

On Wed, 5 Jun 2024 15:31:05 GMT, Andy Goryachev wrote: > It does not look right either, the UI elements should not get scaled in my > opinion, only the text. I'd rather have a consistent size of UI elements in > an application. This will need further discussion. - PR Comment: htt

Re: RFR: 8314683: TextArea: scroll bar size and content padding

On Fri, 31 May 2024 21:50:08 GMT, Andy Goryachev wrote: > Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px` > in modena.css to make them independent of the font size *in that control*. > > After the change, the UI still looks good which can be tested by scaling > def

Re: RFR: 8314683: TextArea: scroll bar size and content padding

On Wed, 5 Jun 2024 14:52:37 GMT, Andy Goryachev wrote: > > This PR presupposes that the scroll bar size and content padding _should_ > > be changed to be independent of the font size > > I disagree. The size of the UI elements enveloping a content area should not > depend on the font size of t

Re: RFR: 8314683: TextArea: scroll bar size and content padding

On Wed, 5 Jun 2024 14:47:55 GMT, Kevin Rushforth wrote: > This PR presupposes that the scroll bar size and content padding _should_ be > changed to be independent of the font size I disagree. The size of the UI elements enveloping a content area should not depend on the font size of the font

Re: RFR: 8314683: TextArea: scroll bar size and content padding

On Fri, 31 May 2024 21:50:08 GMT, Andy Goryachev wrote: > Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px` > in modena.css to make them independent of the font size *in that control*. > > After the change, the UI still looks good which can be tested by scaling > def

Integrated: 8332748: Grammatical errors in animation API docs

On Wed, 29 May 2024 06:53:40 GMT, Lukasz Kostyra wrote: > Checked code and fixed the gramatical error in Transition files: > s/interval/intervals > > Fill and Stroke Transition had correct grammatical form already, so those > were untouched. I couldn't find any other instances of this error in

Integrated: 8323511: Scrollbar Click jumps inconsistent amount of pixels

On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier wrote: > As seen in the unit test of the PR, when we click on the area above/below the > scrollbar the position jumps - but the jump is now not always consistent. > In the current version on the last cell - the UI always jumps to the top. In >

Re: RFR: 8277848: Binding and Unbinding to List leads to memory leak [v10]

On Wed, 5 Jun 2024 07:24:35 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which is b

Re: RFR: 8277848: Binding and Unbinding to List leads to memory leak [v10]

> Making the initial listener of the ListProperty weak fixes the problem. > The same is fixed for Set and Map. > Due to a smart implementation, this is done without any performance drawback. > (The trick is to have an object, which is both the WeakReference and the > Changelistener) > By implying