Re: [External] : Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Nir Lisker
https://github.com/eclipse/buildship/issues/658 is not that relevant because it describes a problem in Gradle's integration with Eclipse, not with Buildship, but it's reported on Buildship, so I don't think there's much to resolve there except for alignment issues. It has since been solved on Gradl

Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Nir Lisker
It has been a while since I tried a clean import of jfx, but the instructions in https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse seem correct, unless something changed. What you describe is written there. Only the initial import requires a gradle build, and after rever

Re: [External] : Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Andy Goryachev
Thank you Kevin, for this bit of insight. I see the Buildship issue mentioned in one of the comments is still open with no one assigned https://github.com/eclipse/buildship/issues/658 Chances that it will be fixed in a reasonable time frame are slim to none. I would recommend to make the chan

Re: [External] : Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Kevin Rushforth
We also did that for NetBeans, meaning we removed the NetBeans IDE-specific files and use their gradle plug-in (with somewhat mixed results). See https://bugs.openjdk.org/browse/JDK-8223375 FWIW, there is an open issue to do the same for Eclipse, but I think it hasn't been looked at in a while

Re: Platform diferences

2024-06-18 Thread Martin Fox
The alert is being shown without setting its screen or position so it will default to the primary screen regardless of where the main window is. It might make sense for new windows to default to the screen of the active stage to reduce these sorts of surprises. In any case it looks like this dec

Re: [External] : Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Andy Goryachev
Interesting, thank you, Thiago. Maybe it's just the quality of gradle support in IntelliJ, or complexity of the Buildship plug-in in Eclipse. It never worked for me, and removing the gradle nature from Eclipse project files has an added benefit of removing an extra dependency. -andy From:

Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Thiago Milczarek Sayão
Andy, We kind of did the opposite for Intellij (got rid of the .iml files and went for gradle import): https://github.com/openjdk/jfx/pull/1009 I couldn't get it to detect the manual tests tho. Changing some gradle files worked, but would require a deeper review, so we went without it. -- Thiag

Eclipse and Gradle in OpenJFX

2024-06-18 Thread Andy Goryachev
Dear developers: Does anyone use gradle in Eclipse (Buildship plug-in) with the OpenJFX repo? The reason I am asking is that in my experience, the gradle nature in OpenJFX is either misconfigured, or obsolete, or both. There is a rather old wiki page [0] which describes the Eclipse setup, thou

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v2]

2024-06-18 Thread Andy Goryachev
On Tue, 14 May 2024 22:29:18 GMT, Martin Fox wrote: >> On Linux getKeyCodeForChar does not consult the current keyboard layout. For >> example, it assumes the “+” character is on KeyCode.PLUS even on layouts >> which don’t generate KeyCode.PLUS. The result is that most >> KeyCharacterCombinati

Re: RFR: 8327255: javac lint warnings: removal, missing-explicit-ctor

2024-06-18 Thread Ambarish Rapte
On Wed, 12 Jun 2024 20:03:24 GMT, Kevin Rushforth wrote: > This PR updates `build.gradle` to define javac lint options for three > different types of java compilation tasks: sdk classes, test classes > (including shims), and tool classes (including JSLC). The defaults for these > three groups