RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-06-19 Thread Jay Bhaskar
Issue: The Websocket Channel is broken Solution: The socket Provider needs a web page pointer, since the web socket channel source code is moved to WebkitLegacy in 617.1 for the web process model, it is invalid for JavaFx Webkit. - Commit messages: - add pass and fail button -

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-19 Thread Martin Fox
On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-19 Thread Martin Fox
On Mon, 17 Jun 2024 17:53:53 GMT, Andy Goryachev wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-19 Thread Martin Fox
On Mon, 17 Jun 2024 17:53:53 GMT, Andy Goryachev wrote: > I cannot invoke Japanese IME or in fact switch to another input language if I > am inside an editable TableView in the Monkey Tester. I'm also seeing bad behavior in a TableView using IBus on Ubuntu 22. Glass is being told to disable

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-06-19 Thread Ambarish Rapte
On Thu, 13 Jun 2024 20:07:32 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with two

RFR: 8088923: IOOBE when adding duplicate categories to the BarChart

2024-06-19 Thread Markus Mack
This PR provides the test case given in the JBS issue, and a simple fix for the index calculation when inserting data after previous data with duplicate categories. Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior that was apparently assumed (but broken) previously.