On Mon, 24 Jun 2024 18:05:09 GMT, Jose Pereda wrote:
> This PR considers the horizontal scroll events that can be generated on a
> trackpad, on an horizontally sided `TabPane` control (top or bottom), adding
> to the existing vertical scroll events from mouse wheel and trackpad, to
> scroll it
On Fri, 21 Jun 2024 12:50:45 GMT, Kevin Rushforth wrote:
> This PR enables two warnings that are now (or soon will be) enabled in the
> [jdk](https://github.com/openjdk/jdk) repo:
>
> 1. Binary file check -- this will alert the reviewers of a PR that the patch
> being reviewed includes one or
On Mon, 24 Jun 2024 22:17:13 GMT, Kevin Rushforth wrote:
> Do ScrollPane or ListView work this way already?
Good point - both have the same issue (I am sure other controls as well,
TableView, others did not check). Definitely deserves a separate ticket,
possibly even an umbrella task (RTL nav
On Mon, 24 Jun 2024 22:17:13 GMT, Kevin Rushforth wrote:
> I don't recommend doing that as part of this PR. That would be a noticeable
> behavior change, and warrants more discussion
we **are** changing the behavior already by changing the direction of the
gesture, so I thought we should be ab
On Mon, 24 Jun 2024 22:01:09 GMT, Phil Race wrote:
> The problem is due to per-user install fonts on windows having full paths so
> they may be too long.
> This is identical to the JDK fix that was done some time ago
> https://github.com/openjdk/jdk/pull/13359
> I've tested that per-user fonts
On Fri, 21 Jun 2024 15:22:57 GMT, Kevin Rushforth wrote:
> GitHub Actions: add a macOS / aarch64 build using a macOS 14 test runner and
> a macOS / aarch64 boot JDK. This is a brute force approach that duplicates
> the job config (I don't want to spend the time to figure out how to
> parameter
On Mon, 24 Jun 2024 19:37:02 GMT, Andy Goryachev wrote:
> 1. For Side.LEFT/RIGHT, reverse the direction. What we have now is
> inconsistent with the movement of e.g. ListView (can be seen if using track
> pad with the list view and TabPane in the Monkey Tester):
I don't recommend doing that as
This PR is a fix for another IOOBE that I discovered while working on #1476.
The PR simplifies the code for adding a series that already contains data by
adding the data points one-by-one.
As far as I can see no attempt was previously made to optimize the bulk
operation except for some trivial O
The problem is due to per-user install fonts on windows having full paths so
they may be too long.
This is identical to the JDK fix that was done some time ago
https://github.com/openjdk/jdk/pull/13359
I've tested that per-user fonts still work and so do the system-wide installed
fonts.
---
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc, clarifying
On Mon, 24 Jun 2024 19:37:02 GMT, Andy Goryachev wrote:
> And, a question - does this change require a CSR, since we are changing the
> behavior?
Good question. Thinking out loud, if what this PR does is to change the
existing behavior of top/bottom TabPane scrolling (e.g., horizontal scrollba
Hi all,
I didn't try this with older JavaFX versions but I found a page that
does not work if I render using the JavaFX browser.
https://www.reonis.com/uatu/dungeoncraft/parts/iconmaker.html
If you try this in firefox/chrome it works fine.
Can anyone confirm?
TIA
On Mon, 24 Jun 2024 18:05:09 GMT, Jose Pereda wrote:
> This PR considers the horizontal scroll events that can be generated on a
> trackpad, on an horizontally sided `TabPane` control (top or bottom), adding
> to the existing vertical scroll events from mouse wheel and trackpad, to
> scroll it
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc, clarifying
On Fri, 21 Jun 2024 16:11:52 GMT, Markus Mack wrote:
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
This pull request has now been integrated.
Changeset: 17c2dba0
Author:Markus Mack
Committer: Andy Goryachev
URL:
https://git.openjdk.org/j
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s javadoc, clarifying the
This PR considers the horizontal scroll events that can be generated on a
trackpad, on an horizontally sided `TabPane` control (top or bottom), adding to
the existing vertical scroll events from mouse wheel and trackpad, to scroll
its tabs.
Therefore, scrolling a `TabPane` will behave in the sa
8329705: Add missing Application thread checks to platform specific a11y methods
-
Commit messages:
- Backport 0eb4d7196099d817cc6467985b882242845bdd2e
Changes: https://git.openjdk.org/jfx21u/pull/61/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=61&range=00
Issue: ht
8329705: Add missing Application thread checks to platform specific a11y methods
-
Commit messages:
- Backport 0eb4d7196099d817cc6467985b882242845bdd2e
Changes: https://git.openjdk.org/jfx17u/pull/194/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=194&range=00
Issue:
On Mon, 24 Jun 2024 13:47:54 GMT, Johan Vos wrote:
> 8301312: Create implementation of NSAccessibilityButton protocol
This pull request has now been integrated.
Changeset: cf66048e
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/cf66048eb7519a2c652ccf388218c385e8820151
S
On Sat, 22 Jun 2024 13:37:30 GMT, Kevin Rushforth wrote:
>> This PR updates `build.gradle` to define javac lint options for three
>> different types of java compilation tasks: sdk classes, test classes
>> (including shims), and tool classes (including JSLC). The defaults for these
>> three gro
On Fri, 21 Jun 2024 12:50:45 GMT, Kevin Rushforth wrote:
> This PR enables two warnings that are now (or soon will be) enabled in the
> [jdk](https://github.com/openjdk/jdk) repo:
>
> 1. Binary file check -- this will alert the reviewers of a PR that the patch
> being reviewed includes one or
On Sat, 22 Jun 2024 10:58:53 GMT, Markus Mack wrote:
> I can reproduce this, looks unrelated to the issue this PR is trying to fix.
Created https://bugs.openjdk.org/browse/JDK-8334873
-
PR Comment: https://git.openjdk.org/jfx/pull/1476#issuecomment-2186856495
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc, clarifying
On Sat, 22 Jun 2024 10:52:42 GMT, Markus Mack wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/chart/BarChart.java line
>> 227:
>>
>>> 225: var uniqueCategories = new HashSet();
>>> 226: for (var entry : seriesCategoryMap.entrySet()) {
>>> 227:
8301312: Create implementation of NSAccessibilityButton protocol
-
Commit messages:
- Backport 05548ace27f099a5ce152e3fb9efb4d22da683c8
Changes: https://git.openjdk.org/jfx17u/pull/193/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=193&range=00
Issue: https://bugs.ope
26 matches
Mail list logo
