On Fri, 28 Jun 2024 08:49:49 GMT, Prasanta Sadhukhan
wrote:
> Adding, then removing, and then adding a JFXPanel to the same component in
> the Swing scene graph leads to a NullPointerException in GlassScene because
> the sceneState is null.
> Removing JFXPanel calls JFXPanel.removeNotify which
Dear fellow developers:
Should we document which properties are styleable with CSS in javadoc? Would
that be useful?
Example:
/**
* Determines the caret blink period. This property cannot be set to
{@code null}.
*
* This is a {@link StyleableProperty} with the name {@
On Fri, 28 Jun 2024 18:22:36 GMT, Phil Race wrote:
>> Updated to return a blank image if permission is not granted.
>
>> Since `SecurityException` is deprecated, we should not throw that.
>>
>> In a similar situation on macOS (user has not enabled screen capture), we
>> return a blank (all blac
On Fri, 28 Jun 2024 18:07:52 GMT, Alexander Zvegintsev
wrote:
>> Since `SecurityException` is deprecated, we should not throw that.
>>
>> In a similar situation on macOS (user has not enabled screen capture), we
>> return a blank (all black) image, so I think that's what we would do here.
>
>
On Fri, 28 Jun 2024 13:20:57 GMT, Kevin Rushforth wrote:
>>> If the SecurityException is not thrown, how does the caller of getRGBPixels
>>> knows that the result will not be correct because of the missing
>>> permission? (as opposed to being incorrect due to a failure)
>>
>> He won't know it.
On Fri, 28 Jun 2024 13:52:10 GMT, Kevin Rushforth wrote:
>> Johan makes a good point, so go ahead and add it back.
>
> Worth noting is that this `HEADLESS` check is just an assertion to verify
> that the build logic properly excludes the file from the build when building
> headless. It otherwis
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Instead, screen capture functionality is managed by the compositor, which can
> enforce stricte
On Fri, 28 Jun 2024 07:39:46 GMT, Markus Mack wrote:
>> This PR fixes the placement of `BarChart` bars and category tick marks,
>> particularly when adding data / multiple series and enabling animations.
>> It covers all cases mentioned in the JBS ticket and adds a unit test.
>>
>> The settable
On Fri, 28 Jun 2024 13:54:54 GMT, Thiago Milczarek Sayao
wrote:
> Just of out curiosity, please don't mind it too much:
>
> Why the piperwire include files are included? Since the infraestucture should
> be present for it to work (pipewire is quite new and not present on older
> linux distrib
On Fri, 28 Jun 2024 08:49:49 GMT, Prasanta Sadhukhan
wrote:
> Adding, then removing, and then adding a JFXPanel to the same component in
> the Swing scene graph leads to a NullPointerException in GlassScene because
> the sceneState is null.
> Removing JFXPanel calls JFXPanel.removeNotify which
On Fri, 28 Jun 2024 08:49:49 GMT, Prasanta Sadhukhan
wrote:
> Adding, then removing, and then adding a JFXPanel to the same component in
> the Swing scene graph leads to a NullPointerException in GlassScene because
> the sceneState is null.
> Removing JFXPanel calls JFXPanel.removeNotify which
On Fri, 28 Jun 2024 13:12:57 GMT, Kevin Rushforth wrote:
>> I already did the removal earlier, but I can bring it back once we come to
>> an agreement.
>
> Johan makes a good point, so go ahead and add it back.
Worth noting is that this `HEADLESS` check is just an assertion to verify that
the
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Instead, screen capture functio
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Instead, screen capture functio
On Fri, 28 Jun 2024 10:05:48 GMT, Alexander Zvegintsev
wrote:
>> If the SecurityException is not thrown, how does the caller of
>> `getRGBPixels` knows that the result will not be correct because of the
>> missing permission? (as opposed to being incorrect due to a failure)
>
>> If the Securit
On Fri, 28 Jun 2024 08:01:09 GMT, Alexander Zvegintsev
wrote:
>> With the headless platform that I started in the sandbox project, there is
>> the concept of headless, but rather than compiling native code with `#ifdef
>> HEADLESS` the current approach is to avoid those native compilations at
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
> In some situations, a part of the SG is no longer rendered.
> I created a test program that showcases this problem.
>
> Explanation:
>
> This can happen, when a part of the SG, is covered by another Node.
> In this part, one node is totally covered, and the other node is visible.
>
> When the
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is marked
> as clean, all descendants must also be marked
> In some situations, a part of the SG is no longer rendered.
> I created a test program that showcases this problem.
>
> Explanation:
>
> This can happen, when a part of the SG, is covered by another Node.
> In this part, one node is totally covered, and the other node is visible.
>
> When the
On Fri, 28 Jun 2024 09:44:03 GMT, Johan Vos wrote:
> If the SecurityException is not thrown, how does the caller of getRGBPixels
> knows that the result will not be correct because of the missing permission?
> (as opposed to being incorrect due to a failure)
He won't know it. An indirect resul
On Sat, 18 May 2024 14:11:36 GMT, Kevin Rushforth wrote:
>>> At a minimum I think the tests that are part of this PR should be included
>>> in FX whichever fix ends up being integrated.
>>
>> The test has already been added to both PRs.
>>
>>> I'm only wondering if the code in ``paintImpl`` sh
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is marked
> as clean, all descendants must also be marked
On Fri, 28 Jun 2024 05:17:41 GMT, Ambarish Rapte wrote:
>> eduardsdv has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - JDK-8322619: Fix waiting for the stage
>> - JDK-8322619: Improve output message in test
>> - JDK-8322619: Avoid us
On Fri, 28 Jun 2024 07:49:26 GMT, Alexander Zvegintsev
wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents directly.
>> Instead, screen capture f
Adding, then removing, and then adding a JFXPanel to the same component in the
Swing scene graph leads to a NullPointerException in GlassScene because the
sceneState is null.
Removing JFXPanel calls JFXPanel.removeNotify which calls Window.hide which
calls SceneHelper.disposePeer -> Scene.dispos
On Fri, 28 Jun 2024 07:04:18 GMT, Johan Vos wrote:
>> I don't have a strong opinion. This file is unchanged relative to the
>> original in AWT. The other three already have some changes, so I'd probably
>> lean toward removing it.
>
> With the headless platform that I started in the sandbox pro
On Thu, 27 Jun 2024 18:26:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/fp_pipewire.h line 26:
>>
>>> 24: */
>>> 25:
>>> 26: #ifdef HEADLESS
>>
>> There is no HEADLESS build for JavaFX. I see the same ifdef in other C
>> files in this PR.
>> I guess its
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Instead, screen capture functio
On Wed, 26 Jun 2024 20:06:33 GMT, Phil Race wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents directly.
>> Instead, screen capture functionality
On Wed, 26 Jun 2024 20:14:26 GMT, Phil Race wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents directly.
>> Instead, screen capture functionality
Most of the headful test failures on XWayland are due to screen capture is not
working.
Wayland, unlike X11, does not allow arbitrary applications to capture the
screen contents directly.
Instead, screen capture functionality is managed by the compositor, which can
enforce stricter controls and
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Instead, screen capture functio
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Instead, screen capture functio
On Thu, 27 Jun 2024 18:15:53 GMT, Kevin Rushforth wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents directly.
>> Instead, screen capture functio
One of those PR's was mine, but I didn't touch it at all, I initially
thought there were new comments.
--John
On 27/06/2024 19:53, Kevin Rushforth wrote:
I'm not sure why Skara is replaying some old RFR messages from last
year and earlier this year. It's either a glitch, or the bot is
finally
> This PR fixes the placement of `BarChart` bars and category tick marks,
> particularly when adding data / multiple series and enabling animations.
> It covers all cases mentioned in the JBS ticket and adds a unit test.
>
> The settable `barGap` and `categoryGap` now should also behave as expect
37 matches
Mail list logo
