As a reminder, JavaFX 23 RDP1 starts tomorrow, July 11th. I will fork
the 'jfx23' branch at 16:00 UTC.
-- Kevin
On 6/21/2024 12:08 PM, Kevin Rushforth wrote:
As a reminder, Rampdown Phase 1 (RDP1) for JavaFX 23 starts on July
11, 2024 at 16:00 UTC (09:00 Pacific time), a little less than thre
On Wed, 10 Jul 2024 09:42:57 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
I don't know the internals of the JavaFX CSS parser but regarding the CSS
variable spec itself we could start by simply supporting numeric values as
well as colors. This would already allow developers to use variables
anywhere which would simplify and make managing stylesheets easier.
On Wed, Jul
On Wed, 10 Jul 2024 17:04:55 GMT, Ambarish Rapte wrote:
> Update the copyright year in files modified in year 2024.
Looks good.
Given that we want to get this in before the `jfx23` fork, I approve
integrating it tomorrow (Thursday) some time before 1600 UTC, even though that
will be slightly
On Wed, 10 Jul 2024 09:42:57 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Wed, 10 Jul 2024 09:40:03 GMT, Marius Hanl wrote:
> The Tooltip timing looks much better now in the tests. I decided to use 80ms
> as a threshhold. In my testing, I got a maximum difference of ~35 ms.
>
> Also merged in master.
Thanks. I'll test and re-review.
-
PR Comment: ht
On Wed, 10 Jul 2024 15:03:56 GMT, Andy Goryachev wrote:
> my comment was to avoid replicating "data:base64,", and with that, it is not
> base64 anymore, but base-64-encoded url.
I see.
> the best place for this method is probably in some utility class so it can be
> reused.
Definitely, but l
On Wed, 10 Jul 2024 14:36:51 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits
On Wed, 10 Jul 2024 15:00:31 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TooltipTest.java
>> line 709:
>>
>>> 707: }
>>> 708:
>>> 709: private String toBase64(String css) {
>>
>> suggestion:
>>
>> private static String encode(String
Update the copyright year in files modified in year 2024.
-
Commit messages:
- 8336110: Update copyright header for files modified in 2024
Changes: https://git.openjdk.org/jfx/pull/1500/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1500&range=00
Issue: https://bugs.open
I agree - having CSS variables will definitely help. Personally, I would
rather see a better way to create stylesheets programmatically, bypassing the
whole parsing routine, but I am sure a lot of people would be more comfortable
if things were similar to web css.
Enabling CSS variables seems
If that is in line with what most people want, I can create a PR to
add this to the CONTRIBUTING.md file.
All good from my point of view. That would be great, thank you.
-- Kevin
On 7/10/2024 12:25 AM, Johan Vos wrote:
Thanks all for commenting.
What I have read so far seems that there is
I'll file a bug for this, as I feel partly responsible for uncovering
this behavior by fixing the other bug :)
I also did a deeper dive into the code already, and the comment in the
resolve lookup code seems to be misleading. It claims that it must know
the origin of the lookup so it doesn't
Sounds good. Maybe also add that junit 5 should be used and 4 is just
legacy.
Note that the wiki also has instructions related to tests, but I think it's
just for running them.
On Wed, Jul 10, 2024, 10:25 Johan Vos wrote:
> Thanks all for commenting.
> What I have read so far seems that there i
> This PR fixes a long standing issue where the `Tooltip` will always wait one
> second until it appears the very first time, even if the
> `-fx-show-delay` was set to another value.
>
> The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside
> the `TooltipBehaviour`. So t
On Thu, 4 Jul 2024 09:32:39 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not i
On Mon, 8 Jul 2024 17:49:10 GMT, Andy Goryachev wrote:
>> Thought about this well, didn't test yet
>
> see for example
> https://github.com/openjdk/jfx/blob/72701e6cb4095b8f5042f54ae6bb2c0cec446bcf/modules/javafx.graphics/src/test/java/test/javafx/scene/Node_transition_Test.java#L142
Ah, looks
On Tue, 9 Jul 2024 11:38:30 GMT, Kevin Rushforth wrote:
>> Another possibility is the code that measures the time it takes to show the
>> tooltip.
>>
>> The current code uses Util.waitForLatch(), L244 which was written for a
>> different use case and actually introduces a small measurement err
Thanks all for commenting.
What I have read so far seems that there is an agreement for this approach:
* don't prefix tests with `test` anymore
* use a (somehow) descriptive name
* add a comment that refers to the JBS issue that this test is dealing with
* (optional) in case the test or test scenar
19 matches
Mail list logo
